* [PATCH 1/2] extcon: arizona: Remove additional increment for jack flips
@ 2013-02-05 10:08 Charles Keepax
2013-02-05 17:04 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Charles Keepax @ 2013-02-05 10:08 UTC (permalink / raw)
To: cw00.choi, myungjoo.ham; +Cc: broonie, patches, linux-kernel
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
drivers/extcon/extcon-arizona.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
index 3aacacc..5f91711 100644
--- a/drivers/extcon/extcon-arizona.c
+++ b/drivers/extcon/extcon-arizona.c
@@ -722,8 +722,6 @@ static irqreturn_t arizona_micdet(int irq, void *data)
* impedence then give up and report headphones.
*/
if (info->detecting && (val & 0x3f8)) {
- info->jack_flips++;
-
if (info->jack_flips >= info->micd_num_modes) {
dev_dbg(arizona->dev, "Detected HP/line\n");
arizona_identify_headphone(info);
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] extcon: arizona: Remove additional increment for jack flips
2013-02-05 10:08 [PATCH 1/2] extcon: arizona: Remove additional increment for jack flips Charles Keepax
@ 2013-02-05 17:04 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2013-02-05 17:04 UTC (permalink / raw)
To: Charles Keepax; +Cc: cw00.choi, myungjoo.ham, patches, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 375 bytes --]
On Tue, Feb 05, 2013 at 10:08:40AM +0000, Charles Keepax wrote:
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
These conflict with patches I've already sent (and which I already
posted). I'll roll these into a series and resend.
Patch 2 doesn't actually seem to reflect the chip behaviour, though I've
not managed to track down why it's not needed.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-05 17:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-05 10:08 [PATCH 1/2] extcon: arizona: Remove additional increment for jack flips Charles Keepax
2013-02-05 17:04 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).