* [PATCH 0/4] pci: Add PCI_BUS() and PCI_DEVID() interfaces to return bus number and device id
@ 2013-02-11 23:00 Shuah Khan
2013-02-13 12:03 ` Joerg Roedel
0 siblings, 1 reply; 2+ messages in thread
From: Shuah Khan @ 2013-02-11 23:00 UTC (permalink / raw)
To: Joerg Roedel, bhelgaas
Cc: jiang.liu, shemminger, paulmck, linasvepstas, dhowells, davej,
tglx, mtk.manpages, iommu, linux-pci, wangyijing, LKML,
shuahkhan
pci defines PCI_DEVFN(), PCI_SLOT(), and PCI_FUNC() interfaces, however,
it doesn't have interfaces to return PCI bus and PCI device id. Drivers
(AMD IOMMU, and AER) have module specific definitions for PCI_BUS() and
AMD_IOMMU driver also has a module specific interface to calculate PCI
device id from bus number and devfn.
This patch set adds PCI_BUS(), and PCI_DEVID() to pci.h, changes are to
use PCI_BUS() from pci. Changes AMD_IOMMU driver to use PCI_BUS() and
PCI_DEVID() from pci.
Files changed:
include/uapi/linux/pci.h | 4 ++++
1 file changed, 4 insertions(+)
drivers/pci/pcie/aer/aerdrv_core.c | 2 --
1 file changed, 2 deletions(-)
drivers/iommu/amd_iommu_types.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
drivers/iommu/amd_iommu.c | 2 +-
drivers/iommu/amd_iommu_init.c | 6 +++---
drivers/iommu/amd_iommu_types.h | 7 -------
3 files changed, 4 insertions(+), 11 deletions(-)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 0/4] pci: Add PCI_BUS() and PCI_DEVID() interfaces to return bus number and device id
2013-02-11 23:00 [PATCH 0/4] pci: Add PCI_BUS() and PCI_DEVID() interfaces to return bus number and device id Shuah Khan
@ 2013-02-13 12:03 ` Joerg Roedel
0 siblings, 0 replies; 2+ messages in thread
From: Joerg Roedel @ 2013-02-13 12:03 UTC (permalink / raw)
To: bhelgaas
Cc: Shuah Khan, jiang.liu, shemminger, paulmck, linasvepstas,
dhowells, davej, tglx, mtk.manpages, iommu, linux-pci,
wangyijing, LKML, shuahkhan
Hi Bjorn,
On Mon, Feb 11, 2013 at 04:00:14PM -0700, Shuah Khan wrote:
> pci defines PCI_DEVFN(), PCI_SLOT(), and PCI_FUNC() interfaces, however,
> it doesn't have interfaces to return PCI bus and PCI device id. Drivers
> (AMD IOMMU, and AER) have module specific definitions for PCI_BUS() and
> AMD_IOMMU driver also has a module specific interface to calculate PCI
> device id from bus number and devfn.
>
> This patch set adds PCI_BUS(), and PCI_DEVID() to pci.h, changes are to
> use PCI_BUS() from pci. Changes AMD_IOMMU driver to use PCI_BUS() and
> PCI_DEVID() from pci.
Not sure who is going to merge this, it touches PCI and IOMMU code.
Personally I don't care :-) If you want to take it via your tree feel
free to add my
Reviewed-by: Joerg Roedel <joro@8bytes.org>
Tested-by: Joerg Roedel <joro@8bytes.org>
Acked-by: Joerg Roedel <joro@8bytes.org>
Otherwise please Ack the PCI parts and I will add it to my tree then.
Thanks,
Joerg
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-13 12:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-11 23:00 [PATCH 0/4] pci: Add PCI_BUS() and PCI_DEVID() interfaces to return bus number and device id Shuah Khan
2013-02-13 12:03 ` Joerg Roedel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).