linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Youquan Song <youquan.song@linux.intel.com>
To: Ingo Molnar <mingo@kernel.org>, Yinghai Lu <yinghai@kernel.org>
Cc: Yinghai Lu <yinghai@kernel.org>, Gleb Natapov <gleb@redhat.com>,
	Youquan Song <youquan.song@intel.com>,
	Sheng Yang <sheng@linux.intel.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"H. Peter Anvin" <hpa@linux.intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>,
	youquan.song@linux.intel.com
Subject: Re: [PATCH] x86, apic: Enable x2APIC physical when cpu < 256 native
Date: Wed, 14 Aug 2013 14:40:41 -0400	[thread overview]
Message-ID: <20130814184040.GA6726@linux-youquan.bj.intel.com> (raw)
In-Reply-To: <20130729170514.GB30371@linux-youquan.bj.intel.com>

> In order to make sure the patch without involving unexpected issues beyond
> I can understand, I will confirm with our expert about it.
> 
> so please pend the patch going to mainline. If the patch can move on, I
> think I will also provide other patch changing, like direct EOI.

Hi Yinghai and Ingo,

I have confirmed with our experts about it. x2APIC without interrupt
remapping is not architecture and no guarantee it will work in future.

What's more, there are some words in SDM3, 
10.12.7 Initialization by System
Software Routing of device interrupts to local APIC units operating in
x2APIC mode requires use of the interrupt-remapping architecture
specified in the Intel Virtualization Technology for Directed I/O,
Revision 1.3. Because of this, BIOS must enumerate support for and
software must enable this interrupt remapping with Extended Interrupt
Mode Enabled before it enabling x2APIC mode in the local APIC units.

Ingo, please drop the patch in -tip tree.
3d1acb49d22fbbae96524040e9e2d4cbbb3adbef "x86/apic: Enable x2APIC
physical mode on native hardware too, when there are fewer than 256 
CPUs" 

Sorry for making fuss here and it is my fault. 

Thanks
-Youquan

  reply	other threads:[~2013-08-14  6:56 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-12  1:22 [PATCH] x86, apic: Enable x2APIC physical when cpu < 256 native Youquan Song
2013-07-23  9:17 ` Ingo Molnar
2013-07-24 14:04   ` Youquan Song
2013-07-25 22:01     ` Ingo Molnar
2013-07-29 16:48       ` Youquan Song
2013-07-24  3:55 ` [tip:x86/apic] x86/apic: Enable x2APIC physical mode on native hardware too, when there are fewer than 256 CPUs tip-bot for Youquan Song
2013-07-24  4:24 ` [PATCH] x86, apic: Enable x2APIC physical when cpu < 256 native Yinghai Lu
2013-07-24  6:22   ` Gleb Natapov
2013-07-25 14:05     ` Yinghai Lu
2013-07-29 17:05       ` Youquan Song
2013-08-14 18:40         ` Youquan Song [this message]
2013-08-14 11:11           ` Ingo Molnar
2013-08-17 13:44             ` Youquan Song
2013-08-17  7:42               ` Ingo Molnar
2013-08-17  8:24                 ` Borislav Petkov
2013-08-17  9:03                   ` Joe Perches
2013-08-17 15:44                     ` Borislav Petkov
2013-08-17 16:26                       ` Joe Perches
2013-08-18 10:02                         ` Borislav Petkov
2013-08-17 19:52                 ` Youquan Song
2013-08-19  7:11                   ` Ingo Molnar
2013-08-02 19:12       ` Konrad Rzeszutek Wilk
2013-07-24 14:45   ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130814184040.GA6726@linux-youquan.bj.intel.com \
    --to=youquan.song@linux.intel.com \
    --cc=gleb@redhat.com \
    --cc=hpa@linux.intel.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=sheng@linux.intel.com \
    --cc=tglx@linutronix.de \
    --cc=yinghai@kernel.org \
    --cc=youquan.song@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).