From: Borislav Petkov <bp@alien8.de>
To: Joe Perches <joe@perches.com>
Cc: Ingo Molnar <mingo@kernel.org>,
Youquan Song <youquan.song@linux.intel.com>,
Yinghai Lu <yinghai@kernel.org>, Gleb Natapov <gleb@redhat.com>,
Youquan Song <youquan.song@intel.com>,
Sheng Yang <sheng@linux.intel.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] x86, apic: Enable x2APIC physical when cpu < 256 native
Date: Sun, 18 Aug 2013 12:02:47 +0200 [thread overview]
Message-ID: <20130818100247.GB26728@pd.tnic> (raw)
In-Reply-To: <1376756803.2027.7.camel@joe-AO722>
On Sat, Aug 17, 2013 at 09:26:43AM -0700, Joe Perches wrote:
> > ... unless there's a way to detect new submissions and scream only
> > for those. I.e., look at lines starting with "+" which don't have
> > corresponding "-" lines.
>
> No, that's not the right way to do that.
> That bit's relatively easy because checkpatch only looks
> at files when there's a specific command line -f flag.
> So just check the existence of the -f command line flag
> (!$file) and for an added comment that starts "/* foo" without
> a comment termination */ after it on the same line.
Right, your way is simpler.
> > This would need a bit of experimenting and is not trivial though, maybe
> > Algorithm::Diff could even help there.
> >
> > Sounds like a mini-project for a perl dude :-)
>
> I'm not one of those...
>
> This might work though
>
> scripts/checkpatch.pl | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 9ba4fc4..abe820a 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2119,6 +2119,15 @@ sub process {
> }
> }
>
> + if (!$file &&
> + $realfile !~ m@^(drivers/net/|net/)@ &&
> + $rawline =~ /^\+/ && #Added line
> + $rawline !~ m@/\*.*\*/@ && #whole comments
> + $rawline =~ m@/\*+.+@) { #unterminated comment
> + WARN("COMMENT_STYLE",
> + "block comments use an empty /* line\n" . $herecurr);
> + }
> +
> if ($realfile =~ m@^(drivers/net/|net/)@ &&
> $prevrawline =~ /^\+[ \t]*\/\*[ \t]*$/ &&
> $rawline =~ /^\+[ \t]*\*/) {
Almost. It needs to look only on *.[ch] files because otherwise it fires on that
very same diff to checkpatch.pl too:
$ git diff | ./scripts/checkpatch.pl -
...
WARNING: block comments use an empty /* line
#15: FILE: scripts/checkpatch.pl:2059:
+ "block comments use an empty /* line\n" . $herecurr);
Also, we need to catch this obvious case:
/*
* This is a wrong comment. */
IOW, something like a modified version of yours below. It doesn't catch
every wrong comment form out there but it should be a start.
--
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 2ee9eb750560..111b6615d74d 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2050,6 +2050,16 @@ sub process {
}
}
+ if (!$file &&
+ $realfile !~ m@^(drivers/net/|net/)@ &&
+ $rawline =~ /^\+/ && # Added line
+ $rawline !~ m@/\*.*\*/@ && # whole comments
+ ($rawline =~ m@/\*+.+@ || # unterminated opening
+ $rawline =~ m@\s*\*+.+\*+/@)) { # unterminated closing
+ WARN("COMMENT_STYLE",
+ "Multi-line comments use an empty /* opening and */ closing line\n" . $herecurr);
+ }
+
if ($realfile =~ m@^(drivers/net/|net/)@ &&
$prevrawline =~ /^\+[ \t]*\/\*[ \t]*$/ &&
$rawline =~ /^\+[ \t]*\*/) {
--
Thanks.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2013-08-18 10:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-12 1:22 [PATCH] x86, apic: Enable x2APIC physical when cpu < 256 native Youquan Song
2013-07-23 9:17 ` Ingo Molnar
2013-07-24 14:04 ` Youquan Song
2013-07-25 22:01 ` Ingo Molnar
2013-07-29 16:48 ` Youquan Song
2013-07-24 3:55 ` [tip:x86/apic] x86/apic: Enable x2APIC physical mode on native hardware too, when there are fewer than 256 CPUs tip-bot for Youquan Song
2013-07-24 4:24 ` [PATCH] x86, apic: Enable x2APIC physical when cpu < 256 native Yinghai Lu
2013-07-24 6:22 ` Gleb Natapov
2013-07-25 14:05 ` Yinghai Lu
2013-07-29 17:05 ` Youquan Song
2013-08-14 18:40 ` Youquan Song
2013-08-14 11:11 ` Ingo Molnar
2013-08-17 13:44 ` Youquan Song
2013-08-17 7:42 ` Ingo Molnar
2013-08-17 8:24 ` Borislav Petkov
2013-08-17 9:03 ` Joe Perches
2013-08-17 15:44 ` Borislav Petkov
2013-08-17 16:26 ` Joe Perches
2013-08-18 10:02 ` Borislav Petkov [this message]
2013-08-17 19:52 ` Youquan Song
2013-08-19 7:11 ` Ingo Molnar
2013-08-02 19:12 ` Konrad Rzeszutek Wilk
2013-07-24 14:45 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130818100247.GB26728@pd.tnic \
--to=bp@alien8.de \
--cc=gleb@redhat.com \
--cc=hpa@linux.intel.com \
--cc=joe@perches.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=sheng@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
--cc=youquan.song@intel.com \
--cc=youquan.song@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).