* [PATCH] host1x: hdmi: Make sure clock is enabled before dumping registers
@ 2013-07-30 8:35 Mikko Perttunen
2013-08-27 8:04 ` Thierry Reding
0 siblings, 1 reply; 2+ messages in thread
From: Mikko Perttunen @ 2013-07-30 8:35 UTC (permalink / raw)
To: thierry.reding
Cc: tbergstrom, dri-devel, linux-tegra, linux-kernel, Mikko Perttunen
The debugfs register dumping function did not enable the HDMI clock.
This led to a possible system hang when reading the debugfs entry
while no HDMI cable was connected to the system. This patch makes
sure that the clock is enabled during the read.
Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
---
drivers/gpu/host1x/drm/hdmi.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/host1x/drm/hdmi.c b/drivers/gpu/host1x/drm/hdmi.c
index 01097da..bf7f027 100644
--- a/drivers/gpu/host1x/drm/hdmi.c
+++ b/drivers/gpu/host1x/drm/hdmi.c
@@ -904,6 +904,11 @@ static int tegra_hdmi_show_regs(struct seq_file *s, void *data)
{
struct drm_info_node *node = s->private;
struct tegra_hdmi *hdmi = node->info_ent->data;
+ int err;
+
+ err = clk_enable(hdmi->clk);
+ if (err)
+ return err;
#define DUMP_REG(name) \
seq_printf(s, "%-56s %#05x %08lx\n", #name, name, \
@@ -1069,6 +1074,8 @@ static int tegra_hdmi_show_regs(struct seq_file *s, void *data)
#undef DUMP_REG
+ clk_disable(hdmi->clk);
+
return 0;
}
--
1.8.1.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] host1x: hdmi: Make sure clock is enabled before dumping registers
2013-07-30 8:35 [PATCH] host1x: hdmi: Make sure clock is enabled before dumping registers Mikko Perttunen
@ 2013-08-27 8:04 ` Thierry Reding
0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2013-08-27 8:04 UTC (permalink / raw)
To: Mikko Perttunen; +Cc: tbergstrom, dri-devel, linux-tegra, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 509 bytes --]
On Tue, Jul 30, 2013 at 11:35:03AM +0300, Mikko Perttunen wrote:
> The debugfs register dumping function did not enable the HDMI clock.
> This led to a possible system hang when reading the debugfs entry
> while no HDMI cable was connected to the system. This patch makes
> sure that the clock is enabled during the read.
>
> Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
> ---
> drivers/gpu/host1x/drm/hdmi.c | 7 +++++++
> 1 file changed, 7 insertions(+)
Applied, thanks.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-27 8:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-30 8:35 [PATCH] host1x: hdmi: Make sure clock is enabled before dumping registers Mikko Perttunen
2013-08-27 8:04 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).