* Re: [PATCH 1/1] md: Do only necessary operations when adding device to RO array
[not found] <84A53BEA6EAC69439B7E311E9B17A76F07918BF9@IRSMSX105.ger.corp.intel.com>
@ 2014-06-02 2:34 ` NeilBrown
2014-06-03 8:29 ` Baldysiak, Pawel
0 siblings, 1 reply; 3+ messages in thread
From: NeilBrown @ 2014-06-02 2:34 UTC (permalink / raw)
To: Baldysiak, Pawel; +Cc: linux-raid, linux-kernel, Paszkiewicz, Artur
[-- Attachment #1: Type: text/plain, Size: 2471 bytes --]
On Fri, 30 May 2014 13:17:14 +0000 "Baldysiak, Pawel"
<pawel.baldysiak@intel.com> wrote:
> Commit 8313b8e57f55b15e5b7f7fc5d1630bbf686a9a97 changed
> way of adding device to read-only array. Used routine
> md_reap_sync_thread() which also trigger finish_reshape(),
> can break reshape process, if it was restarted.
Exactly how can it break?
This is probably fixed by a couple of patches in my for-next branch which I
will be sending to Linus shortly.
NeilBrown
> This part of function should do only necessary operations, that is:
> 1) call ->spare_active
> 2) clear saved_raid_disk if array is no longer degraded
>
> Signed-off-by: Pawel Baldysiak <pawel.baldysiak@intel.com>
> Reviewed-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
>
> ---
> drivers/md/md.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 237b7e0..cf073de2 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -7820,11 +7820,13 @@ void md_check_recovery(struct mddev *mddev)
> * As we only add devices that are already in-sync,
> * we can activate the spares immediately.
> */
> + struct md_rdev *rdev;
> remove_and_add_spares(mddev, NULL);
> - /* There is no thread, but we need to call
> - * ->spare_active and clear saved_raid_disk
> - */
> - md_reap_sync_thread(mddev);
> + mddev->pers->spare_active(mddev);
> + rdev_for_each(rdev, mddev)
> + if (!mddev->degraded ||
> + test_bit(In_sync, &rdev->flags))
> + rdev->saved_raid_disk = -1;
> clear_bit(MD_RECOVERY_NEEDED, &mddev->recovery);
> goto unlock;
> }
> --
> 1.9.0
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH 1/1] md: Do only necessary operations when adding device to RO array
2014-06-02 2:34 ` [PATCH 1/1] md: Do only necessary operations when adding device to RO array NeilBrown
@ 2014-06-03 8:29 ` Baldysiak, Pawel
0 siblings, 0 replies; 3+ messages in thread
From: Baldysiak, Pawel @ 2014-06-03 8:29 UTC (permalink / raw)
To: NeilBrown; +Cc: linux-raid, linux-kernel, Paszkiewicz, Artur
> On Monday, June 02, 2014 4:34 AM NeilBrown Wrote:
> To: Baldysiak, Pawel
> Cc: linux-raid@vger.kernel.org; linux-kernel@vger.kernel.org; Paszkiewicz,
> Artur
> Subject: Re: [PATCH 1/1] md: Do only necessary operations when adding
> device to RO array
>
> On Fri, 30 May 2014 13:17:14 +0000 "Baldysiak, Pawel"
> <pawel.baldysiak@intel.com> wrote:
>
> > Commit 8313b8e57f55b15e5b7f7fc5d1630bbf686a9a97 changed way of
> adding
> > device to read-only array. Used routine
> > md_reap_sync_thread() which also trigger finish_reshape(), can break
> > reshape process, if it was restarted.
>
> Exactly how can it break?
>
> This is probably fixed by a couple of patches in my for-next branch which I will
> be sending to Linus shortly.
>
> NeilBrown
>
Hi Neil,
I have checked your patches from "for-next", and this issue is fixed.
Reshape process is continued correctly after restart.
Thanks!
Pawel Baldysiak
> > This part of function should do only necessary operations, that is:
> > 1) call ->spare_active
> > 2) clear saved_raid_disk if array is no longer degraded
> >
> > Signed-off-by: Pawel Baldysiak <pawel.baldysiak@intel.com>
> > Reviewed-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
> >
> > ---
> > drivers/md/md.c | 10 ++++++----
> > 1 file changed, 6 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/md/md.c b/drivers/md/md.c index 237b7e0..cf073de2
> > 100644
> > --- a/drivers/md/md.c
> > +++ b/drivers/md/md.c
> > @@ -7820,11 +7820,13 @@ void md_check_recovery(struct mddev
> *mddev)
> > * As we only add devices that are already in-sync,
> > * we can activate the spares immediately.
> > */
> > + struct md_rdev *rdev;
> > remove_and_add_spares(mddev, NULL);
> > - /* There is no thread, but we need to call
> > - * ->spare_active and clear saved_raid_disk
> > - */
> > - md_reap_sync_thread(mddev);
> > + mddev->pers->spare_active(mddev);
> > + rdev_for_each(rdev, mddev)
> > + if (!mddev->degraded ||
> > + test_bit(In_sync, &rdev->flags))
> > +
> > + rdev->saved_raid_disk = -1;
> > clear_bit(MD_RECOVERY_NEEDED, &mddev-
> >recovery);
> > goto unlock;
> > }
> > --
> > 1.9.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/1] md: Do only necessary operations when adding device to RO array
@ 2014-05-30 14:39 Baldysiak, Pawel
0 siblings, 0 replies; 3+ messages in thread
From: Baldysiak, Pawel @ 2014-05-30 14:39 UTC (permalink / raw)
To: neilb; +Cc: linux-kernel, linux-raid, Paszkiewicz, Artur
Commit 8313b8e57f55b15e5b7f7fc5d1630bbf686a9a97 changed
way of adding device to read-only array. Used routine
md_reap_sync_thread() which also trigger finish_reshape(),
can break reshape process, if it was restarted.
This part of function should do only necessary operations, that is:
1) call ->spare_active
2) clear saved_raid_disk if array is no longer degraded
Signed-off-by: Pawel Baldysiak <pawel.baldysiak@intel.com>
Reviewed-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
---
drivers/md/md.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 237b7e0..cf073de2 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -7820,11 +7820,13 @@ void md_check_recovery(struct mddev *mddev)
* As we only add devices that are already in-sync,
* we can activate the spares immediately.
*/
+ struct md_rdev *rdev;
remove_and_add_spares(mddev, NULL);
- /* There is no thread, but we need to call
- * ->spare_active and clear saved_raid_disk
- */
- md_reap_sync_thread(mddev);
+ mddev->pers->spare_active(mddev);
+ rdev_for_each(rdev, mddev)
+ if (!mddev->degraded ||
+ test_bit(In_sync, &rdev->flags))
+ rdev->saved_raid_disk = -1;
clear_bit(MD_RECOVERY_NEEDED, &mddev->recovery);
goto unlock;
}
--
1.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-03 8:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <84A53BEA6EAC69439B7E311E9B17A76F07918BF9@IRSMSX105.ger.corp.intel.com>
2014-06-02 2:34 ` [PATCH 1/1] md: Do only necessary operations when adding device to RO array NeilBrown
2014-06-03 8:29 ` Baldysiak, Pawel
2014-05-30 14:39 Baldysiak, Pawel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).