linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] pinctrl: tegra114: Make of_device_id array const
@ 2014-08-11 11:17 Kiran Padwal
  2014-08-11 13:43 ` Thierry Reding
  2014-08-28 13:21 ` Linus Walleij
  0 siblings, 2 replies; 3+ messages in thread
From: Kiran Padwal @ 2014-08-11 11:17 UTC (permalink / raw)
  To: swarren, linus.walleij
  Cc: thierry.reding, kiran.padwal21, linux-tegra, linux-kernel

Make of_device_id array const, because all OF functions handle it as const.

Signed-off-by: Kiran Padwal <kiran.padwal21@gmail.com>
---
 drivers/pinctrl/pinctrl-tegra114.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-tegra114.c b/drivers/pinctrl/pinctrl-tegra114.c
index 33614ba..a3db85b 100644
--- a/drivers/pinctrl/pinctrl-tegra114.c
+++ b/drivers/pinctrl/pinctrl-tegra114.c
@@ -1850,7 +1850,7 @@ static int tegra114_pinctrl_probe(struct platform_device *pdev)
 	return tegra_pinctrl_probe(pdev, &tegra114_pinctrl);
 }
 
-static struct of_device_id tegra114_pinctrl_of_match[] = {
+static const struct of_device_id tegra114_pinctrl_of_match[] = {
 	{ .compatible = "nvidia,tegra114-pinmux", },
 	{ },
 };
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] pinctrl: tegra114: Make of_device_id array const
  2014-08-11 11:17 [PATCH] pinctrl: tegra114: Make of_device_id array const Kiran Padwal
@ 2014-08-11 13:43 ` Thierry Reding
  2014-08-28 13:21 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2014-08-11 13:43 UTC (permalink / raw)
  To: Kiran Padwal; +Cc: swarren, linus.walleij, linux-tegra, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 952 bytes --]

On Mon, Aug 11, 2014 at 04:47:50PM +0530, Kiran Padwal wrote:
> Make of_device_id array const, because all OF functions handle it as const.
> 
> Signed-off-by: Kiran Padwal <kiran.padwal21@gmail.com>
> ---
>  drivers/pinctrl/pinctrl-tegra114.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-tegra114.c b/drivers/pinctrl/pinctrl-tegra114.c
> index 33614ba..a3db85b 100644
> --- a/drivers/pinctrl/pinctrl-tegra114.c
> +++ b/drivers/pinctrl/pinctrl-tegra114.c
> @@ -1850,7 +1850,7 @@ static int tegra114_pinctrl_probe(struct platform_device *pdev)
>  	return tegra_pinctrl_probe(pdev, &tegra114_pinctrl);
>  }
>  
> -static struct of_device_id tegra114_pinctrl_of_match[] = {
> +static const struct of_device_id tegra114_pinctrl_of_match[] = {
>  	{ .compatible = "nvidia,tegra114-pinmux", },
>  	{ },
>  };

Good catch, thanks.

Acked-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] pinctrl: tegra114: Make of_device_id array const
  2014-08-11 11:17 [PATCH] pinctrl: tegra114: Make of_device_id array const Kiran Padwal
  2014-08-11 13:43 ` Thierry Reding
@ 2014-08-28 13:21 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2014-08-28 13:21 UTC (permalink / raw)
  To: Kiran Padwal; +Cc: Stephen Warren, Thierry Reding, linux-tegra, linux-kernel

On Mon, Aug 11, 2014 at 1:17 PM, Kiran Padwal <kiran.padwal21@gmail.com> wrote:

> Make of_device_id array const, because all OF functions handle it as const.
>
> Signed-off-by: Kiran Padwal <kiran.padwal21@gmail.com>

Patch applied with Theirry's ACK.

I will squash all of these patches into *one* since it is one single
functional change.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-08-28 13:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-11 11:17 [PATCH] pinctrl: tegra114: Make of_device_id array const Kiran Padwal
2014-08-11 13:43 ` Thierry Reding
2014-08-28 13:21 ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).