linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] cgroup: Use kvfree in pidlist_free()
@ 2015-03-02 22:51 Bandan Das
  2015-03-03  3:36 ` Zefan Li
  2015-03-03 13:47 ` Tejun Heo
  0 siblings, 2 replies; 3+ messages in thread
From: Bandan Das @ 2015-03-02 22:51 UTC (permalink / raw)
  To: Tejun Heo, Li Zefan; +Cc: cgroups, linux-kernel


The wrapper already calls the appropriate free
function, use it instead of spinning our own.

Signed-off-by: Bandan Das <bsd@redhat.com>
---
 kernel/cgroup.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 29a7b2c..c19d66d 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -3806,10 +3806,7 @@ static void *pidlist_allocate(int count)
 
 static void pidlist_free(void *p)
 {
-	if (is_vmalloc_addr(p))
-		vfree(p);
-	else
-		kfree(p);
+	kvfree(p);
 }
 
 /*
-- 
2.1.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] cgroup: Use kvfree in pidlist_free()
  2015-03-02 22:51 [PATCH] cgroup: Use kvfree in pidlist_free() Bandan Das
@ 2015-03-03  3:36 ` Zefan Li
  2015-03-03 13:47 ` Tejun Heo
  1 sibling, 0 replies; 3+ messages in thread
From: Zefan Li @ 2015-03-03  3:36 UTC (permalink / raw)
  To: Bandan Das; +Cc: Tejun Heo, cgroups, linux-kernel

On 2015/3/3 6:51, Bandan Das wrote:
> 
> The wrapper already calls the appropriate free
> function, use it instead of spinning our own.
> 
> Signed-off-by: Bandan Das <bsd@redhat.com>

Acked-by: Zefan Li <lizefan@huawei.com>

> ---
>  kernel/cgroup.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/kernel/cgroup.c b/kernel/cgroup.c
> index 29a7b2c..c19d66d 100644
> --- a/kernel/cgroup.c
> +++ b/kernel/cgroup.c
> @@ -3806,10 +3806,7 @@ static void *pidlist_allocate(int count)
>  
>  static void pidlist_free(void *p)
>  {
> -	if (is_vmalloc_addr(p))
> -		vfree(p);
> -	else
> -		kfree(p);
> +	kvfree(p);
>  }
>  
>  /*
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] cgroup: Use kvfree in pidlist_free()
  2015-03-02 22:51 [PATCH] cgroup: Use kvfree in pidlist_free() Bandan Das
  2015-03-03  3:36 ` Zefan Li
@ 2015-03-03 13:47 ` Tejun Heo
  1 sibling, 0 replies; 3+ messages in thread
From: Tejun Heo @ 2015-03-03 13:47 UTC (permalink / raw)
  To: Bandan Das; +Cc: Li Zefan, cgroups, linux-kernel

On Mon, Mar 02, 2015 at 05:51:10PM -0500, Bandan Das wrote:
> 
> The wrapper already calls the appropriate free
> function, use it instead of spinning our own.
> 
> Signed-off-by: Bandan Das <bsd@redhat.com>

Applied to cgroup/for-4.1.

Thanks.

-- 
tejun

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-03-03 13:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-02 22:51 [PATCH] cgroup: Use kvfree in pidlist_free() Bandan Das
2015-03-03  3:36 ` Zefan Li
2015-03-03 13:47 ` Tejun Heo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).