* [PATCH] rtc: ep93xx: Use readl/writel for io
@ 2012-03-21 17:55 H Hartley Sweeten
2015-05-19 20:39 ` Alexandre Belloni
0 siblings, 1 reply; 3+ messages in thread
From: H Hartley Sweeten @ 2012-03-21 17:55 UTC (permalink / raw)
To: Linux Kernel; +Cc: rtc-linux, a.zummo
Drivers should not be using the __raw_* io accessors.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
---
diff --git a/drivers/rtc/rtc-ep93xx.c b/drivers/rtc/rtc-ep93xx.c
index 14a42a1..60ea585 100644
--- a/drivers/rtc/rtc-ep93xx.c
+++ b/drivers/rtc/rtc-ep93xx.c
@@ -45,7 +45,7 @@ static int ep93xx_rtc_get_swcomp(struct device *dev, unsigned short *preload,
struct ep93xx_rtc *ep93xx_rtc = dev->platform_data;
unsigned long comp;
- comp = __raw_readl(ep93xx_rtc->mmio_base + EP93XX_RTC_SWCOMP);
+ comp = readl(ep93xx_rtc->mmio_base + EP93XX_RTC_SWCOMP);
if (preload)
*preload = (comp & EP93XX_RTC_SWCOMP_INT_MASK)
@@ -63,7 +63,7 @@ static int ep93xx_rtc_read_time(struct device *dev, struct rtc_time *tm)
struct ep93xx_rtc *ep93xx_rtc = dev->platform_data;
unsigned long time;
- time = __raw_readl(ep93xx_rtc->mmio_base + EP93XX_RTC_DATA);
+ time = readl(ep93xx_rtc->mmio_base + EP93XX_RTC_DATA);
rtc_time_to_tm(time, tm);
return 0;
@@ -73,7 +73,7 @@ static int ep93xx_rtc_set_mmss(struct device *dev, unsigned long secs)
{
struct ep93xx_rtc *ep93xx_rtc = dev->platform_data;
- __raw_writel(secs + 1, ep93xx_rtc->mmio_base + EP93XX_RTC_LOAD);
+ writel(secs + 1, ep93xx_rtc->mmio_base + EP93XX_RTC_LOAD);
return 0;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: rtc: ep93xx: Use readl/writel for io
2012-03-21 17:55 [PATCH] rtc: ep93xx: Use readl/writel for io H Hartley Sweeten
@ 2015-05-19 20:39 ` Alexandre Belloni
2015-05-20 0:13 ` Hartley Sweeten
0 siblings, 1 reply; 3+ messages in thread
From: Alexandre Belloni @ 2015-05-19 20:39 UTC (permalink / raw)
To: hartleys; +Cc: Linux Kernel, rtc-linux, a.zummo
On 21/03/2012 at 10:55:31 -0700, hartleys wrote :
> Drivers should not be using the __raw_* io accessors.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Alessandro Zummo <a.zummo@towertech.it>
>
Rebased and applied, thanks!
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: rtc: ep93xx: Use readl/writel for io
2015-05-19 20:39 ` Alexandre Belloni
@ 2015-05-20 0:13 ` Hartley Sweeten
0 siblings, 0 replies; 3+ messages in thread
From: Hartley Sweeten @ 2015-05-20 0:13 UTC (permalink / raw)
To: Alexandre Belloni; +Cc: Linux Kernel, rtc-linux, a.zummo
On Tuesday, May 19, 2015 1:40 PM, Alexandre Belloni wrote:
> On 21/03/2012 at 10:55:31 -0700, hartleys wrote :
>> Drivers should not be using the __raw_* io accessors.
>>
>> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
>> Cc: Alessandro Zummo <a.zummo@towertech.it>
>
>
> Rebased and applied, thanks!
Man. I forgot all about that patch... ;-)
Thanks,
Hartley
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-20 0:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-21 17:55 [PATCH] rtc: ep93xx: Use readl/writel for io H Hartley Sweeten
2015-05-19 20:39 ` Alexandre Belloni
2015-05-20 0:13 ` Hartley Sweeten
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).