* [PATCH] uio: pruss: Drop depends on ARCH_DAVINCI_DA850 from config
@ 2015-04-14 16:44 Matwey V. Kornilov
2015-04-15 5:28 ` TK, Pratheesh Gangadhar
2015-05-24 18:54 ` Greg KH
0 siblings, 2 replies; 7+ messages in thread
From: Matwey V. Kornilov @ 2015-04-14 16:44 UTC (permalink / raw)
To: pratheesh; +Cc: hjk, gregkh, linux-kernel, Matwey V. Kornilov
mach-dependent stuff has been removed by
2eb2478d471e45e1d0c8bb3defbf82bf7204e13d
So, there is no need to keep
depends on ARCH_DAVINCI_DA850
Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru>
---
drivers/uio/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/uio/Kconfig b/drivers/uio/Kconfig
index 8a15c32..9c9178a 100644
--- a/drivers/uio/Kconfig
+++ b/drivers/uio/Kconfig
@@ -126,7 +126,6 @@ config UIO_FSL_ELBC_GPCM_NETX5152
config UIO_PRUSS
tristate "Texas Instruments PRUSS driver"
- depends on ARCH_DAVINCI_DA850
select GENERIC_ALLOCATOR
help
PRUSS driver for OMAPL138/DA850/AM18XX devices
--
2.1.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* RE: [PATCH] uio: pruss: Drop depends on ARCH_DAVINCI_DA850 from config
2015-04-14 16:44 [PATCH] uio: pruss: Drop depends on ARCH_DAVINCI_DA850 from config Matwey V. Kornilov
@ 2015-04-15 5:28 ` TK, Pratheesh Gangadhar
2015-05-24 18:54 ` Greg KH
1 sibling, 0 replies; 7+ messages in thread
From: TK, Pratheesh Gangadhar @ 2015-04-15 5:28 UTC (permalink / raw)
To: Matwey V. Kornilov; +Cc: hjk, gregkh, linux-kernel
> From: Matwey V. Kornilov [mailto:matwey.kornilov@gmail.com]
> mach-dependent stuff has been removed by
> 2eb2478d471e45e1d0c8bb3defbf82bf7204e13d
> So, there is no need to keep
> depends on ARCH_DAVINCI_DA850
>
> Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru>
> ---
> drivers/uio/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/uio/Kconfig b/drivers/uio/Kconfig index 8a15c32..9c9178a
> 100644
> --- a/drivers/uio/Kconfig
> +++ b/drivers/uio/Kconfig
> @@ -126,7 +126,6 @@ config UIO_FSL_ELBC_GPCM_NETX5152
>
> config UIO_PRUSS
> tristate "Texas Instruments PRUSS driver"
> - depends on ARCH_DAVINCI_DA850
> select GENERIC_ALLOCATOR
> help
> PRUSS driver for OMAPL138/DA850/AM18XX devices
Acked-by: Pratheesh Gangadhar <pratheesh@ti.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] uio: pruss: Drop depends on ARCH_DAVINCI_DA850 from config
2015-04-14 16:44 [PATCH] uio: pruss: Drop depends on ARCH_DAVINCI_DA850 from config Matwey V. Kornilov
2015-04-15 5:28 ` TK, Pratheesh Gangadhar
@ 2015-05-24 18:54 ` Greg KH
2015-06-06 15:49 ` [PATCHv2 1/2] uio: pruss: Include <linux/sizes.h> Matwey V. Kornilov
1 sibling, 1 reply; 7+ messages in thread
From: Greg KH @ 2015-05-24 18:54 UTC (permalink / raw)
To: Matwey V. Kornilov; +Cc: pratheesh, hjk, linux-kernel
On Tue, Apr 14, 2015 at 07:44:10PM +0300, Matwey V. Kornilov wrote:
> mach-dependent stuff has been removed by
> 2eb2478d471e45e1d0c8bb3defbf82bf7204e13d
> So, there is no need to keep
> depends on ARCH_DAVINCI_DA850
>
> Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru>
> Acked-by: Pratheesh Gangadhar <pratheesh@ti.com>
> ---
> drivers/uio/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
This patch breaks the build on x86-64, please be more careful when
sending untested patches.
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCHv2 1/2] uio: pruss: Include <linux/sizes.h>
2015-05-24 18:54 ` Greg KH
@ 2015-06-06 15:49 ` Matwey V. Kornilov
2015-06-06 15:49 ` [PATCHv2 2/2] uio: pruss: Drop depends on ARCH_DAVINCI_DA850 from config Matwey V. Kornilov
0 siblings, 1 reply; 7+ messages in thread
From: Matwey V. Kornilov @ 2015-06-06 15:49 UTC (permalink / raw)
To: gregkh; +Cc: pratheesh, hjk, linux-kernel, Matwey V. Kornilov
uio_pruss references SZ_16K and SZ_256K defines, but linux/sizes.h is not included.
Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru>
---
Changes from v1:
- Add uio: pruss: Include <linux/sizes.h> patch to allow build on all architectures
drivers/uio/uio_pruss.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/uio/uio_pruss.c b/drivers/uio/uio_pruss.c
index 818735b..ca9e2fa 100644
--- a/drivers/uio/uio_pruss.c
+++ b/drivers/uio/uio_pruss.c
@@ -24,6 +24,7 @@
#include <linux/io.h>
#include <linux/clk.h>
#include <linux/dma-mapping.h>
+#include <linux/sizes.h>
#include <linux/slab.h>
#include <linux/genalloc.h>
--
2.1.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCHv2 2/2] uio: pruss: Drop depends on ARCH_DAVINCI_DA850 from config
2015-06-06 15:49 ` [PATCHv2 1/2] uio: pruss: Include <linux/sizes.h> Matwey V. Kornilov
@ 2015-06-06 15:49 ` Matwey V. Kornilov
2015-06-06 16:11 ` Richard Weinberger
0 siblings, 1 reply; 7+ messages in thread
From: Matwey V. Kornilov @ 2015-06-06 15:49 UTC (permalink / raw)
To: gregkh; +Cc: pratheesh, hjk, linux-kernel, Matwey V. Kornilov
mach-dependant stuff has been removed by
2eb2478d471e45e1d0c8bb3defbf82bf7204e13d
There is no need to keep
depends on ARCH_DAVINCI_DA850
Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru>
---
drivers/uio/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/uio/Kconfig b/drivers/uio/Kconfig
index 8a15c32..9c9178a 100644
--- a/drivers/uio/Kconfig
+++ b/drivers/uio/Kconfig
@@ -126,7 +126,6 @@ config UIO_FSL_ELBC_GPCM_NETX5152
config UIO_PRUSS
tristate "Texas Instruments PRUSS driver"
- depends on ARCH_DAVINCI_DA850
select GENERIC_ALLOCATOR
help
PRUSS driver for OMAPL138/DA850/AM18XX devices
--
2.1.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCHv2 2/2] uio: pruss: Drop depends on ARCH_DAVINCI_DA850 from config
2015-06-06 15:49 ` [PATCHv2 2/2] uio: pruss: Drop depends on ARCH_DAVINCI_DA850 from config Matwey V. Kornilov
@ 2015-06-06 16:11 ` Richard Weinberger
2015-06-06 16:13 ` Matwey V. Kornilov
0 siblings, 1 reply; 7+ messages in thread
From: Richard Weinberger @ 2015-06-06 16:11 UTC (permalink / raw)
To: Matwey V. Kornilov; +Cc: Greg KH, pratheesh, Hans J. Koch, LKML
On Sat, Jun 6, 2015 at 5:49 PM, Matwey V. Kornilov <matwey@sai.msu.ru> wrote:
> mach-dependant stuff has been removed by
> 2eb2478d471e45e1d0c8bb3defbf82bf7204e13d
>
> There is no need to keep
> depends on ARCH_DAVINCI_DA850
The driver dependencies are still broken.
It needs ioremap(), hence make it depend on HAS_IOMEM.
Otherwise you break the build for UML and some s390 variants
which do not have io memory.
--
Thanks,
//richard
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCHv2 2/2] uio: pruss: Drop depends on ARCH_DAVINCI_DA850 from config
2015-06-06 16:11 ` Richard Weinberger
@ 2015-06-06 16:13 ` Matwey V. Kornilov
0 siblings, 0 replies; 7+ messages in thread
From: Matwey V. Kornilov @ 2015-06-06 16:13 UTC (permalink / raw)
To: Richard Weinberger; +Cc: Greg KH, pratheesh, Hans J. Koch, LKML
2015-06-06 19:11 GMT+03:00 Richard Weinberger <richard.weinberger@gmail.com>:
> On Sat, Jun 6, 2015 at 5:49 PM, Matwey V. Kornilov <matwey@sai.msu.ru> wrote:
>> mach-dependant stuff has been removed by
>> 2eb2478d471e45e1d0c8bb3defbf82bf7204e13d
>>
>> There is no need to keep
>> depends on ARCH_DAVINCI_DA850
>
> The driver dependencies are still broken.
> It needs ioremap(), hence make it depend on HAS_IOMEM.
> Otherwise you break the build for UML and some s390 variants
> which do not have io memory.
Thank you, I will go redo.
>
> --
> Thanks,
> //richard
>
--
With best regards,
Matwey V. Kornilov.
Sternberg Astronomical Institute, Lomonosov Moscow State University, Russia
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-06-06 16:13 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-14 16:44 [PATCH] uio: pruss: Drop depends on ARCH_DAVINCI_DA850 from config Matwey V. Kornilov
2015-04-15 5:28 ` TK, Pratheesh Gangadhar
2015-05-24 18:54 ` Greg KH
2015-06-06 15:49 ` [PATCHv2 1/2] uio: pruss: Include <linux/sizes.h> Matwey V. Kornilov
2015-06-06 15:49 ` [PATCHv2 2/2] uio: pruss: Drop depends on ARCH_DAVINCI_DA850 from config Matwey V. Kornilov
2015-06-06 16:11 ` Richard Weinberger
2015-06-06 16:13 ` Matwey V. Kornilov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).