linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [asoc:topic/zx 2/4] sound/soc/zte/zx296702-i2s.c:358:27: sparse: symbol 'zx_i2s_dai' was not declared. Should it be static?
@ 2015-06-04 13:00 kbuild test robot
  2015-06-04 13:00 ` [PATCH asoc] ASoC: zx: zx_i2s_dai can be static kbuild test robot
  0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2015-06-04 13:00 UTC (permalink / raw)
  To: Jun Nie
  Cc: kbuild-all, Mark Brown, alsa-devel, Liam Girdwood,
	Jaroslav Kysela, Takashi Iwai, linux-kernel

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/zx
head:   dc772a4cf76113d7269e4fb1c45e5d85c0cf458e
commit: e5d4cd87800ce12c356e7eb571e565e839ab3a90 [2/4] ASoC: zx: Add ZTE zx296702 I2S DAI driver
reproduce:
  # apt-get install sparse
  git checkout e5d4cd87800ce12c356e7eb571e565e839ab3a90
  make ARCH=x86_64 allmodconfig
  make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> sound/soc/zte/zx296702-i2s.c:358:27: sparse: symbol 'zx_i2s_dai' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH asoc] ASoC: zx: zx_i2s_dai can be static
  2015-06-04 13:00 [asoc:topic/zx 2/4] sound/soc/zte/zx296702-i2s.c:358:27: sparse: symbol 'zx_i2s_dai' was not declared. Should it be static? kbuild test robot
@ 2015-06-04 13:00 ` kbuild test robot
  2015-06-04 14:39   ` Mark Brown
  0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2015-06-04 13:00 UTC (permalink / raw)
  To: Jun Nie
  Cc: kbuild-all, Mark Brown, alsa-devel, Liam Girdwood,
	Jaroslav Kysela, Takashi Iwai, linux-kernel


Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 zx296702-i2s.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/zte/zx296702-i2s.c b/sound/soc/zte/zx296702-i2s.c
index cf6005c..472fde3 100644
--- a/sound/soc/zte/zx296702-i2s.c
+++ b/sound/soc/zte/zx296702-i2s.c
@@ -355,7 +355,7 @@ static const struct snd_soc_component_driver zx_i2s_component = {
 	.name			= "zx-i2s",
 };
 
-struct snd_soc_dai_driver zx_i2s_dai = {
+static struct snd_soc_dai_driver zx_i2s_dai = {
 	.name	= "zx-i2s-dai",
 	.id	= 0,
 	.probe	= zx_i2s_dai_probe,

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH asoc] ASoC: zx: zx_i2s_dai can be static
  2015-06-04 13:00 ` [PATCH asoc] ASoC: zx: zx_i2s_dai can be static kbuild test robot
@ 2015-06-04 14:39   ` Mark Brown
  0 siblings, 0 replies; 3+ messages in thread
From: Mark Brown @ 2015-06-04 14:39 UTC (permalink / raw)
  To: kbuild test robot
  Cc: Jun Nie, kbuild-all, alsa-devel, Liam Girdwood, Jaroslav Kysela,
	Takashi Iwai, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 148 bytes --]

On Thu, Jun 04, 2015 at 09:00:50PM +0800, kbuild test robot wrote:
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-06-04 14:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-04 13:00 [asoc:topic/zx 2/4] sound/soc/zte/zx296702-i2s.c:358:27: sparse: symbol 'zx_i2s_dai' was not declared. Should it be static? kbuild test robot
2015-06-04 13:00 ` [PATCH asoc] ASoC: zx: zx_i2s_dai can be static kbuild test robot
2015-06-04 14:39   ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).