* [PATCH] ASoC: fsl-ssi: Fix bitclock calculation for master mode
@ 2015-07-03 10:39 Juergen Borleis
2015-07-03 17:44 ` [alsa-devel] " Nicolin Chen
0 siblings, 1 reply; 2+ messages in thread
From: Juergen Borleis @ 2015-07-03 10:39 UTC (permalink / raw)
To: linux-kernel
Cc: linuxppc-dev, alsa-devel, Takashi Iwai, Jaroslav Kysela,
Mark Brown, Liam Girdwood, Xiubo Li, Nicolin Chen, Timur Tabi,
kernel, linux-arm-kernel
According to the datasheet 'pm', 'psr' and 'div2' should never be all 0.
Since commit 541b03ad6cfe ("ASoC: fsl_ssi: Fix the incorrect limitation of
the bit clock rate") this can happen, because for some bitclock rates
'pm' = 0 seems to be a valid choice but does not work due to hardware
restrictions. This results into a bad hardware behaviour (slow audio for
example). Feature tested on a i.MX25.
Signed-off-by: Juergen Borleis <jbe@pengutronix.de>
---
sound/soc/fsl/fsl_ssi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index c7647e0..c0b940e 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -633,7 +633,7 @@ static int fsl_ssi_set_bclk(struct snd_pcm_substream *substream,
sub *= 100000;
do_div(sub, freq);
- if (sub < savesub) {
+ if (sub < savesub && !(i == 0 && psr == 0 && div2 == 0)) {
baudrate = tmprate;
savesub = sub;
pm = i;
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [alsa-devel] [PATCH] ASoC: fsl-ssi: Fix bitclock calculation for master mode
2015-07-03 10:39 [PATCH] ASoC: fsl-ssi: Fix bitclock calculation for master mode Juergen Borleis
@ 2015-07-03 17:44 ` Nicolin Chen
0 siblings, 0 replies; 2+ messages in thread
From: Nicolin Chen @ 2015-07-03 17:44 UTC (permalink / raw)
To: Juergen Borleis
Cc: linux-kernel, alsa-devel, Timur Tabi, Xiubo Li, Takashi Iwai,
Liam Girdwood, Mark Brown, kernel, linuxppc-dev,
linux-arm-kernel
On Fri, Jul 03, 2015 at 12:39:36PM +0200, Juergen Borleis wrote:
> According to the datasheet 'pm', 'psr' and 'div2' should never be all 0.
> Since commit 541b03ad6cfe ("ASoC: fsl_ssi: Fix the incorrect limitation of
> the bit clock rate") this can happen, because for some bitclock rates
> 'pm' = 0 seems to be a valid choice but does not work due to hardware
> restrictions. This results into a bad hardware behaviour (slow audio for
> example). Feature tested on a i.MX25.
>
> Signed-off-by: Juergen Borleis <jbe@pengutronix.de>
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
Thank you!
> ---
> sound/soc/fsl/fsl_ssi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
> index c7647e0..c0b940e 100644
> --- a/sound/soc/fsl/fsl_ssi.c
> +++ b/sound/soc/fsl/fsl_ssi.c
> @@ -633,7 +633,7 @@ static int fsl_ssi_set_bclk(struct snd_pcm_substream *substream,
> sub *= 100000;
> do_div(sub, freq);
>
> - if (sub < savesub) {
> + if (sub < savesub && !(i == 0 && psr == 0 && div2 == 0)) {
> baudrate = tmprate;
> savesub = sub;
> pm = i;
> --
> 2.1.4
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-03 17:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-03 10:39 [PATCH] ASoC: fsl-ssi: Fix bitclock calculation for master mode Juergen Borleis
2015-07-03 17:44 ` [alsa-devel] " Nicolin Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).