* [RFC][PATCH 1/1] staging:vt6655: Remove checks around dev_kfree_skb
@ 2015-06-24 6:13 Maninder Singh
2015-07-14 22:50 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Maninder Singh @ 2015-06-24 6:13 UTC (permalink / raw)
To: forest, gregkh, tvboxspy, gclement, joe, devel, linux-kernel
Cc: pankaj.m, Maninder Singh
dev_kfree_skb checks for NULL pointer itself.
Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
Reviewed-by: Akhilesh Kumar <akhilesh.k@samsung.com>
---
drivers/staging/vt6655/device_main.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index ca578d6..0c4b0de 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -767,8 +767,7 @@ static void device_free_td0_ring(struct vnt_private *pDevice)
dma_unmap_single(&pDevice->pcid->dev, pTDInfo->skb_dma,
pTDInfo->skb->len, DMA_TO_DEVICE);
- if (pTDInfo->skb)
- dev_kfree_skb(pTDInfo->skb);
+ dev_kfree_skb(pTDInfo->skb);
kfree(pDesc->pTDInfo);
}
@@ -786,8 +785,7 @@ static void device_free_td1_ring(struct vnt_private *pDevice)
dma_unmap_single(&pDevice->pcid->dev, pTDInfo->skb_dma,
pTDInfo->skb->len, DMA_TO_DEVICE);
- if (pTDInfo->skb)
- dev_kfree_skb(pTDInfo->skb);
+ dev_kfree_skb(pTDInfo->skb);
kfree(pDesc->pTDInfo);
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RFC][PATCH 1/1] staging:vt6655: Remove checks around dev_kfree_skb
2015-06-24 6:13 [RFC][PATCH 1/1] staging:vt6655: Remove checks around dev_kfree_skb Maninder Singh
@ 2015-07-14 22:50 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2015-07-14 22:50 UTC (permalink / raw)
To: Maninder Singh
Cc: forest, tvboxspy, gclement, joe, devel, linux-kernel, pankaj.m
On Wed, Jun 24, 2015 at 11:43:16AM +0530, Maninder Singh wrote:
> dev_kfree_skb checks for NULL pointer itself.
>
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> Reviewed-by: Akhilesh Kumar <akhilesh.k@samsung.com>
> ---
> drivers/staging/vt6655/device_main.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Why is this a [RFC] email?
I don't apply RFC patches, because obviously you don't think they are
good enough to go in :)
Please fix up to be something you want to see accepted and then resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-14 22:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-24 6:13 [RFC][PATCH 1/1] staging:vt6655: Remove checks around dev_kfree_skb Maninder Singh
2015-07-14 22:50 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).