* [PATCH] dmaengine: pxa_dma: fix debug information
@ 2015-08-18 6:15 Robert Jarzmik
2015-08-18 16:40 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Robert Jarzmik @ 2015-08-18 6:15 UTC (permalink / raw)
To: Vinod Koul, Robert Jarzmik
Cc: Daniel Mack, Haojian Zhuang, dmaengine, linux-kernel
This fixes the following error:
drivers/dma/pxa_dma.c: In function ‘dbg_show_requester_chan’:
drivers/dma/pxa_dma.c:192:2: error: void value not ignored as it ought to be
pos += seq_printf(s, "DMA channel %d requester :\n", phy->idx);
^
drivers/dma/pxa_dma.c:197:8: error: void value not ignored as it ought to be
!!(drcmr & DRCMR_MAPVLD));
^
scripts/Makefile.build:258: recipe for target 'drivers/dma/pxa_dma.o' failed
Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
---
drivers/dma/pxa_dma.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/dma/pxa_dma.c b/drivers/dma/pxa_dma.c
index ddcbbf5cd9e9..be5b5248b7b6 100644
--- a/drivers/dma/pxa_dma.c
+++ b/drivers/dma/pxa_dma.c
@@ -184,19 +184,18 @@ static unsigned int pxad_drcmr(unsigned int line)
static int dbg_show_requester_chan(struct seq_file *s, void *p)
{
- int pos = 0;
struct pxad_phy *phy = s->private;
int i;
u32 drcmr;
- pos += seq_printf(s, "DMA channel %d requester :\n", phy->idx);
+ seq_printf(s, "DMA channel %d requester :\n", phy->idx);
for (i = 0; i < 70; i++) {
drcmr = readl_relaxed(phy->base + pxad_drcmr(i));
if ((drcmr & DRCMR_CHLNUM) == phy->idx)
- pos += seq_printf(s, "\tRequester %d (MAPVLD=%d)\n", i,
- !!(drcmr & DRCMR_MAPVLD));
+ seq_printf(s, "\tRequester %d (MAPVLD=%d)\n", i,
+ !!(drcmr & DRCMR_MAPVLD));
}
- return pos;
+ return 0;
}
static inline int dbg_burst_from_dcmd(u32 dcmd)
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: pxa_dma: fix debug information
2015-08-18 6:15 [PATCH] dmaengine: pxa_dma: fix debug information Robert Jarzmik
@ 2015-08-18 16:40 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2015-08-18 16:40 UTC (permalink / raw)
To: Robert Jarzmik; +Cc: Daniel Mack, Haojian Zhuang, dmaengine, linux-kernel
On Tue, Aug 18, 2015 at 08:15:32AM +0200, Robert Jarzmik wrote:
> This fixes the following error:
> drivers/dma/pxa_dma.c: In function ‘dbg_show_requester_chan’:
> drivers/dma/pxa_dma.c:192:2: error: void value not ignored as it ought to be
> pos += seq_printf(s, "DMA channel %d requester :\n", phy->idx);
> ^
> drivers/dma/pxa_dma.c:197:8: error: void value not ignored as it ought to be
> !!(drcmr & DRCMR_MAPVLD));
> ^
> scripts/Makefile.build:258: recipe for target 'drivers/dma/pxa_dma.o' failed
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-18 16:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-18 6:15 [PATCH] dmaengine: pxa_dma: fix debug information Robert Jarzmik
2015-08-18 16:40 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).