linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: vincent.weaver@maine.edu, jolsa@redhat.com,
	torvalds@linux-foundation.org, eranian@google.com,
	tglx@linutronix.de, acme@redhat.com, ak@linux.intel.com,
	linux-kernel@vger.kernel.org, hpa@zytor.com,
	linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/core] perf/x86: Use INST_RETIRED.PREC_DIST for cycles: ppp
Date: Tue, 8 Dec 2015 06:36:04 +0100	[thread overview]
Message-ID: <20151208053604.GA15632@gmail.com> (raw)
In-Reply-To: <20151207135107.GA6356@twins.programming.kicks-ass.net>


* Peter Zijlstra <peterz@infradead.org> wrote:

> On Sun, Dec 06, 2015 at 02:11:02PM +0100, Ingo Molnar wrote:
> 
> > the symptom is that latest 'perf top' and 'perf record' produces no samples.
> > 
> > So I've removed this commit and the related Skylake commit from -tip:
> > 
> >  4576ceaa56a8 perf/x86: Use INST_RETIRED.PREC_DIST for cycles:ppp
> >  ac1e1d30cf90 perf/x86: Use INST_RETIRED.TOTAL_CYCLES_PS for cycles:pp for Skylake
> > 
> > you need to do better testing next time around. Note: if you resubmit the patches, 
> > please also pick up the updates commit changelogs from the tip-bot emails, don't 
> > use your original changelogs.
> 
> OK, so I need:
> 
>  lkml.kernel.org/r/1449177740-5422-1-git-send-email-andi@firstfloor.org
>  lkml.kernel.org/r/1449177740-5422-2-git-send-email-andi@firstfloor.org
> 
> On my IVB because that keeps triggering that case with :ppp, other than
> that this seems to work fine on IVB.
> 
> I've also tried on SNB (which does not support the new :ppp thing) and
> that too works.
> 
> Sadly I do not have older hardware anymore :/ 
> 
> 
> Also, perf tools DTRT and will use :ppp by default if available.

So I checked my NHM box with your latest queue and it now works correctly. Do you 
have any idea what the difference is/was?

Thanks,

	Ingo

  reply	other threads:[~2015-12-08  5:36 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-01  0:28 [PATCH 1/2] perf, x86: Use INST_RETIRED.TOTAL_CYCLES_PS for cycles:pp for Skylake Andi Kleen
2015-12-01  0:28 ` [PATCH 2/2] x86, perf: Use INST_RETIRED.PREC_DIST for cycles:ppp Andi Kleen
2015-12-01 13:41   ` Peter Zijlstra
2015-12-01 14:54     ` Andi Kleen
2015-12-01 14:55       ` Peter Zijlstra
2015-12-04 11:50   ` [tip:perf/core] perf/x86: Use INST_RETIRED.PREC_DIST for cycles: ppp tip-bot for Andi Kleen
2015-12-06 13:11     ` Ingo Molnar
2015-12-06 22:06       ` Peter Zijlstra
2015-12-07  6:48         ` Ingo Molnar
2015-12-07 10:26           ` Peter Zijlstra
2015-12-07 14:02           ` Arnaldo Carvalho de Melo
2015-12-07 14:12             ` Peter Zijlstra
2015-12-07 13:51       ` Peter Zijlstra
2015-12-08  5:36         ` Ingo Molnar [this message]
2015-12-08  8:50           ` Peter Zijlstra
2015-12-08  8:57             ` Peter Zijlstra
2015-12-08 13:27               ` Peter Zijlstra
2015-12-09  8:29                 ` Ingo Molnar
2016-01-06 18:51   ` tip-bot for Andi Kleen
2015-12-01 13:19 ` [PATCH 1/2] perf, x86: Use INST_RETIRED.TOTAL_CYCLES_PS for cycles:pp for Skylake Peter Zijlstra
2015-12-04 11:50 ` [tip:perf/core] perf/x86: " tip-bot for Andi Kleen
2016-01-06 18:51 ` tip-bot for Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151208053604.GA15632@gmail.com \
    --to=mingo@kernel.org \
    --cc=acme@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=eranian@google.com \
    --cc=hpa@zytor.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=vincent.weaver@maine.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).