From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>,
Gilles Muller <Gilles.Muller@lip6.fr>,
nicolas.palix@imag.fr, mmarek@suse.com,
linux-kernel@vger.kernel.org, cocci@systeme.lip6.fr
Subject: Re: [PATCH 4/4] scripts/coccinelle: require coccinelle >= 1.0.4 on device_node_continue.cocci
Date: Wed, 15 Jun 2016 17:45:07 +0200 [thread overview]
Message-ID: <20160615154507.GM11948@wotan.suse.de> (raw)
In-Reply-To: <alpine.DEB.2.02.1606150807440.2231@localhost6.localdomain6>
On Wed, Jun 15, 2016 at 08:08:41AM +0200, Julia Lawall wrote:
>
>
> On Tue, 14 Jun 2016, Luis R. Rodriguez wrote:
>
> > Make use of the new kernel python requirements library to be able to
> > specify coccinelle binary version requirements. The cocci file
> > device_node_continue.cocci requires at least coccinelle 1.0.4.
> >
> > Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
> > ---
> > scripts/coccinelle/iterators/device_node_continue.cocci | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
> >
> > diff --git a/scripts/coccinelle/iterators/device_node_continue.cocci b/scripts/coccinelle/iterators/device_node_continue.cocci
> > index 38ab744a4037..b590de9418d1 100644
> > --- a/scripts/coccinelle/iterators/device_node_continue.cocci
> > +++ b/scripts/coccinelle/iterators/device_node_continue.cocci
> > @@ -12,6 +12,19 @@ virtual context
> > virtual org
> > virtual report
> >
> > +// This uses a conjunction, which requires at least coccinelle >= 1.0.4
> > +@script:python@
> > +@@
> > +
> > +import sys
> > +from lib import reqs
> > +
> > +req = reqs.Req()
> > +req.coccinelle('1.0.4')
> > +if not req.reqs_match():
> > + cocci.exit()
> > + sys.exit(1)
>
> This doesn't look very appealing to me. Shouldn't Coccinelle handle this
> itself?
Oh I agree, however what options do we have at the moment instead of an odd
parse error complaint ? This lets one annotate version requirements and is
backward compatible.
Luis
next prev parent reply other threads:[~2016-06-15 15:50 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 22:10 [PATCH 0/4] scripts: add basic python version library and use it Luis R. Rodriguez
2016-06-14 22:10 ` [PATCH 1/4] coccicheck: propagate error and stop processing after first error Luis R. Rodriguez
2016-06-14 22:10 ` [PATCH 2/4] scripts: add reqs python library Luis R. Rodriguez
2016-06-15 6:06 ` Julia Lawall
2016-06-15 16:04 ` Luis R. Rodriguez
2016-06-15 7:50 ` Michal Marek
2016-06-15 16:02 ` Luis R. Rodriguez
2016-06-15 19:11 ` Michal Marek
2016-06-15 20:26 ` Luis R. Rodriguez
2016-06-15 20:31 ` Julia Lawall
2016-06-15 12:01 ` Aw: [Cocci] " SF Markus Elfring
2016-06-15 15:51 ` Luis R. Rodriguez
2016-06-14 22:10 ` [PATCH 3/4] coccicheck: enable use of the kernel's " Luis R. Rodriguez
2016-06-15 7:51 ` Michal Marek
2016-06-15 15:43 ` Luis R. Rodriguez
2016-06-14 22:10 ` [PATCH 4/4] scripts/coccinelle: require coccinelle >= 1.0.4 on device_node_continue.cocci Luis R. Rodriguez
2016-06-15 6:08 ` Julia Lawall
2016-06-15 15:45 ` Luis R. Rodriguez [this message]
2016-06-15 8:43 ` Julia Lawall
2016-06-15 15:49 ` Luis R. Rodriguez
2016-06-15 15:55 ` Julia Lawall
2016-06-15 16:06 ` SF Markus Elfring
2016-06-15 16:08 ` [PATCH 4/4] " Luis R. Rodriguez
2016-06-15 16:11 ` Julia Lawall
2016-06-15 16:46 ` Luis R. Rodriguez
2016-06-15 16:52 ` Julia Lawall
2016-06-15 19:08 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160615154507.GM11948@wotan.suse.de \
--to=mcgrof@kernel.org \
--cc=Gilles.Muller@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=nicolas.palix@imag.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).