From: Christoph Hellwig <hch@lst.de>
To: Alexander Gordeev <agordeev@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
tglx@linutronix.de, axboe@fb.com, linux-block@vger.kernel.org,
linux-pci@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/13] pci: Provide sensible irq vector alloc/free routines
Date: Thu, 30 Jun 2016 18:54:17 +0200 [thread overview]
Message-ID: <20160630165417.GA21787@lst.de> (raw)
In-Reply-To: <20160623111610.GA28861@dhcp-27-118.brq.redhat.com>
On Thu, Jun 23, 2016 at 01:16:10PM +0200, Alexander Gordeev wrote:
> New APIs should be documented in Documentation/PCI/MSI-HOWTO.txt, I guess.
Ok, done.
> > +static unsigned int pci_nr_irq_vectors(struct pci_dev *pdev)
> > +{
> > + int nr_entries;
> > +
> > + nr_entries = pci_msix_vec_count(pdev);
> > + if (nr_entries <= 0 && pci_msi_supported(pdev, 1))
> > + nr_entries = pci_msi_vec_count(pdev);
> > + if (nr_entries <= 0)
> > + nr_entries = 1;
> > + return nr_entries;
> > +}
>
> This function is strange, because it:
> (a) does not consider PCI_IRQ_NOMSIX flag;
> (b) only calls pci_msi_supported() for MSI case;
> (c) calls pci_msi_supported() with just one vector;
> (d) might return suboptimal number of vectors (number of MSI-X used
> later for MSI or vice versa)
>
> Overall, I would suggest simply return maximum between MSI-X and MSI
> numbers and let the rest of the code (i.e the two range functions)
> handle a-d.
Ok, fixed except for (c) - the only thing pci_msi_supported does with
nvec is to check for it being less than 1, which we don't care about,
and which really shouldn't be in this function to start with.
> > + struct msix_entry *msix_entries;
> > + int vecs, i;
> > +
> > + msix_entries = kcalloc(max_vecs, sizeof(struct msix_entry), GFP_KERNEL);
> > + if (!msix_entries)
> > + return -ENOMEM;
> > +
> > + for (i = 0; i < max_vecs; i++)
> > + msix_entries[i].entry = i;
> > +
> > + vecs = pci_enable_msix_range(pdev, msix_entries, min_vecs, max_vecs);
> > + if (vecs > 0) {
>
> This condition check is unneeded.
Why? We could get -ENOSPC back. Oh, because our for loop will
terminate immediately. I can update it, but I think removing it
is less readable than keeping it around.
> > + if (!(flags & PCI_IRQ_NOMSIX)) {
> > + vecs = pci_enable_msix_range_wrapper(dev, irqs, min_vecs,
> > + max_vecs);
> > + if (vecs > 0)
> > + goto done;
> > + }
> > +
> > + vecs = pci_enable_msi_range(dev, min_vecs, max_vecs);
> > + if (vecs > 0) {
> > + for (i = 0; i < vecs; i++)
> > + irqs[i] = dev->irq + i;
> > + goto done;
> > + }
> > +
> > + if (min_vecs > 1)
> > + return -ENOSPC;
>
> irqs is leaked if (min_vecs > 1)
>
> You can get rid of this check at all if you reorganize your code i.e.
> like this:
>
> ...
>
> vecs = pci_enable_msi_range(dev, min_vecs, max_vecs);
> if (vecs < 0)
> goto legacy;
>
> for (i = 0; i < vecs; i++)
> irqs[i] = dev->irq + i;
>
> done:
> ...
>
>
> legacy:
> ...
I've just moved the if below the kfree.
> > +void pci_free_irq_vectors(struct pci_dev *dev)
> > +{
> > + if (dev->msix_enabled)
> > + pci_disable_msix(dev);
> > + else if (dev->msi_enabled)
> > + pci_disable_msi(dev);
>
> The checks are probably redundant or incomplete. Redundant - because
> pci_disable_msi()/pci_disable_msix() do it anyways:
>
> if (!pci_msi_enable || !dev || !dev->msi_enabled)
> return;
>
> Incomplete - because the two other conditions are not checked.
Ok, I've dropped the check.
>
> > + if (dev->irqs != &dev->irq)
> > + kfree(dev->irqs);
>
> Unset dev->irqs?
Fine with me, added.
> > +#define PCI_IRQ_NOMSIX (1 << 0) /* don't try to use MSI-X interrupts */
>
> BTW, why PCI_IRQ_NOMSIX only and no PCI_IRQ_NOMSI?
Because there is no need to call this API if your device only supports
a single legacy vector anyway.
> > + if (min_vecs > 1)
> > + return -ENOSPC;
> > + dev->irqs = &dev->irq;
> > + return 1;
> > +}
> > +static inline void pci_free_irq_vectors(struct pci_dev *dev)
> > +{
>
> Unset dev->irqs?
Ok.
next prev parent reply other threads:[~2016-06-30 16:54 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 19:58 automatic interrupt affinity for MSI/MSI-X capable devices V2 Christoph Hellwig
2016-06-14 19:58 ` [PATCH 01/13] irq/msi: Remove unused MSI_FLAG_IDENTITY_MAP Christoph Hellwig
2016-06-16 9:05 ` Bart Van Assche
2016-06-14 19:58 ` [PATCH 02/13] irq: Introduce IRQD_AFFINITY_MANAGED flag Christoph Hellwig
2016-06-15 8:44 ` Bart Van Assche
2016-06-15 10:23 ` Christoph Hellwig
2016-06-15 10:42 ` Bart Van Assche
2016-06-15 15:14 ` Keith Busch
2016-06-15 15:28 ` Bart Van Assche
2016-06-15 16:03 ` Keith Busch
2016-06-15 19:36 ` Bart Van Assche
2016-06-15 20:06 ` Keith Busch
2016-06-15 20:12 ` Keith Busch
2016-06-15 20:50 ` Bart Van Assche
2016-06-16 15:19 ` Keith Busch
2016-06-22 11:56 ` Alexander Gordeev
2016-06-16 15:20 ` Christoph Hellwig
2016-06-16 15:39 ` Bart Van Assche
2016-06-20 12:22 ` Christoph Hellwig
2016-06-20 13:21 ` Bart Van Assche
2016-06-21 14:31 ` Christoph Hellwig
2016-06-16 9:08 ` Bart Van Assche
2016-06-14 19:58 ` [PATCH 03/13] irq: Add affinity hint to irq allocation Christoph Hellwig
2016-06-14 19:58 ` [PATCH 04/13] irq: Use affinity hint in irqdesc allocation Christoph Hellwig
2016-06-14 19:58 ` [PATCH 05/13] irq/msi: Make use of affinity aware allocations Christoph Hellwig
2016-06-14 19:58 ` [PATCH 06/13] irq: add a helper spread an affinity mask for MSI/MSI-X vectors Christoph Hellwig
2016-06-14 21:54 ` Guilherme G. Piccoli
2016-06-15 8:35 ` Bart Van Assche
2016-06-15 10:10 ` Christoph Hellwig
2016-06-15 13:09 ` Guilherme G. Piccoli
2016-06-16 15:16 ` Christoph Hellwig
2016-06-25 20:05 ` Alexander Gordeev
2016-06-30 17:48 ` Christoph Hellwig
2016-07-01 7:25 ` Alexander Gordeev
2016-06-14 19:59 ` [PATCH 07/13] pci: Provide sensible irq vector alloc/free routines Christoph Hellwig
2016-06-23 11:16 ` Alexander Gordeev
2016-06-30 16:54 ` Christoph Hellwig [this message]
2016-06-30 17:28 ` Alexander Gordeev
2016-06-30 17:35 ` Christoph Hellwig
2016-06-14 19:59 ` [PATCH 08/13] pci: spread interrupt vectors in pci_alloc_irq_vectors Christoph Hellwig
2016-06-25 20:22 ` Alexander Gordeev
2016-06-14 19:59 ` [PATCH 09/13] blk-mq: don't redistribute hardware queues on a CPU hotplug event Christoph Hellwig
2016-06-14 19:59 ` [PATCH 10/13] blk-mq: only allocate a single mq_map per tag_set Christoph Hellwig
2016-06-14 19:59 ` [PATCH 11/13] blk-mq: allow the driver to pass in an affinity mask Christoph Hellwig
2016-07-04 8:15 ` Alexander Gordeev
2016-07-04 8:38 ` Christoph Hellwig
2016-07-04 9:35 ` Alexander Gordeev
2016-07-10 3:41 ` Christoph Hellwig
2016-07-12 6:42 ` Alexander Gordeev
2016-06-14 19:59 ` [PATCH 12/13] nvme: switch to use pci_alloc_irq_vectors Christoph Hellwig
2016-06-14 19:59 ` [PATCH 13/13] nvme: remove the post_scan callout Christoph Hellwig
2016-06-16 9:45 ` automatic interrupt affinity for MSI/MSI-X capable devices V2 Bart Van Assche
2016-06-16 15:22 ` Christoph Hellwig
2016-06-26 19:40 ` Alexander Gordeev
2016-07-04 8:39 automatic interrupt affinity for MSI/MSI-X capable devices V3 Christoph Hellwig
2016-07-04 8:39 ` [PATCH 07/13] pci: Provide sensible irq vector alloc/free routines Christoph Hellwig
2016-07-06 8:05 ` Alexander Gordeev
2016-07-10 3:47 ` Christoph Hellwig
2016-07-11 10:43 ` Alexander Gordeev
2016-07-12 9:13 ` Christoph Hellwig
2016-07-12 12:46 ` Alexander Gordeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160630165417.GA21787@lst.de \
--to=hch@lst.de \
--cc=agordeev@redhat.com \
--cc=axboe@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).