* [PATCH] dmaengine: mmp_tdma: Select GENERIC_ALLOCATOR
@ 2016-11-03 12:36 Borislav Petkov
2016-11-14 5:09 ` Vinod Koul
0 siblings, 1 reply; 4+ messages in thread
From: Borislav Petkov @ 2016-11-03 12:36 UTC (permalink / raw)
To: LKML; +Cc: Dan Williams, Vinod Koul, dmaengine
From: Borislav Petkov <bp@suse.de>
as the driver needs it. Build error caught with a randconfig build:
drivers/built-in.o: In function `mmp_tdma_prep_dma_cyclic':
mmp_tdma.c:(.text+0x1612d9): undefined reference to `gen_pool_dma_alloc'
drivers/built-in.o: In function `mmp_tdma_free_chan_resources':
mmp_tdma.c:(.text+0x161444): undefined reference to `gen_pool_free'
drivers/built-in.o: In function `mmp_tdma_probe':
mmp_tdma.c:(.text+0x1616ac): undefined reference to `of_gen_pool_get'
make: *** [vmlinux] Error 1
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: dmaengine@vger.kernel.org
---
drivers/dma/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index af63a6bcf564..e88a6ef03dcf 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -304,6 +304,7 @@ config MMP_PDMA
config MMP_TDMA
bool "MMP Two-Channel DMA support"
depends on ARCH_MMP || COMPILE_TEST
+ select GENERIC_ALLOCATOR
select DMA_ENGINE
select MMP_SRAM if ARCH_MMP
help
--
2.10.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dmaengine: mmp_tdma: Select GENERIC_ALLOCATOR
2016-11-03 12:36 [PATCH] dmaengine: mmp_tdma: Select GENERIC_ALLOCATOR Borislav Petkov
@ 2016-11-14 5:09 ` Vinod Koul
0 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2016-11-14 5:09 UTC (permalink / raw)
To: Borislav Petkov; +Cc: LKML, Dan Williams, dmaengine
On Thu, Nov 03, 2016 at 01:36:55PM +0100, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
>
> as the driver needs it. Build error caught with a randconfig build:
Already fixed by commit d6619761068cf573cae406f176d00b82a39a37fc
:(dmaengine: mmp_tdma: add missing select GENERIC_ALLOCATOR in Kconfig)
You should see this in linux-next
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dmaengine: mmp_tdma: select GENERIC_ALLOCATOR
2016-10-10 12:07 [PATCH] dmaengine: mmp_tdma: select GENERIC_ALLOCATOR Arnd Bergmann
@ 2016-10-18 15:05 ` Vinod Koul
0 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2016-10-18 15:05 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Dan Williams, dmaengine, linux-kernel
On Mon, Oct 10, 2016 at 02:07:35PM +0200, Arnd Bergmann wrote:
> build testing on x86 revealed a missing dependency that leads to a link error:
>
> drivers/dma/built-in.o: In function `mmp_tdma_prep_dma_cyclic':
> mmp_tdma.c:(.text+0x9564): undefined reference to `gen_pool_dma_alloc'
> drivers/dma/built-in.o: In function `mmp_tdma_free_chan_resources':
> mmp_tdma.c:(.text+0x9675): undefined reference to `gen_pool_free'
> drivers/dma/built-in.o: In function `mmp_tdma_probe':
> mmp_tdma.c:(.text+0x9854): undefined reference to `of_gen_pool_get'
>
> This adds a 'select' statement to the driver to get it to build cleanly.
Hi Arnd,
I have already applied same change from Jérémy.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/dma/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index af63a6bcf564..d882eb0fa551 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -305,6 +305,7 @@ config MMP_TDMA
> bool "MMP Two-Channel DMA support"
> depends on ARCH_MMP || COMPILE_TEST
> select DMA_ENGINE
> + select GENERIC_ALLOCATOR
> select MMP_SRAM if ARCH_MMP
> help
> Support the MMP Two-Channel DMA engine.
> --
> 2.9.0
>
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] dmaengine: mmp_tdma: select GENERIC_ALLOCATOR
@ 2016-10-10 12:07 Arnd Bergmann
2016-10-18 15:05 ` Vinod Koul
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2016-10-10 12:07 UTC (permalink / raw)
To: Vinod Koul; +Cc: Arnd Bergmann, Dan Williams, dmaengine, linux-kernel
build testing on x86 revealed a missing dependency that leads to a link error:
drivers/dma/built-in.o: In function `mmp_tdma_prep_dma_cyclic':
mmp_tdma.c:(.text+0x9564): undefined reference to `gen_pool_dma_alloc'
drivers/dma/built-in.o: In function `mmp_tdma_free_chan_resources':
mmp_tdma.c:(.text+0x9675): undefined reference to `gen_pool_free'
drivers/dma/built-in.o: In function `mmp_tdma_probe':
mmp_tdma.c:(.text+0x9854): undefined reference to `of_gen_pool_get'
This adds a 'select' statement to the driver to get it to build cleanly.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/dma/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index af63a6bcf564..d882eb0fa551 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -305,6 +305,7 @@ config MMP_TDMA
bool "MMP Two-Channel DMA support"
depends on ARCH_MMP || COMPILE_TEST
select DMA_ENGINE
+ select GENERIC_ALLOCATOR
select MMP_SRAM if ARCH_MMP
help
Support the MMP Two-Channel DMA engine.
--
2.9.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-14 5:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-03 12:36 [PATCH] dmaengine: mmp_tdma: Select GENERIC_ALLOCATOR Borislav Petkov
2016-11-14 5:09 ` Vinod Koul
-- strict thread matches above, loose matches on Subject: below --
2016-10-10 12:07 [PATCH] dmaengine: mmp_tdma: select GENERIC_ALLOCATOR Arnd Bergmann
2016-10-18 15:05 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).