* [PATCH v2] staging: wlan-ng: This patch fixes the checkpatch.pl warning:
@ 2017-01-31 14:20 Maksymilian Piechota
2017-02-03 9:53 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Maksymilian Piechota @ 2017-01-31 14:20 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Maksymilian Piechota, linux-kernel, devel
Fix checkpatch.pl warning:
WARNING: Statements should start on a tabstop
V2: whole if statement cleared up
Signed-off-by: Maksymilian Piechota <maksymilianpiechota@gmail.com>
---
drivers/staging/wlan-ng/prism2mgmt.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c
index 2d67125..5277f36 100644
--- a/drivers/staging/wlan-ng/prism2mgmt.c
+++ b/drivers/staging/wlan-ng/prism2mgmt.c
@@ -1307,10 +1307,8 @@ int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp)
&& (msg->prismheader.data == P80211ENUM_truth_true)) {
hw->sniffhdr = 0;
wlandev->netdev->type = ARPHRD_IEEE80211_PRISM;
- } else
- if ((msg->wlanheader.status ==
- P80211ENUM_msgitem_status_data_ok)
- && (msg->wlanheader.data == P80211ENUM_truth_true)) {
+ } else if ((msg->wlanheader.status == P80211ENUM_msgitem_status_data_ok) &&
+ (msg->wlanheader.data == P80211ENUM_truth_true)) {
hw->sniffhdr = 1;
wlandev->netdev->type = ARPHRD_IEEE80211_PRISM;
} else {
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] staging: wlan-ng: This patch fixes the checkpatch.pl warning:
2017-01-31 14:20 [PATCH v2] staging: wlan-ng: This patch fixes the checkpatch.pl warning: Maksymilian Piechota
@ 2017-02-03 9:53 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2017-02-03 9:53 UTC (permalink / raw)
To: Maksymilian Piechota; +Cc: devel, linux-kernel
On Tue, Jan 31, 2017 at 09:20:15AM -0500, Maksymilian Piechota wrote:
> Fix checkpatch.pl warning:
Your subject is odd, it leaves something to the imagination :(
>
> WARNING: Statements should start on a tabstop
>
> V2: whole if statement cleared up
Put this below the --- line.
v3?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-03 9:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-31 14:20 [PATCH v2] staging: wlan-ng: This patch fixes the checkpatch.pl warning: Maksymilian Piechota
2017-02-03 9:53 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).