* [PATCH] regulator: arizona-ldo1: constify regulator_ops structure
@ 2017-01-28 13:38 Bhumika Goyal
2017-01-31 21:19 ` Applied "regulator: arizona-ldo1: constify regulator_ops structure" to the regulator tree Mark Brown
2017-02-01 15:08 ` [PATCH] regulator: arizona-ldo1: constify regulator_ops structure Charles Keepax
0 siblings, 2 replies; 3+ messages in thread
From: Bhumika Goyal @ 2017-01-28 13:38 UTC (permalink / raw)
To: julia.lawall, lgirdwood, broonie, linux-kernel; +Cc: Bhumika Goyal
Declare regulator_ops structure as const as it is only stored in the ops
field of a regulator_desc structure. This field is of type const, so
regulator_ops structures having this property can be made const too.
File size before: drivers/regulator/arizona-ldo1.o
text data bss dec hex filename
1890 720 0 2610 a32 drivers/regulator/arizona-ldo1.o
File size after: drivers/regulator/arizona-ldo1.o
text data bss dec hex filename
2402 192 0 2594 a22 drivers/regulator/arizona-ldo1.o
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
drivers/regulator/arizona-ldo1.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/arizona-ldo1.c b/drivers/regulator/arizona-ldo1.c
index 302b57c..e76d094 100644
--- a/drivers/regulator/arizona-ldo1.c
+++ b/drivers/regulator/arizona-ldo1.c
@@ -109,7 +109,7 @@ static int arizona_ldo1_hc_get_voltage_sel(struct regulator_dev *rdev)
return (val & ARIZONA_LDO1_VSEL_MASK) >> ARIZONA_LDO1_VSEL_SHIFT;
}
-static struct regulator_ops arizona_ldo1_hc_ops = {
+static const struct regulator_ops arizona_ldo1_hc_ops = {
.list_voltage = arizona_ldo1_hc_list_voltage,
.map_voltage = arizona_ldo1_hc_map_voltage,
.get_voltage_sel = arizona_ldo1_hc_get_voltage_sel,
@@ -135,7 +135,7 @@ static int arizona_ldo1_hc_get_voltage_sel(struct regulator_dev *rdev)
.owner = THIS_MODULE,
};
-static struct regulator_ops arizona_ldo1_ops = {
+static const struct regulator_ops arizona_ldo1_ops = {
.list_voltage = regulator_list_voltage_linear,
.map_voltage = regulator_map_voltage_linear,
.get_voltage_sel = regulator_get_voltage_sel_regmap,
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Applied "regulator: arizona-ldo1: constify regulator_ops structure" to the regulator tree
2017-01-28 13:38 [PATCH] regulator: arizona-ldo1: constify regulator_ops structure Bhumika Goyal
@ 2017-01-31 21:19 ` Mark Brown
2017-02-01 15:08 ` [PATCH] regulator: arizona-ldo1: constify regulator_ops structure Charles Keepax
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2017-01-31 21:19 UTC (permalink / raw)
To: Bhumika Goyal
Cc: Mark Brown, julia.lawall, lgirdwood, broonie, linux-kernel, linux-kernel
The patch
regulator: arizona-ldo1: constify regulator_ops structure
has been applied to the regulator tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 03d06107f834db328da5579348524855f10a276d Mon Sep 17 00:00:00 2001
From: Bhumika Goyal <bhumirks@gmail.com>
Date: Sat, 28 Jan 2017 19:08:41 +0530
Subject: [PATCH] regulator: arizona-ldo1: constify regulator_ops structure
Declare regulator_ops structure as const as it is only stored in the ops
field of a regulator_desc structure. This field is of type const, so
regulator_ops structures having this property can be made const too.
File size before: drivers/regulator/arizona-ldo1.o
text data bss dec hex filename
1890 720 0 2610 a32 drivers/regulator/arizona-ldo1.o
File size after: drivers/regulator/arizona-ldo1.o
text data bss dec hex filename
2402 192 0 2594 a22 drivers/regulator/arizona-ldo1.o
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/regulator/arizona-ldo1.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/arizona-ldo1.c b/drivers/regulator/arizona-ldo1.c
index 302b57cb89c6..e76d094591e7 100644
--- a/drivers/regulator/arizona-ldo1.c
+++ b/drivers/regulator/arizona-ldo1.c
@@ -109,7 +109,7 @@ static int arizona_ldo1_hc_get_voltage_sel(struct regulator_dev *rdev)
return (val & ARIZONA_LDO1_VSEL_MASK) >> ARIZONA_LDO1_VSEL_SHIFT;
}
-static struct regulator_ops arizona_ldo1_hc_ops = {
+static const struct regulator_ops arizona_ldo1_hc_ops = {
.list_voltage = arizona_ldo1_hc_list_voltage,
.map_voltage = arizona_ldo1_hc_map_voltage,
.get_voltage_sel = arizona_ldo1_hc_get_voltage_sel,
@@ -135,7 +135,7 @@ static const struct regulator_desc arizona_ldo1_hc = {
.owner = THIS_MODULE,
};
-static struct regulator_ops arizona_ldo1_ops = {
+static const struct regulator_ops arizona_ldo1_ops = {
.list_voltage = regulator_list_voltage_linear,
.map_voltage = regulator_map_voltage_linear,
.get_voltage_sel = regulator_get_voltage_sel_regmap,
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: arizona-ldo1: constify regulator_ops structure
2017-01-28 13:38 [PATCH] regulator: arizona-ldo1: constify regulator_ops structure Bhumika Goyal
2017-01-31 21:19 ` Applied "regulator: arizona-ldo1: constify regulator_ops structure" to the regulator tree Mark Brown
@ 2017-02-01 15:08 ` Charles Keepax
1 sibling, 0 replies; 3+ messages in thread
From: Charles Keepax @ 2017-02-01 15:08 UTC (permalink / raw)
To: Bhumika Goyal; +Cc: julia.lawall, lgirdwood, broonie, linux-kernel
On Sat, Jan 28, 2017 at 07:08:41PM +0530, Bhumika Goyal wrote:
> Declare regulator_ops structure as const as it is only stored in the ops
> field of a regulator_desc structure. This field is of type const, so
> regulator_ops structures having this property can be made const too.
>
> File size before: drivers/regulator/arizona-ldo1.o
> text data bss dec hex filename
> 1890 720 0 2610 a32 drivers/regulator/arizona-ldo1.o
>
> File size after: drivers/regulator/arizona-ldo1.o
> text data bss dec hex filename
> 2402 192 0 2594 a22 drivers/regulator/arizona-ldo1.o
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
Patch looks fine but CCing patches@opensource.wolfsonmicro.com on
patches to the Arizona driver would be greatly appreciated.
Thanks,
Charles
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-01 15:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-28 13:38 [PATCH] regulator: arizona-ldo1: constify regulator_ops structure Bhumika Goyal
2017-01-31 21:19 ` Applied "regulator: arizona-ldo1: constify regulator_ops structure" to the regulator tree Mark Brown
2017-02-01 15:08 ` [PATCH] regulator: arizona-ldo1: constify regulator_ops structure Charles Keepax
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).