linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] soc: zte: pm_domains: Remove redundant dev_err call in zx2967_pd_probe()
@ 2017-02-06 16:23 Wei Yongjun
  2017-03-08 11:41 ` Shawn Guo
  0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2017-02-06 16:23 UTC (permalink / raw)
  To: Jun Nie, Baoyou Xie, Shawn Guo
  Cc: Wei Yongjun, linux-arm-kernel, linux-kernel

From: Wei Yongjun <weiyongjun1@huawei.com>

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/soc/zte/zx2967_pm_domains.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/soc/zte/zx2967_pm_domains.c b/drivers/soc/zte/zx2967_pm_domains.c
index 61c8d84..c42aeaa 100644
--- a/drivers/soc/zte/zx2967_pm_domains.c
+++ b/drivers/soc/zte/zx2967_pm_domains.c
@@ -125,10 +125,8 @@ int zx2967_pd_probe(struct platform_device *pdev,
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	pcubase = devm_ioremap_resource(&pdev->dev, res);
-	if (IS_ERR(pcubase)) {
-		dev_err(&pdev->dev, "ioremap fail.\n");
+	if (IS_ERR(pcubase))
 		return PTR_ERR(pcubase);
-	}
 
 	for (i = 0; i < domain_num; ++i) {
 		zx_pm_domains[i]->power_on = zx2967_power_on;

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] soc: zte: pm_domains: Remove redundant dev_err call in zx2967_pd_probe()
  2017-02-06 16:23 [PATCH -next] soc: zte: pm_domains: Remove redundant dev_err call in zx2967_pd_probe() Wei Yongjun
@ 2017-03-08 11:41 ` Shawn Guo
  0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2017-03-08 11:41 UTC (permalink / raw)
  To: Wei Yongjun
  Cc: Jun Nie, Baoyou Xie, Wei Yongjun, linux-arm-kernel, linux-kernel

On Mon, Feb 06, 2017 at 04:23:02PM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-03-08 12:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-06 16:23 [PATCH -next] soc: zte: pm_domains: Remove redundant dev_err call in zx2967_pd_probe() Wei Yongjun
2017-03-08 11:41 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).