* [PATCH v3] staging: bcm2835-audio: Remove the initialization of static pointers.
@ 2017-02-07 23:45 AbdAllah-MEZITI
2017-02-09 12:17 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: AbdAllah-MEZITI @ 2017-02-07 23:45 UTC (permalink / raw)
To: gregkh
Cc: Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Stephen Warren, Lee Jones, Eric Anholt,
Michael Zoran, devel, linux-rpi-kernel, linux-arm-kernel,
linux-kernel
In C a static pointer will be initialized to NULL.
The §6.7.8 of the ISO/IEC 9899:1999 (E) document says that:
If an object that has static storage duration is not initialized
explicitly, then:
__ if it has pointer type, it is initialized to a null pointer.
Signed-off-by: AbdAllah-MEZITI <abdallah.meziti.pro@gmail.com>
v2: -fix the line-wrapping of the changelog.
-fix the ref. documentation: C99 standards release,
and not the draft.
-this patch is the Task 10 Eudyptula Challenge
that only fix one code style problem.
v3: -fix the subject prefix: must be based on the previous submissions.
---
drivers/staging/bcm2835-audio/bcm2835.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/bcm2835-audio/bcm2835.c b/drivers/staging/bcm2835-audio/bcm2835.c
index a84d74d..265fe55 100644
--- a/drivers/staging/bcm2835-audio/bcm2835.c
+++ b/drivers/staging/bcm2835-audio/bcm2835.c
@@ -28,8 +28,8 @@
* to debug if we run into issues
*/
-static struct snd_card *g_card = NULL;
-static struct bcm2835_chip *g_chip = NULL;
+static struct snd_card *g_card;
+static struct bcm2835_chip *g_chip;
static int snd_bcm2835_free(struct bcm2835_chip *chip)
{
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] staging: bcm2835-audio: Remove the initialization of static pointers.
2017-02-07 23:45 [PATCH v3] staging: bcm2835-audio: Remove the initialization of static pointers AbdAllah-MEZITI
@ 2017-02-09 12:17 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2017-02-09 12:17 UTC (permalink / raw)
To: AbdAllah-MEZITI
Cc: devel, Florian Fainelli, Scott Branden, Stephen Warren, Ray Jui,
Lee Jones, linux-kernel, Eric Anholt, Michael Zoran,
bcm-kernel-feedback-list, linux-rpi-kernel, linux-arm-kernel
On Wed, Feb 08, 2017 at 12:45:47AM +0100, AbdAllah-MEZITI wrote:
> In C a static pointer will be initialized to NULL.
> The §6.7.8 of the ISO/IEC 9899:1999 (E) document says that:
> If an object that has static storage duration is not initialized
> explicitly, then:
> __ if it has pointer type, it is initialized to a null pointer.
>
> Signed-off-by: AbdAllah-MEZITI <abdallah.meziti.pro@gmail.com>
>
> v2: -fix the line-wrapping of the changelog.
> -fix the ref. documentation: C99 standards release,
> and not the draft.
> -this patch is the Task 10 Eudyptula Challenge
> that only fix one code style problem.
> v3: -fix the subject prefix: must be based on the previous submissions.
> ---
> drivers/staging/bcm2835-audio/bcm2835.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
This patch does not apply to my tree at all, sorry.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-09 12:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-07 23:45 [PATCH v3] staging: bcm2835-audio: Remove the initialization of static pointers AbdAllah-MEZITI
2017-02-09 12:17 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).