* [PATCH] gen_init_cpio: allocate enough space for dname
@ 2017-03-21 16:44 Colin King
0 siblings, 0 replies; only message in thread
From: Colin King @ 2017-03-21 16:44 UTC (permalink / raw)
To: kernel-janitors; +Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The allocation of dname is short by 1 byte, so increase the allocation
size.
Detected with CoverityScan, CID#711628 ("Out-of-bounds-access (OVERRUN)")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
usr/gen_init_cpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/usr/gen_init_cpio.c b/usr/gen_init_cpio.c
index 225ad244cf88..981682f4faea 100644
--- a/usr/gen_init_cpio.c
+++ b/usr/gen_init_cpio.c
@@ -418,7 +418,7 @@ static int cpio_mkfile_line(const char *line)
int len;
int nend;
- dname = malloc(strlen(line));
+ dname = malloc(strlen(line) + 1);
if (!dname) {
fprintf (stderr, "out of memory (%d)\n", dname_len);
goto fail;
--
2.11.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2017-03-21 16:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-21 16:44 [PATCH] gen_init_cpio: allocate enough space for dname Colin King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).