* [PATCH v2] livepatch: Reduce the time of finding module symbols
@ 2017-03-28 13:10 Zhou Chengming
2017-03-29 14:59 ` Josh Poimboeuf
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Zhou Chengming @ 2017-03-28 13:10 UTC (permalink / raw)
To: live-patching, linux-kernel
Cc: jpoimboe, jeyu, jikos, mbenes, pmladek, huawei.libin, zhouchengming1
It's reported that the time of insmoding a klp.ko for one of our
out-tree modules is too long.
~ time sudo insmod klp.ko
real 0m23.799s
user 0m0.036s
sys 0m21.256s
Then we found the reason: our out-tree module used a lot of static local
variables, so klp.ko has a lot of relocation records which reference the
module. Then for each such entry klp_find_object_symbol() is called to
resolve it, but this function uses the interface kallsyms_on_each_symbol()
even for finding module symbols, so will waste a lot of time on walking
through vmlinux kallsyms table many times.
This patch changes it to use module_kallsyms_on_each_symbol() for modules
symbols. After we apply this patch, the sys time reduced dramatically.
~ time sudo insmod klp.ko
real 0m1.007s
user 0m0.032s
sys 0m0.924s
Signed-off-by: Zhou Chengming <zhouchengming1@huawei.com>
---
kernel/livepatch/core.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
index af46438..b4b8bb0 100644
--- a/kernel/livepatch/core.c
+++ b/kernel/livepatch/core.c
@@ -182,7 +182,10 @@ static int klp_find_object_symbol(const char *objname, const char *name,
};
mutex_lock(&module_mutex);
- kallsyms_on_each_symbol(klp_find_callback, &args);
+ if (objname)
+ module_kallsyms_on_each_symbol(klp_find_callback, &args);
+ else
+ kallsyms_on_each_symbol(klp_find_callback, &args);
mutex_unlock(&module_mutex);
/*
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] livepatch: Reduce the time of finding module symbols
2017-03-28 13:10 [PATCH v2] livepatch: Reduce the time of finding module symbols Zhou Chengming
@ 2017-03-29 14:59 ` Josh Poimboeuf
2017-03-29 19:40 ` Jessica Yu
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Josh Poimboeuf @ 2017-03-29 14:59 UTC (permalink / raw)
To: Zhou Chengming
Cc: live-patching, linux-kernel, jeyu, jikos, mbenes, pmladek, huawei.libin
On Tue, Mar 28, 2017 at 09:10:35PM +0800, Zhou Chengming wrote:
> It's reported that the time of insmoding a klp.ko for one of our
> out-tree modules is too long.
>
> ~ time sudo insmod klp.ko
> real 0m23.799s
> user 0m0.036s
> sys 0m21.256s
>
> Then we found the reason: our out-tree module used a lot of static local
> variables, so klp.ko has a lot of relocation records which reference the
> module. Then for each such entry klp_find_object_symbol() is called to
> resolve it, but this function uses the interface kallsyms_on_each_symbol()
> even for finding module symbols, so will waste a lot of time on walking
> through vmlinux kallsyms table many times.
>
> This patch changes it to use module_kallsyms_on_each_symbol() for modules
> symbols. After we apply this patch, the sys time reduced dramatically.
>
> ~ time sudo insmod klp.ko
> real 0m1.007s
> user 0m0.032s
> sys 0m0.924s
>
> Signed-off-by: Zhou Chengming <zhouchengming1@huawei.com>
It would be good to make kallsyms faster, but either way this still a
performance improvement for patching modules.
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
--
Josh
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] livepatch: Reduce the time of finding module symbols
2017-03-28 13:10 [PATCH v2] livepatch: Reduce the time of finding module symbols Zhou Chengming
2017-03-29 14:59 ` Josh Poimboeuf
@ 2017-03-29 19:40 ` Jessica Yu
2017-03-30 8:01 ` Miroslav Benes
2017-03-30 8:42 ` Jiri Kosina
3 siblings, 0 replies; 5+ messages in thread
From: Jessica Yu @ 2017-03-29 19:40 UTC (permalink / raw)
To: Zhou Chengming
Cc: live-patching, linux-kernel, jpoimboe, jikos, mbenes, pmladek,
huawei.libin
+++ Zhou Chengming [28/03/17 21:10 +0800]:
>It's reported that the time of insmoding a klp.ko for one of our
>out-tree modules is too long.
>
>~ time sudo insmod klp.ko
>real 0m23.799s
>user 0m0.036s
>sys 0m21.256s
>
>Then we found the reason: our out-tree module used a lot of static local
>variables, so klp.ko has a lot of relocation records which reference the
>module. Then for each such entry klp_find_object_symbol() is called to
>resolve it, but this function uses the interface kallsyms_on_each_symbol()
>even for finding module symbols, so will waste a lot of time on walking
>through vmlinux kallsyms table many times.
>
>This patch changes it to use module_kallsyms_on_each_symbol() for modules
>symbols. After we apply this patch, the sys time reduced dramatically.
>
>~ time sudo insmod klp.ko
>real 0m1.007s
>user 0m0.032s
>sys 0m0.924s
>
>Signed-off-by: Zhou Chengming <zhouchengming1@huawei.com>
Limiting the search space for symbol lookups is a valid improvement, so:
Acked-by: Jessica Yu <jeyu@redhat.com>
>---
> kernel/livepatch/core.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
>index af46438..b4b8bb0 100644
>--- a/kernel/livepatch/core.c
>+++ b/kernel/livepatch/core.c
>@@ -182,7 +182,10 @@ static int klp_find_object_symbol(const char *objname, const char *name,
> };
>
> mutex_lock(&module_mutex);
>- kallsyms_on_each_symbol(klp_find_callback, &args);
>+ if (objname)
>+ module_kallsyms_on_each_symbol(klp_find_callback, &args);
>+ else
>+ kallsyms_on_each_symbol(klp_find_callback, &args);
> mutex_unlock(&module_mutex);
>
> /*
>--
>1.8.3.1
>
>--
>To unsubscribe from this list: send the line "unsubscribe live-patching" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] livepatch: Reduce the time of finding module symbols
2017-03-28 13:10 [PATCH v2] livepatch: Reduce the time of finding module symbols Zhou Chengming
2017-03-29 14:59 ` Josh Poimboeuf
2017-03-29 19:40 ` Jessica Yu
@ 2017-03-30 8:01 ` Miroslav Benes
2017-03-30 8:42 ` Jiri Kosina
3 siblings, 0 replies; 5+ messages in thread
From: Miroslav Benes @ 2017-03-30 8:01 UTC (permalink / raw)
To: Zhou Chengming
Cc: live-patching, linux-kernel, jpoimboe, jeyu, jikos, pmladek,
huawei.libin
On Tue, 28 Mar 2017, Zhou Chengming wrote:
> It's reported that the time of insmoding a klp.ko for one of our
> out-tree modules is too long.
>
> ~ time sudo insmod klp.ko
> real 0m23.799s
> user 0m0.036s
> sys 0m21.256s
>
> Then we found the reason: our out-tree module used a lot of static local
> variables, so klp.ko has a lot of relocation records which reference the
> module. Then for each such entry klp_find_object_symbol() is called to
> resolve it, but this function uses the interface kallsyms_on_each_symbol()
> even for finding module symbols, so will waste a lot of time on walking
> through vmlinux kallsyms table many times.
>
> This patch changes it to use module_kallsyms_on_each_symbol() for modules
> symbols. After we apply this patch, the sys time reduced dramatically.
>
> ~ time sudo insmod klp.ko
> real 0m1.007s
> user 0m0.032s
> sys 0m0.924s
>
> Signed-off-by: Zhou Chengming <zhouchengming1@huawei.com>
We are the only user of kallsyms_on_each_symbol() interface right now, so
it is not that bad to optimize here. Temporarily :)
Acked-by: Miroslav Benes <mbenes@suse.cz>
Miroslav
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] livepatch: Reduce the time of finding module symbols
2017-03-28 13:10 [PATCH v2] livepatch: Reduce the time of finding module symbols Zhou Chengming
` (2 preceding siblings ...)
2017-03-30 8:01 ` Miroslav Benes
@ 2017-03-30 8:42 ` Jiri Kosina
3 siblings, 0 replies; 5+ messages in thread
From: Jiri Kosina @ 2017-03-30 8:42 UTC (permalink / raw)
To: Zhou Chengming
Cc: live-patching, linux-kernel, jpoimboe, jeyu, mbenes, pmladek,
huawei.libin
On Tue, 28 Mar 2017, Zhou Chengming wrote:
> It's reported that the time of insmoding a klp.ko for one of our
> out-tree modules is too long.
Applied to for-4.12/upstream. Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-03-30 8:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-28 13:10 [PATCH v2] livepatch: Reduce the time of finding module symbols Zhou Chengming
2017-03-29 14:59 ` Josh Poimboeuf
2017-03-29 19:40 ` Jessica Yu
2017-03-30 8:01 ` Miroslav Benes
2017-03-30 8:42 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).