linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dpaa_eth: use AVOIDBLOCK for Tx confirmation queues
@ 2017-03-30 13:24 Madalin Bucur
  2017-04-01 19:04 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Madalin Bucur @ 2017-03-30 13:24 UTC (permalink / raw)
  To: netdev; +Cc: davem, linux-kernel, linuxppc-dev, Madalin Bucur

The AVOIDBLOCK flag determines the Tx confirmation queues processing
to be redirected to any available CPU when the current one is slow
in processing them. This may result in a higher Tx confirmation
interrupt count but may reduce pressure on a certain CPU that with
the previous setting would process all Tx confirmation frames.

Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>
---
 drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
index d4bb8bf..9a520e4 100644
--- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
+++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
@@ -974,7 +974,7 @@ static int dpaa_fq_init(struct dpaa_fq *dpaa_fq, bool td_enable)
 		 * Tx Confirmation FQs.
 		 */
 		if (dpaa_fq->fq_type == FQ_TYPE_TX_CONFIRM)
-			initfq.fqd.fq_ctrl |= cpu_to_be16(QM_FQCTRL_HOLDACTIVE);
+			initfq.fqd.fq_ctrl |= cpu_to_be16(QM_FQCTRL_AVOIDBLOCK);
 
 		/* FQ placement */
 		initfq.we_mask |= cpu_to_be16(QM_INITFQ_WE_DESTWQ);
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] dpaa_eth: use AVOIDBLOCK for Tx confirmation queues
  2017-03-30 13:24 [PATCH] dpaa_eth: use AVOIDBLOCK for Tx confirmation queues Madalin Bucur
@ 2017-04-01 19:04 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-04-01 19:04 UTC (permalink / raw)
  To: madalin.bucur; +Cc: netdev, linux-kernel, linuxppc-dev

From: Madalin Bucur <madalin.bucur@nxp.com>
Date: Thu, 30 Mar 2017 16:24:15 +0300

> The AVOIDBLOCK flag determines the Tx confirmation queues processing
> to be redirected to any available CPU when the current one is slow
> in processing them. This may result in a higher Tx confirmation
> interrupt count but may reduce pressure on a certain CPU that with
> the previous setting would process all Tx confirmation frames.
> 
> Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-04-01 19:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-30 13:24 [PATCH] dpaa_eth: use AVOIDBLOCK for Tx confirmation queues Madalin Bucur
2017-04-01 19:04 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).