* [PATCH] Remove cpuset_update_active_cpus()'s parameter.
@ 2017-04-09 1:36 Rakib Mullick
2017-04-10 1:45 ` Zefan Li
2017-04-10 23:58 ` Tejun Heo
0 siblings, 2 replies; 3+ messages in thread
From: Rakib Mullick @ 2017-04-09 1:36 UTC (permalink / raw)
To: linux-kernel, mingo, tj; +Cc: Rakib Mullick, cgroups, akpm, peterz, lizefan
In cpuset_update_active_cpus(), cpu_online isn't used anymore. Remove
it.
Signed-off-by: Rakib Mullick<rakib.mullick@gmail.com>
---
include/linux/cpuset.h | 4 ++--
kernel/cgroup/cpuset.c | 2 +-
kernel/sched/core.c | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/include/linux/cpuset.h b/include/linux/cpuset.h
index 611fce5..119a3f9 100644
--- a/include/linux/cpuset.h
+++ b/include/linux/cpuset.h
@@ -42,7 +42,7 @@ static inline void cpuset_dec(void)
extern int cpuset_init(void);
extern void cpuset_init_smp(void);
-extern void cpuset_update_active_cpus(bool cpu_online);
+extern void cpuset_update_active_cpus(void);
extern void cpuset_cpus_allowed(struct task_struct *p, struct cpumask *mask);
extern void cpuset_cpus_allowed_fallback(struct task_struct *p);
extern nodemask_t cpuset_mems_allowed(struct task_struct *p);
@@ -155,7 +155,7 @@ static inline bool cpusets_enabled(void) { return false; }
static inline int cpuset_init(void) { return 0; }
static inline void cpuset_init_smp(void) {}
-static inline void cpuset_update_active_cpus(bool cpu_online)
+static inline void cpuset_update_active_cpus(void)
{
partition_sched_domains(1, NULL, NULL);
}
diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
index 0f41292..d6e8ded 100644
--- a/kernel/cgroup/cpuset.c
+++ b/kernel/cgroup/cpuset.c
@@ -2354,7 +2354,7 @@ static void cpuset_hotplug_workfn(struct work_struct *work)
rebuild_sched_domains();
}
-void cpuset_update_active_cpus(bool cpu_online)
+void cpuset_update_active_cpus(void)
{
/*
* We're inside cpu hotplug critical region which usually nests
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 3b31fc0..430b046 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -5732,7 +5732,7 @@ static void cpuset_cpu_active(void)
* cpuset configurations.
*/
}
- cpuset_update_active_cpus(true);
+ cpuset_update_active_cpus();
}
static int cpuset_cpu_inactive(unsigned int cpu)
@@ -5755,7 +5755,7 @@ static int cpuset_cpu_inactive(unsigned int cpu)
if (overflow)
return -EBUSY;
- cpuset_update_active_cpus(false);
+ cpuset_update_active_cpus();
} else {
num_cpus_frozen++;
partition_sched_domains(1, NULL, NULL);
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Remove cpuset_update_active_cpus()'s parameter.
2017-04-09 1:36 [PATCH] Remove cpuset_update_active_cpus()'s parameter Rakib Mullick
@ 2017-04-10 1:45 ` Zefan Li
2017-04-10 23:58 ` Tejun Heo
1 sibling, 0 replies; 3+ messages in thread
From: Zefan Li @ 2017-04-10 1:45 UTC (permalink / raw)
To: Rakib Mullick, linux-kernel, mingo, tj; +Cc: cgroups, akpm, peterz
On 2017/4/9 9:36, Rakib Mullick wrote:
> In cpuset_update_active_cpus(), cpu_online isn't used anymore. Remove
> it.
>
> Signed-off-by: Rakib Mullick<rakib.mullick@gmail.com>
Acked-by: Zefan Li <lizefan@huawei.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Remove cpuset_update_active_cpus()'s parameter.
2017-04-09 1:36 [PATCH] Remove cpuset_update_active_cpus()'s parameter Rakib Mullick
2017-04-10 1:45 ` Zefan Li
@ 2017-04-10 23:58 ` Tejun Heo
1 sibling, 0 replies; 3+ messages in thread
From: Tejun Heo @ 2017-04-10 23:58 UTC (permalink / raw)
To: Rakib Mullick; +Cc: linux-kernel, mingo, cgroups, akpm, peterz, lizefan
On Sun, Apr 09, 2017 at 07:36:14AM +0600, Rakib Mullick wrote:
> In cpuset_update_active_cpus(), cpu_online isn't used anymore. Remove
> it.
>
> Signed-off-by: Rakib Mullick<rakib.mullick@gmail.com>
Applied to cgroup/for-4.12.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-10 23:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-09 1:36 [PATCH] Remove cpuset_update_active_cpus()'s parameter Rakib Mullick
2017-04-10 1:45 ` Zefan Li
2017-04-10 23:58 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).