* [PATCH 1/1] lwtunnel: check return value of nla_nest_start
@ 2017-04-23 6:28 Pan Bian
2017-04-24 19:51 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Pan Bian @ 2017-04-23 6:28 UTC (permalink / raw)
To: David S. Miller
Cc: David Ahern, Roopa Prabhu, Alexei Starovoitov, David Lebrun,
Tom Herbert, Robert Shearman, netdev, linux-kernel, Pan Bian
Function nla_nest_start() may return a NULL pointer on error. However,
in function lwtunnel_fill_encap(), the return value of nla_nest_start()
is not validated before it is used. This patch checks the return value
of nla_nest_start() against NULL.
Signed-off-by: Pan Bian <bianpan2016@163.com>
---
net/core/lwtunnel.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/core/lwtunnel.c b/net/core/lwtunnel.c
index 6df9f8f..3471ce7 100644
--- a/net/core/lwtunnel.c
+++ b/net/core/lwtunnel.c
@@ -216,6 +216,8 @@ int lwtunnel_fill_encap(struct sk_buff *skb, struct lwtunnel_state *lwtstate)
ret = -EOPNOTSUPP;
nest = nla_nest_start(skb, RTA_ENCAP);
+ if (!nest)
+ goto nla_put_failure;
rcu_read_lock();
ops = rcu_dereference(lwtun_encaps[lwtstate->type]);
if (likely(ops && ops->fill_encap))
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] lwtunnel: check return value of nla_nest_start
2017-04-23 6:28 [PATCH 1/1] lwtunnel: check return value of nla_nest_start Pan Bian
@ 2017-04-24 19:51 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-04-24 19:51 UTC (permalink / raw)
To: bianpan2016
Cc: dsa, roopa, ast, david.lebrun, tom, rshearma, netdev, linux-kernel
From: Pan Bian <bianpan2016@163.com>
Date: Sun, 23 Apr 2017 14:28:37 +0800
> Function nla_nest_start() may return a NULL pointer on error. However,
> in function lwtunnel_fill_encap(), the return value of nla_nest_start()
> is not validated before it is used. This patch checks the return value
> of nla_nest_start() against NULL.
>
> Signed-off-by: Pan Bian <bianpan2016@163.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-24 19:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-23 6:28 [PATCH 1/1] lwtunnel: check return value of nla_nest_start Pan Bian
2017-04-24 19:51 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).