* [PATCH] Bluetooth: hci_nokia: select CONFIG_BT_HCIUART_H4
@ 2017-05-11 12:11 Arnd Bergmann
2017-05-11 18:14 ` Sebastian Reichel
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2017-05-11 12:11 UTC (permalink / raw)
To: Marcel Holtmann, Gustavo Padovan, Johan Hedberg
Cc: Arnd Bergmann, Bjorn Andersson, David S. Miller, Andy Gross,
Javier Martinez Canillas, Sebastian Reichel, Loic Poulain,
linux-bluetooth, linux-kernel
Like the other H4 variants, this only builds when the base
H4 support is enabled, otherwise we get a build error:
drivers/bluetooth/hci_nokia.c:624:33: error: array type has incomplete element type 'struct h4_recv_pkt'
Fixes: 7bb318680e86 ("Bluetooth: add nokia driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/bluetooth/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
index 40994d96d151..b2cf0ae6b62d 100644
--- a/drivers/bluetooth/Kconfig
+++ b/drivers/bluetooth/Kconfig
@@ -97,6 +97,7 @@ config BT_HCIUART_NOKIA
depends on BT_HCIUART
depends on BT_HCIUART_SERDEV
depends on PM
+ select BT_HCIUART_H4
help
Nokia H4+ is serial protocol for communication between Bluetooth
device and host. This protocol is required for Bluetooth devices
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Bluetooth: hci_nokia: select CONFIG_BT_HCIUART_H4
2017-05-11 12:11 [PATCH] Bluetooth: hci_nokia: select CONFIG_BT_HCIUART_H4 Arnd Bergmann
@ 2017-05-11 18:14 ` Sebastian Reichel
0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Reichel @ 2017-05-11 18:14 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Marcel Holtmann, Gustavo Padovan, Johan Hedberg, Bjorn Andersson,
David S. Miller, Andy Gross, Javier Martinez Canillas,
Loic Poulain, linux-bluetooth, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1141 bytes --]
Hi Arnd,
On Thu, May 11, 2017 at 02:11:26PM +0200, Arnd Bergmann wrote:
> Like the other H4 variants, this only builds when the base
> H4 support is enabled, otherwise we get a build error:
>
> drivers/bluetooth/hci_nokia.c:624:33: error: array type has incomplete element type 'struct h4_recv_pkt'
>
> Fixes: 7bb318680e86 ("Bluetooth: add nokia driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
This has already been sent by Tobias Regnery some days ago:
http://www.spinics.net/lists/linux-bluetooth/msg70433.html
-- Sebastian
> drivers/bluetooth/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
> index 40994d96d151..b2cf0ae6b62d 100644
> --- a/drivers/bluetooth/Kconfig
> +++ b/drivers/bluetooth/Kconfig
> @@ -97,6 +97,7 @@ config BT_HCIUART_NOKIA
> depends on BT_HCIUART
> depends on BT_HCIUART_SERDEV
> depends on PM
> + select BT_HCIUART_H4
> help
> Nokia H4+ is serial protocol for communication between Bluetooth
> device and host. This protocol is required for Bluetooth devices
> --
> 2.9.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-11 18:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-11 12:11 [PATCH] Bluetooth: hci_nokia: select CONFIG_BT_HCIUART_H4 Arnd Bergmann
2017-05-11 18:14 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).