* [PATCH] usb: chipidea: debug: check before accessing ci_role
@ 2017-05-18 14:14 Michael Thalmeier
2017-05-19 0:57 ` Peter Chen
2017-05-19 1:15 ` Peter Chen
0 siblings, 2 replies; 4+ messages in thread
From: Michael Thalmeier @ 2017-05-18 14:14 UTC (permalink / raw)
To: Peter Chen, Greg Kroah-Hartman; +Cc: linux-usb, linux-kernel, michael
ci_role BUGs when the role is >= CI_ROLE_END.
Signed-off-by: Michael Thalmeier <michael.thalmeier@hale.at>
---
drivers/usb/chipidea/debug.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/chipidea/debug.c b/drivers/usb/chipidea/debug.c
index 6d23eed..1c31e8a 100644
--- a/drivers/usb/chipidea/debug.c
+++ b/drivers/usb/chipidea/debug.c
@@ -294,7 +294,8 @@ static int ci_role_show(struct seq_file *s, void *data)
{
struct ci_hdrc *ci = s->private;
- seq_printf(s, "%s\n", ci_role(ci)->name);
+ if (ci->role != CI_ROLE_END)
+ seq_printf(s, "%s\n", ci_role(ci)->name);
return 0;
}
--
2.9.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: chipidea: debug: check before accessing ci_role
2017-05-18 14:14 [PATCH] usb: chipidea: debug: check before accessing ci_role Michael Thalmeier
@ 2017-05-19 0:57 ` Peter Chen
2017-05-19 1:15 ` Peter Chen
1 sibling, 0 replies; 4+ messages in thread
From: Peter Chen @ 2017-05-19 0:57 UTC (permalink / raw)
To: Michael Thalmeier
Cc: Peter Chen, Greg Kroah-Hartman, linux-usb, linux-kernel, michael
On Thu, May 18, 2017 at 04:14:14PM +0200, Michael Thalmeier wrote:
> ci_role BUGs when the role is >= CI_ROLE_END.
>
> Signed-off-by: Michael Thalmeier <michael.thalmeier@hale.at>
> ---
> drivers/usb/chipidea/debug.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/chipidea/debug.c b/drivers/usb/chipidea/debug.c
> index 6d23eed..1c31e8a 100644
> --- a/drivers/usb/chipidea/debug.c
> +++ b/drivers/usb/chipidea/debug.c
> @@ -294,7 +294,8 @@ static int ci_role_show(struct seq_file *s, void *data)
> {
> struct ci_hdrc *ci = s->private;
>
> - seq_printf(s, "%s\n", ci_role(ci)->name);
> + if (ci->role != CI_ROLE_END)
> + seq_printf(s, "%s\n", ci_role(ci)->name);
>
> return 0;
> }
I will queue it, and cc stable
--
Best Regards,
Peter Chen
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: chipidea: debug: check before accessing ci_role
2017-05-18 14:14 [PATCH] usb: chipidea: debug: check before accessing ci_role Michael Thalmeier
2017-05-19 0:57 ` Peter Chen
@ 2017-05-19 1:15 ` Peter Chen
2017-05-19 8:14 ` Michael Thalmeier
1 sibling, 1 reply; 4+ messages in thread
From: Peter Chen @ 2017-05-19 1:15 UTC (permalink / raw)
To: Michael Thalmeier
Cc: Peter Chen, Greg Kroah-Hartman, linux-usb, linux-kernel, michael
On Thu, May 18, 2017 at 04:14:14PM +0200, Michael Thalmeier wrote:
> ci_role BUGs when the role is >= CI_ROLE_END.
>
> Signed-off-by: Michael Thalmeier <michael.thalmeier@hale.at>
> ---
> drivers/usb/chipidea/debug.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/chipidea/debug.c b/drivers/usb/chipidea/debug.c
> index 6d23eed..1c31e8a 100644
> --- a/drivers/usb/chipidea/debug.c
> +++ b/drivers/usb/chipidea/debug.c
> @@ -294,7 +294,8 @@ static int ci_role_show(struct seq_file *s, void *data)
> {
> struct ci_hdrc *ci = s->private;
>
> - seq_printf(s, "%s\n", ci_role(ci)->name);
> + if (ci->role != CI_ROLE_END)
> + seq_printf(s, "%s\n", ci_role(ci)->name);
>
> return 0;
> }
By the way, how can you trigger this issue?
Do you mind sending another patch to fix the same issue for ci_role_show
at core.c?
--
Best Regards,
Peter Chen
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: chipidea: debug: check before accessing ci_role
2017-05-19 1:15 ` Peter Chen
@ 2017-05-19 8:14 ` Michael Thalmeier
0 siblings, 0 replies; 4+ messages in thread
From: Michael Thalmeier @ 2017-05-19 8:14 UTC (permalink / raw)
To: Peter Chen; +Cc: Peter Chen, Greg Kroah-Hartman, linux-usb, linux-kernel
On Fri, May 19, 2017 at 09:15:40AM +0800, Peter Chen wrote:
> On Thu, May 18, 2017 at 04:14:14PM +0200, Michael Thalmeier wrote:
> > ci_role BUGs when the role is >= CI_ROLE_END.
> >
> > Signed-off-by: Michael Thalmeier <michael.thalmeier@hale.at>
> > ---
> > drivers/usb/chipidea/debug.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/chipidea/debug.c b/drivers/usb/chipidea/debug.c
> > index 6d23eed..1c31e8a 100644
> > --- a/drivers/usb/chipidea/debug.c
> > +++ b/drivers/usb/chipidea/debug.c
> > @@ -294,7 +294,8 @@ static int ci_role_show(struct seq_file *s, void *data)
> > {
> > struct ci_hdrc *ci = s->private;
> >
> > - seq_printf(s, "%s\n", ci_role(ci)->name);
> > + if (ci->role != CI_ROLE_END)
> > + seq_printf(s, "%s\n", ci_role(ci)->name);
> >
> > return 0;
> > }
>
> By the way, how can you trigger this issue?
It is quite easy to trigger.
I have an USB OTG adapter cable connected to the micro-USB port of my device.
When the cable is connected, the port has the "host" role. When
disconnected, the role changes to "gadget".
When polling (1 second interval) the role file while
connecting/disconnecting the USB OTG cable, the error occurs within
the first few tries.
> Do you mind sending another patch to fix the same issue for ci_role_show
> at core.c?
I did not see, that there is now another place this is used. Will send
a patch later.
>
> --
>
> Best Regards,
> Peter Chen
Regards,
Michael
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-19 8:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-18 14:14 [PATCH] usb: chipidea: debug: check before accessing ci_role Michael Thalmeier
2017-05-19 0:57 ` Peter Chen
2017-05-19 1:15 ` Peter Chen
2017-05-19 8:14 ` Michael Thalmeier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).