* [PATCH] dmaengine: bcm-sba-raid: fix Kconfig dependencies
@ 2017-05-18 13:25 Arnd Bergmann
2017-05-19 3:20 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2017-05-18 13:25 UTC (permalink / raw)
To: Vinod Koul
Cc: Arnd Bergmann, Dan Williams, Anup Patel, dmaengine, linux-kernel
The new driver requires both mailbox and raid support for compile
testing:
drivers/dma/built-in.o: In function `sba_remove':
edma.c:(.text+0x4414): undefined reference to `mbox_free_channel'
drivers/dma/built-in.o: In function `sba_issue_pending':
edma.c:(.text+0x46cc): undefined reference to `mbox_send_message'
drivers/dma/built-in.o: In function `sba_probe':
edma.c:(.text+0x4e60): undefined reference to `mbox_request_channel'
edma.c:(.text+0x5038): undefined reference to `mbox_free_channel'
drivers/dma/built-in.o: In function `sba_tx_status':
edma.c:(.text+0x5210): undefined reference to `mbox_client_peek_data'
drivers/dma/built-in.o: In function `sba_prep_dma_pq_req':
edma.c:(.text+0x5784): undefined reference to `raid6_gflog'
edma.c:(.text+0x5798): undefined reference to `raid6_gflog'
This rearranges the Kconfig dependencies accordingly.
Fixes: 743e1c8ffe4e ("dmaengine: Add Broadcom SBA RAID driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/dma/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index b7e0ab9585bc..686ae67d7e2a 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -101,7 +101,8 @@ config AXI_DMAC
config BCM_SBA_RAID
tristate "Broadcom SBA RAID engine support"
- depends on (ARM64 && MAILBOX && RAID6_PQ) || COMPILE_TEST
+ depends on ARM64 || COMPILE_TEST
+ depends on MAILBOX && RAID6_PQ
select DMA_ENGINE
select DMA_ENGINE_RAID
select ASYNC_TX_DISABLE_XOR_VAL_DMA
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: bcm-sba-raid: fix Kconfig dependencies
2017-05-18 13:25 [PATCH] dmaengine: bcm-sba-raid: fix Kconfig dependencies Arnd Bergmann
@ 2017-05-19 3:20 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2017-05-19 3:20 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Dan Williams, Anup Patel, dmaengine, linux-kernel
On Thu, May 18, 2017 at 03:25:25PM +0200, Arnd Bergmann wrote:
> The new driver requires both mailbox and raid support for compile
> testing:
>
> drivers/dma/built-in.o: In function `sba_remove':
> edma.c:(.text+0x4414): undefined reference to `mbox_free_channel'
> drivers/dma/built-in.o: In function `sba_issue_pending':
> edma.c:(.text+0x46cc): undefined reference to `mbox_send_message'
> drivers/dma/built-in.o: In function `sba_probe':
> edma.c:(.text+0x4e60): undefined reference to `mbox_request_channel'
> edma.c:(.text+0x5038): undefined reference to `mbox_free_channel'
> drivers/dma/built-in.o: In function `sba_tx_status':
> edma.c:(.text+0x5210): undefined reference to `mbox_client_peek_data'
>
> drivers/dma/built-in.o: In function `sba_prep_dma_pq_req':
> edma.c:(.text+0x5784): undefined reference to `raid6_gflog'
> edma.c:(.text+0x5798): undefined reference to `raid6_gflog'
>
> This rearranges the Kconfig dependencies accordingly.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-19 3:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-18 13:25 [PATCH] dmaengine: bcm-sba-raid: fix Kconfig dependencies Arnd Bergmann
2017-05-19 3:20 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).