* [PATCH] crypto: n2: make of_device_ids const
@ 2017-06-15 11:58 Arvind Yadav
2017-06-15 15:11 ` David Miller
2017-06-20 3:42 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Arvind Yadav @ 2017-06-15 11:58 UTC (permalink / raw)
To: herbert, davem, tglx; +Cc: linux-crypto, linux-kernel
of_device_ids are not supposed to change at runtime. All functions
working with of_device_ids provided by <linux/of.h> work with const
of_device_ids. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
2001 2168 48 4217 1079 drivers/crypto/n2_core.o
File size after constify dummy_tlb_ops.:
text data bss dec hex filename
3601 536 48 4185 1059 drivers/crypto/n2_core.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/crypto/n2_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/n2_core.c b/drivers/crypto/n2_core.c
index 4ecb77a..2694513 100644
--- a/drivers/crypto/n2_core.c
+++ b/drivers/crypto/n2_core.c
@@ -2169,7 +2169,7 @@ static int n2_mau_remove(struct platform_device *dev)
return 0;
}
-static struct of_device_id n2_crypto_match[] = {
+static const struct of_device_id n2_crypto_match[] = {
{
.name = "n2cp",
.compatible = "SUNW,n2-cwq",
@@ -2196,7 +2196,7 @@ static int n2_mau_remove(struct platform_device *dev)
.remove = n2_crypto_remove,
};
-static struct of_device_id n2_mau_match[] = {
+static const struct of_device_id n2_mau_match[] = {
{
.name = "ncp",
.compatible = "SUNW,n2-mau",
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: n2: make of_device_ids const
2017-06-15 11:58 [PATCH] crypto: n2: make of_device_ids const Arvind Yadav
@ 2017-06-15 15:11 ` David Miller
2017-06-20 3:42 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-06-15 15:11 UTC (permalink / raw)
To: arvind.yadav.cs; +Cc: herbert, tglx, linux-crypto, linux-kernel
From: Arvind Yadav <arvind.yadav.cs@gmail.com>
Date: Thu, 15 Jun 2017 17:28:10 +0530
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 2001 2168 48 4217 1079 drivers/crypto/n2_core.o
>
> File size after constify dummy_tlb_ops.:
> text data bss dec hex filename
> 3601 536 48 4185 1059 drivers/crypto/n2_core.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: n2: make of_device_ids const
2017-06-15 11:58 [PATCH] crypto: n2: make of_device_ids const Arvind Yadav
2017-06-15 15:11 ` David Miller
@ 2017-06-20 3:42 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2017-06-20 3:42 UTC (permalink / raw)
To: Arvind Yadav; +Cc: davem, tglx, linux-crypto, linux-kernel
On Thu, Jun 15, 2017 at 05:28:10PM +0530, Arvind Yadav wrote:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 2001 2168 48 4217 1079 drivers/crypto/n2_core.o
>
> File size after constify dummy_tlb_ops.:
> text data bss dec hex filename
> 3601 536 48 4185 1059 drivers/crypto/n2_core.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-20 3:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-15 11:58 [PATCH] crypto: n2: make of_device_ids const Arvind Yadav
2017-06-15 15:11 ` David Miller
2017-06-20 3:42 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).