[PATCH v2 1/3] dt-bindings: iio: humidity: add bindings for HDC100x sensors

[PATCH v2 1/3] dt-bindings: iio: humidity: add bindings for HDC100x sensors

[Michael Stecklein]

Add the bindings for the family of HDC100x sensors.

Signed-off-by: Michael Stecklein <m-stecklein@ti.com>
---
 .../devicetree/bindings/iio/humidity/hdc100x.txt        | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/humidity/hdc100x.txt

diff --git a/Documentation/devicetree/bindings/iio/humidity/hdc100x.txt b/Documentation/devicetree/bindings/iio/humidity/hdc100x.txt
new file mode 100644
index 0000000..c52333b
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/humidity/hdc100x.txt
@@ -0,0 +1,17 @@
+* HDC100x temperature + humidity sensors
+
+Required properties:
+  - compatible: Should contain one of the following:
+	ti,hdc1000
+	ti,hdc1008
+	ti,hdc1010
+	ti,hdc1050
+	ti,hdc1080
+  - reg: i2c address of the sensor
+
+Example:
+
+hdc100x@40 {
+	compatible = "ti,hdc1000";
+	reg = <0x40>;
+};
-- 
2.7.4

[PATCH v2 2/3] iio: humidity: hdc100x: document compatible HDC10xx devices

[Michael Stecklein]

Include datasheet links, add i2c_device_id entries, and update
kconfig help for compatible HDC10xx devices: HDC1000, HDC1008,
HDC1010, HDC1050, and HDC1080.

Signed-off-by: Michael Stecklein <m-stecklein@ti.com>
---
 drivers/iio/humidity/Kconfig   |  3 ++-
 drivers/iio/humidity/hdc100x.c | 11 +++++++++++
 2 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/humidity/Kconfig b/drivers/iio/humidity/Kconfig
index 14b9ce4..2c0fc9a 100644
--- a/drivers/iio/humidity/Kconfig
+++ b/drivers/iio/humidity/Kconfig
@@ -31,7 +31,8 @@ config HDC100X
 	select IIO_TRIGGERED_BUFFER
 	help
 	  Say yes here to build support for the Texas Instruments
-	  HDC1000 and HDC1008 relative humidity and temperature sensors.
+	  HDC1000, HDC1008, HDC1010, HDC1050, and HDC1080 relative
+	  humidity and temperature sensors.
 
 	  To compile this driver as a module, choose M here: the module
 	  will be called hdc100x.
diff --git a/drivers/iio/humidity/hdc100x.c b/drivers/iio/humidity/hdc100x.c
index aa17115..6778bc7 100644
--- a/drivers/iio/humidity/hdc100x.c
+++ b/drivers/iio/humidity/hdc100x.c
@@ -13,6 +13,12 @@
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  * GNU General Public License for more details.
  *
+ * Datasheets:
+ * http://www.ti.com/product/HDC1000/datasheet
+ * http://www.ti.com/product/HDC1008/datasheet
+ * http://www.ti.com/product/HDC1010/datasheet
+ * http://www.ti.com/product/HDC1050/datasheet
+ * http://www.ti.com/product/HDC1080/datasheet
  */
 
 #include <linux/delay.h>
@@ -414,6 +420,11 @@ static int hdc100x_remove(struct i2c_client *client)
 
 static const struct i2c_device_id hdc100x_id[] = {
 	{ "hdc100x", 0 },
+	{ "hdc1000", 0 },
+	{ "hdc1008", 0 },
+	{ "hdc1010", 0 },
+	{ "hdc1050", 0 },
+	{ "hdc1080", 0 },
 	{ }
 };
 MODULE_DEVICE_TABLE(i2c, hdc100x_id);
-- 
2.7.4

[PATCH v2 3/3] iio: humidity: hdc100x: add match table and device id's

[Michael Stecklein]

Add of_match_table and point it to a list of compatible device tree
device id's.

Signed-off-by: Michael Stecklein <m-stecklein@ti.com>
---
 drivers/iio/humidity/hdc100x.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/iio/humidity/hdc100x.c b/drivers/iio/humidity/hdc100x.c
index 6778bc7..7851bd9 100644
--- a/drivers/iio/humidity/hdc100x.c
+++ b/drivers/iio/humidity/hdc100x.c
@@ -429,9 +429,20 @@ static const struct i2c_device_id hdc100x_id[] = {
 };
 MODULE_DEVICE_TABLE(i2c, hdc100x_id);
 
+static const struct of_device_id hdc100x_dt_ids[] = {
+	{ .compatible = "ti,hdc1000" },
+	{ .compatible = "ti,hdc1008" },
+	{ .compatible = "ti,hdc1010" },
+	{ .compatible = "ti,hdc1050" },
+	{ .compatible = "ti,hdc1080" },
+	{ }
+};
+MODULE_DEVICE_TABLE(of, hdc100x_dt_ids);
+
 static struct i2c_driver hdc100x_driver = {
 	.driver = {
 		.name	= "hdc100x",
+		.of_match_table = of_match_ptr(hdc100x_dt_ids),
 	},
 	.probe = hdc100x_probe,
 	.remove = hdc100x_remove,
-- 
2.7.4

Re: [PATCH v2 1/3] dt-bindings: iio: humidity: add bindings for HDC100x sensors

[Jonathan Cameron]

On Mon, 19 Jun 2017 11:01:04 -0500
Michael Stecklein <m-stecklein@ti.com> wrote:

> Add the bindings for the family of HDC100x sensors.
> 
> Signed-off-by: Michael Stecklein <m-stecklein@ti.com>
Ideally a brief note below the --- would have said what was different
from v1.

Given you have fixed the stuff Rob mentioned, I'll assume he will
be fine with the result.  Will be possible to change it for a few
days anyway as pushed out as testing which I'm willing to rebase.

Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.

Thanks,

Jonathan
> ---
>  .../devicetree/bindings/iio/humidity/hdc100x.txt        | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/humidity/hdc100x.txt
> 
> diff --git a/Documentation/devicetree/bindings/iio/humidity/hdc100x.txt b/Documentation/devicetree/bindings/iio/humidity/hdc100x.txt
> new file mode 100644
> index 0000000..c52333b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/humidity/hdc100x.txt
> @@ -0,0 +1,17 @@
> +* HDC100x temperature + humidity sensors
> +
> +Required properties:
> +  - compatible: Should contain one of the following:
> +	ti,hdc1000
> +	ti,hdc1008
> +	ti,hdc1010
> +	ti,hdc1050
> +	ti,hdc1080
> +  - reg: i2c address of the sensor
> +
> +Example:
> +
> +hdc100x@40 {
> +	compatible = "ti,hdc1000";
> +	reg = <0x40>;
> +};

Re: [PATCH v2 2/3] iio: humidity: hdc100x: document compatible HDC10xx devices

[Jonathan Cameron]

On Mon, 19 Jun 2017 11:01:05 -0500
Michael Stecklein <m-stecklein@ti.com> wrote:

> Include datasheet links, add i2c_device_id entries, and update
> kconfig help for compatible HDC10xx devices: HDC1000, HDC1008,
> HDC1010, HDC1050, and HDC1080.
> 
> Signed-off-by: Michael Stecklein <m-stecklein@ti.com>
Applied to the togreg branch of iio.git. Initially pushed out as testing
for the autobuilders to play with it.

Thanks,

Jonathan
> ---
>  drivers/iio/humidity/Kconfig   |  3 ++-
>  drivers/iio/humidity/hdc100x.c | 11 +++++++++++
>  2 files changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/humidity/Kconfig b/drivers/iio/humidity/Kconfig
> index 14b9ce4..2c0fc9a 100644
> --- a/drivers/iio/humidity/Kconfig
> +++ b/drivers/iio/humidity/Kconfig
> @@ -31,7 +31,8 @@ config HDC100X
>  	select IIO_TRIGGERED_BUFFER
>  	help
>  	  Say yes here to build support for the Texas Instruments
> -	  HDC1000 and HDC1008 relative humidity and temperature sensors.
> +	  HDC1000, HDC1008, HDC1010, HDC1050, and HDC1080 relative
> +	  humidity and temperature sensors.
>  
>  	  To compile this driver as a module, choose M here: the module
>  	  will be called hdc100x.
> diff --git a/drivers/iio/humidity/hdc100x.c b/drivers/iio/humidity/hdc100x.c
> index aa17115..6778bc7 100644
> --- a/drivers/iio/humidity/hdc100x.c
> +++ b/drivers/iio/humidity/hdc100x.c
> @@ -13,6 +13,12 @@
>   * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>   * GNU General Public License for more details.
>   *
> + * Datasheets:
> + * http://www.ti.com/product/HDC1000/datasheet
> + * http://www.ti.com/product/HDC1008/datasheet
> + * http://www.ti.com/product/HDC1010/datasheet
> + * http://www.ti.com/product/HDC1050/datasheet
> + * http://www.ti.com/product/HDC1080/datasheet
>   */
>  
>  #include <linux/delay.h>
> @@ -414,6 +420,11 @@ static int hdc100x_remove(struct i2c_client *client)
>  
>  static const struct i2c_device_id hdc100x_id[] = {
>  	{ "hdc100x", 0 },
> +	{ "hdc1000", 0 },
> +	{ "hdc1008", 0 },
> +	{ "hdc1010", 0 },
> +	{ "hdc1050", 0 },
> +	{ "hdc1080", 0 },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(i2c, hdc100x_id);

Re: [PATCH v2 3/3] iio: humidity: hdc100x: add match table and device id's

[Jonathan Cameron]

On Mon, 19 Jun 2017 11:01:06 -0500
Michael Stecklein <m-stecklein@ti.com> wrote:

> Add of_match_table and point it to a list of compatible device tree
> device id's.
> 
> Signed-off-by: Michael Stecklein <m-stecklein@ti.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.

Thanks,

Jonathan
> ---
>  drivers/iio/humidity/hdc100x.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/iio/humidity/hdc100x.c b/drivers/iio/humidity/hdc100x.c
> index 6778bc7..7851bd9 100644
> --- a/drivers/iio/humidity/hdc100x.c
> +++ b/drivers/iio/humidity/hdc100x.c
> @@ -429,9 +429,20 @@ static const struct i2c_device_id hdc100x_id[] = {
>  };
>  MODULE_DEVICE_TABLE(i2c, hdc100x_id);
>  
> +static const struct of_device_id hdc100x_dt_ids[] = {
> +	{ .compatible = "ti,hdc1000" },
> +	{ .compatible = "ti,hdc1008" },
> +	{ .compatible = "ti,hdc1010" },
> +	{ .compatible = "ti,hdc1050" },
> +	{ .compatible = "ti,hdc1080" },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(of, hdc100x_dt_ids);
> +
>  static struct i2c_driver hdc100x_driver = {
>  	.driver = {
>  		.name	= "hdc100x",
> +		.of_match_table = of_match_ptr(hdc100x_dt_ids),
>  	},
>  	.probe = hdc100x_probe,
>  	.remove = hdc100x_remove,

Re: [PATCH v2 1/3] dt-bindings: iio: humidity: add bindings for HDC100x sensors

[Rob Herring]

On Mon, Jun 19, 2017 at 11:01:04AM -0500, Michael Stecklein wrote:
> Add the bindings for the family of HDC100x sensors.
> 
> Signed-off-by: Michael Stecklein <m-stecklein@ti.com>
> ---
>  .../devicetree/bindings/iio/humidity/hdc100x.txt        | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/humidity/hdc100x.txt

Acked-by: Rob Herring <robh@kernel.org>