* [PATCH] Input: synaptics - switch t460s 20FN to use RMI4 over SMBus
[not found] <CAE4xfVLxhF29jLoFWwa4o6_0G_5VMQ8YN1BVP4=8+Y3u_BERPw@mail.gmail.com>
@ 2017-06-26 8:26 ` Benjamin Tissoires
[not found] ` <CAE4xfV+Z8Yq=5rGP7H5CcWYfJrNLDPVjgqFOb_ebk0QOYat7Hw@mail.gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Benjamin Tissoires @ 2017-06-26 8:26 UTC (permalink / raw)
To: Christopher Bachner, Dmitry Torokhov
Cc: linux-input, linux-kernel, Benjamin Tissoires
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
Hi Christopher,
Could you please test this patch without appending synaptics_intertouch=1
to the boot command line? If this still works, we will have the RMI4 over
SMBus by default for your laptop.
Cheers,
Benjamin
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
drivers/input/mouse/synaptics.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index f4fbe1a..a8fb26bc 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -173,6 +173,7 @@ static const char * const smbus_pnp_ids[] = {
"LEN0046", /* X250 */
"LEN004a", /* W541 */
"LEN200f", /* T450s */
+ "LEN2016", /* T460 20FN */
NULL
};
--
2.9.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: synaptics - switch t460s 20FN to use RMI4 over SMBus
[not found] ` <CAE4xfV+ygZ5Z9VsFdzmkQQgZZyH79zM4Jr2PHS2s0b9NYG7fqQ@mail.gmail.com>
@ 2017-06-26 15:38 ` Benjamin Tissoires
2017-06-27 7:53 ` Benjamin Tissoires
0 siblings, 1 reply; 3+ messages in thread
From: Benjamin Tissoires @ 2017-06-26 15:38 UTC (permalink / raw)
To: Christopher Bachner; +Cc: Dmitry Torokhov, linux-input, linux-kernel
On Jun 26 2017 or thereabouts, Christopher Bachner wrote:
> Hello,
>
> I am assuming that if the inertouch message is not showing up in dmesg,
> then it is working. Is that a correct assumption?
>
> Either way I also attached my dmesg.
>
> I am not sure, though, why the scroll mode still freezes if I move the my
> fingers quickly on the touchpad while also using the trackpoint. Is that
> maybe a future fix and this change is just the foundation for it? Overall
> the usage of the trackpoint is better now for sure.
Sadly, you are also hit by:
[ 6.355378] i801_smbus 0000:00:1f.4: BIOS is accessing SMBus registers
[ 6.355380] i801_smbus 0000:00:1f.4: Driver SMBus register access inhibited
Which disables entirely the RMI4 over SMBus module. And then we can not
probe for it, meaning you are stuck with the PS/2 crappy mode.
We are aware of this bug and we'll try to fix that. I think the test you
provides are valid (the patch works as expected), but a different bug
prevents rmi-smbus to fully initialize the touchpad :(
Cheers,
Benjamin
>
>
> (Resending again without attachment since the linux-kernel@vger.kernel.org
> and linux-input@vger.kernel.org don't accept attachments)
>
>
> ---
> Thanks,
>
> Christopher Bachner
>
> ---
> Thanks,
>
> Christopher Bachner
>
> On Mon, Jun 26, 2017 at 8:12 AM, Christopher Bachner <
> b.christopher.92@gmail.com> wrote:
>
> > Hello,
> >
> > I am assuming that if the inertouch message is not showing up in dmesg,
> > then it is working. Is that a correct assumption?
> >
> > Either way I also attached my dmesg.
> >
> > I am not sure, though, why the scroll mode still freezes if I move the my
> > fingers quickly on the touchpad while also using the trackpoint. Is that
> > maybe a future fix and this change is just the foundation for it? Overall
> > the usage of the trackpoint is better now for sure.
> >
> >
> >
> > ---
> > Thanks,
> >
> > Christopher Bachner
> >
> > On Mon, Jun 26, 2017 at 1:26 AM, Benjamin Tissoires <
> > benjamin.tissoires@redhat.com> wrote:
> >
> >> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> >>
> >> ---
> >>
> >> Hi Christopher,
> >>
> >> Could you please test this patch without appending synaptics_intertouch=1
> >> to the boot command line? If this still works, we will have the RMI4 over
> >> SMBus by default for your laptop.
> >>
> >> Cheers,
> >> Benjamin
> >>
> >> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> >> ---
> >> drivers/input/mouse/synaptics.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/input/mouse/synaptics.c
> >> b/drivers/input/mouse/synaptics.c
> >> index f4fbe1a..a8fb26bc 100644
> >> --- a/drivers/input/mouse/synaptics.c
> >> +++ b/drivers/input/mouse/synaptics.c
> >> @@ -173,6 +173,7 @@ static const char * const smbus_pnp_ids[] = {
> >> "LEN0046", /* X250 */
> >> "LEN004a", /* W541 */
> >> "LEN200f", /* T450s */
> >> + "LEN2016", /* T460 20FN */
> >> NULL
> >> };
> >>
> >> --
> >> 2.9.4
> >>
> >>
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: synaptics - switch t460s 20FN to use RMI4 over SMBus
2017-06-26 15:38 ` Benjamin Tissoires
@ 2017-06-27 7:53 ` Benjamin Tissoires
0 siblings, 0 replies; 3+ messages in thread
From: Benjamin Tissoires @ 2017-06-27 7:53 UTC (permalink / raw)
To: Christopher Bachner; +Cc: Dmitry Torokhov, linux-input, linux-kernel
On Jun 26 2017 or thereabouts, Benjamin Tissoires wrote:
> On Jun 26 2017 or thereabouts, Christopher Bachner wrote:
> > Hello,
> >
> > I am assuming that if the inertouch message is not showing up in dmesg,
> > then it is working. Is that a correct assumption?
> >
> > Either way I also attached my dmesg.
> >
> > I am not sure, though, why the scroll mode still freezes if I move the my
> > fingers quickly on the touchpad while also using the trackpoint. Is that
> > maybe a future fix and this change is just the foundation for it? Overall
> > the usage of the trackpoint is better now for sure.
>
> Sadly, you are also hit by:
> [ 6.355378] i801_smbus 0000:00:1f.4: BIOS is accessing SMBus registers
> [ 6.355380] i801_smbus 0000:00:1f.4: Driver SMBus register access inhibited
>
> Which disables entirely the RMI4 over SMBus module. And then we can not
> probe for it, meaning you are stuck with the PS/2 crappy mode.
>
> We are aware of this bug and we'll try to fix that. I think the test you
> provides are valid (the patch works as expected), but a different bug
> prevents rmi-smbus to fully initialize the touchpad :(
Could you try applying Lyude's patch: http://patchwork.ozlabs.org/patch/780865/
(on top of mine, of course).
In the dmesg, you should see a Synaptics TMXXXX device appearing after
trying to set up the SMBus companion.
Cheers,
Benjamin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-27 7:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CAE4xfVLxhF29jLoFWwa4o6_0G_5VMQ8YN1BVP4=8+Y3u_BERPw@mail.gmail.com>
2017-06-26 8:26 ` [PATCH] Input: synaptics - switch t460s 20FN to use RMI4 over SMBus Benjamin Tissoires
[not found] ` <CAE4xfV+Z8Yq=5rGP7H5CcWYfJrNLDPVjgqFOb_ebk0QOYat7Hw@mail.gmail.com>
[not found] ` <CAE4xfV+ygZ5Z9VsFdzmkQQgZZyH79zM4Jr2PHS2s0b9NYG7fqQ@mail.gmail.com>
2017-06-26 15:38 ` Benjamin Tissoires
2017-06-27 7:53 ` Benjamin Tissoires
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).