From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Tejun Heo <tj@kernel.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] pata_imx: print error message on platform_get_irq failure
Date: Fri, 30 Jun 2017 16:47:37 -0500 [thread overview]
Message-ID: <20170630164737.Horde.XkAFPlkZTYgdXBu7_MH6YNz@gator4166.hostgator.com> (raw)
In-Reply-To: <d0a70345-1d28-2218-098f-bdd700530f10@cogentembedded.com>
Quoting Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>:
> On 07/01/2017 12:30 AM, Gustavo A. R. Silva wrote:
>
>> Print error message on platform_get_irq failure before return.
>>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>> ---
>> Changes in v2:
>> Print the return value of platform_get_irq on failure.
>>
>> drivers/ata/pata_imx.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/ata/pata_imx.c b/drivers/ata/pata_imx.c
>> index d4caa23..66fb1ab 100644
>> --- a/drivers/ata/pata_imx.c
>> +++ b/drivers/ata/pata_imx.c
>> @@ -132,9 +132,10 @@ static int pata_imx_probe(struct platform_device *pdev)
>> int ret;
>>
>> irq = platform_get_irq(pdev, 0);
>> - if (irq < 0)
>> + if (irq < 0) {
>> + dev_err(&pdev->dev, "failed to get IRQ: %d\n", irq);
>> return irq;
>> -
>> + }
>
> Removing empty line here doesn't seem a good idea...
>
Oh yeah, I agree.
I'll send v3 shortly.
Thanks!
--
Gustavo A. R. Silva
next prev parent reply other threads:[~2017-06-30 21:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 5:29 [PATCH] pata_imx: print error message on platform_get_irq failure Gustavo A. R. Silva
2017-06-30 21:30 ` [PATCH v2] " Gustavo A. R. Silva
2017-06-30 21:37 ` Sergei Shtylyov
2017-06-30 21:47 ` Gustavo A. R. Silva [this message]
2017-06-30 22:03 ` [PATCH v3] " Gustavo A. R. Silva
2017-07-01 9:00 ` [PATCH v2] " Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170630164737.Horde.XkAFPlkZTYgdXBu7_MH6YNz@gator4166.hostgator.com \
--to=garsilva@embeddedor.com \
--cc=b.zolnierkie@samsung.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).