From: Vladimir Zapolskiy <vz@mleia.com>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Tejun Heo <tj@kernel.org>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] pata_imx: print error message on platform_get_irq failure
Date: Sat, 1 Jul 2017 12:00:06 +0300 [thread overview]
Message-ID: <ed8aba46-7cfc-a4e0-7eba-630519e788ad@mleia.com> (raw)
In-Reply-To: <20170630213056.GA12695@embeddedgus>
Hello Gustavo,
On 07/01/2017 12:30 AM, Gustavo A. R. Silva wrote:
> Print error message on platform_get_irq failure before return.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> Changes in v2:
> Print the return value of platform_get_irq on failure.
>
> drivers/ata/pata_imx.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ata/pata_imx.c b/drivers/ata/pata_imx.c
> index d4caa23..66fb1ab 100644
> --- a/drivers/ata/pata_imx.c
> +++ b/drivers/ata/pata_imx.c
> @@ -132,9 +132,10 @@ static int pata_imx_probe(struct platform_device *pdev)
> int ret;
>
> irq = platform_get_irq(pdev, 0);
> - if (irq < 0)
> + if (irq < 0) {
> + dev_err(&pdev->dev, "failed to get IRQ: %d\n", irq);
> return irq;
> -
> + }
> priv = devm_kzalloc(&pdev->dev,
> sizeof(struct pata_imx_priv), GFP_KERNEL);
> if (!priv)
>
this patch is wrong, I've explained why at https://lkml.org/lkml/2017/6/30/144
Please handle -EPROBE_DEFER case, when your change adds the second (redundant)
error level message printed to the kernel log.
--
With best wishes,
Vladimir
prev parent reply other threads:[~2017-07-01 9:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 5:29 [PATCH] pata_imx: print error message on platform_get_irq failure Gustavo A. R. Silva
2017-06-30 21:30 ` [PATCH v2] " Gustavo A. R. Silva
2017-06-30 21:37 ` Sergei Shtylyov
2017-06-30 21:47 ` Gustavo A. R. Silva
2017-06-30 22:03 ` [PATCH v3] " Gustavo A. R. Silva
2017-07-01 9:00 ` Vladimir Zapolskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed8aba46-7cfc-a4e0-7eba-630519e788ad@mleia.com \
--to=vz@mleia.com \
--cc=b.zolnierkie@samsung.com \
--cc=garsilva@embeddedor.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).