* [RESEND PATCH] fs: add RWF_APPEND
@ 2017-09-29 12:07 Jürg Billeter
2017-10-01 0:31 ` Goldwyn Rodrigues
2017-10-01 8:20 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Jürg Billeter @ 2017-09-29 12:07 UTC (permalink / raw)
To: Al Viro; +Cc: linux-fsdevel, linux-kernel, Jürg Billeter
This is the per-I/O equivalent of O_APPEND to support atomic append
operations on any open file.
If a file is opened with O_APPEND, pwrite() ignores the offset and
always appends data to the end of the file. RWF_APPEND enables atomic
append and pwrite() with offset on a single file descriptor.
Signed-off-by: Jürg Billeter <j@bitron.ch>
---
include/linux/fs.h | 2 ++
include/uapi/linux/fs.h | 6 +++++-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 339e73742e73..fee24eae7523 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -3204,6 +3204,8 @@ static inline int kiocb_set_rw_flags(struct kiocb *ki, rwf_t flags)
ki->ki_flags |= IOCB_DSYNC;
if (flags & RWF_SYNC)
ki->ki_flags |= (IOCB_DSYNC | IOCB_SYNC);
+ if (flags & RWF_APPEND)
+ ki->ki_flags |= IOCB_APPEND;
return 0;
}
diff --git a/include/uapi/linux/fs.h b/include/uapi/linux/fs.h
index 56235dddea7d..ac145430bcd8 100644
--- a/include/uapi/linux/fs.h
+++ b/include/uapi/linux/fs.h
@@ -376,7 +376,11 @@ typedef int __bitwise __kernel_rwf_t;
/* per-IO, return -EAGAIN if operation would block */
#define RWF_NOWAIT ((__force __kernel_rwf_t)0x00000008)
+/* per-IO O_APPEND */
+#define RWF_APPEND ((__force __kernel_rwf_t)0x00000010)
+
/* mask of flags supported by the kernel */
-#define RWF_SUPPORTED (RWF_HIPRI | RWF_DSYNC | RWF_SYNC | RWF_NOWAIT)
+#define RWF_SUPPORTED (RWF_HIPRI | RWF_DSYNC | RWF_SYNC | RWF_NOWAIT |\
+ RWF_APPEND)
#endif /* _UAPI_LINUX_FS_H */
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RESEND PATCH] fs: add RWF_APPEND
2017-09-29 12:07 [RESEND PATCH] fs: add RWF_APPEND Jürg Billeter
@ 2017-10-01 0:31 ` Goldwyn Rodrigues
2017-10-01 8:20 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Goldwyn Rodrigues @ 2017-10-01 0:31 UTC (permalink / raw)
To: Jürg Billeter, Al Viro; +Cc: linux-fsdevel, linux-kernel
On 09/29/2017 07:07 AM, Jürg Billeter wrote:
> This is the per-I/O equivalent of O_APPEND to support atomic append
> operations on any open file.
>
> If a file is opened with O_APPEND, pwrite() ignores the offset and
> always appends data to the end of the file. RWF_APPEND enables atomic
> append and pwrite() with offset on a single file descriptor.
>
I think similarly we can introduce RWF_DIRECT, though I am not sure if
users would want to mix buffered writes and direct writes.
Reviewed-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
> Signed-off-by: Jürg Billeter <j@bitron.ch>
> ---
> include/linux/fs.h | 2 ++
> include/uapi/linux/fs.h | 6 +++++-
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index 339e73742e73..fee24eae7523 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -3204,6 +3204,8 @@ static inline int kiocb_set_rw_flags(struct kiocb *ki, rwf_t flags)
> ki->ki_flags |= IOCB_DSYNC;
> if (flags & RWF_SYNC)
> ki->ki_flags |= (IOCB_DSYNC | IOCB_SYNC);
> + if (flags & RWF_APPEND)
> + ki->ki_flags |= IOCB_APPEND;
> return 0;
> }
>
> diff --git a/include/uapi/linux/fs.h b/include/uapi/linux/fs.h
> index 56235dddea7d..ac145430bcd8 100644
> --- a/include/uapi/linux/fs.h
> +++ b/include/uapi/linux/fs.h
> @@ -376,7 +376,11 @@ typedef int __bitwise __kernel_rwf_t;
> /* per-IO, return -EAGAIN if operation would block */
> #define RWF_NOWAIT ((__force __kernel_rwf_t)0x00000008)
>
> +/* per-IO O_APPEND */
> +#define RWF_APPEND ((__force __kernel_rwf_t)0x00000010)
> +
> /* mask of flags supported by the kernel */
> -#define RWF_SUPPORTED (RWF_HIPRI | RWF_DSYNC | RWF_SYNC | RWF_NOWAIT)
> +#define RWF_SUPPORTED (RWF_HIPRI | RWF_DSYNC | RWF_SYNC | RWF_NOWAIT |\
> + RWF_APPEND)
>
> #endif /* _UAPI_LINUX_FS_H */
>
--
Goldwyn
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RESEND PATCH] fs: add RWF_APPEND
2017-09-29 12:07 [RESEND PATCH] fs: add RWF_APPEND Jürg Billeter
2017-10-01 0:31 ` Goldwyn Rodrigues
@ 2017-10-01 8:20 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2017-10-01 8:20 UTC (permalink / raw)
To: Jürg Billeter; +Cc: Al Viro, linux-fsdevel, linux-kernel
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-01 8:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-29 12:07 [RESEND PATCH] fs: add RWF_APPEND Jürg Billeter
2017-10-01 0:31 ` Goldwyn Rodrigues
2017-10-01 8:20 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).