* [PATCH] usb: gadget: udc: renesas_usb3: make const array max_packet_array static
@ 2017-11-02 15:53 Colin King
2017-11-06 9:34 ` Yoshihiro Shimoda
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-11-02 15:53 UTC (permalink / raw)
To: Felipe Balbi, Greg Kroah-Hartman, Yoshihiro Shimoda,
Geert Uytterhoeven, Kazuya Mizuguchi, linux-usb
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Don't populate the const array max_packet_array on the stack, instead make
it static. Makes the object code smaller by over 90 bytes:
Before:
text data bss dec hex filename
34337 5612 128 40077 9c8d renesas_usb3.o
After:
text data bss dec hex filename
34149 5708 128 39985 9c31 renesas_usb3.o
(gcc version 7.2.0 x86_64)
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/usb/gadget/udc/renesas_usb3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/renesas_usb3.c b/drivers/usb/gadget/udc/renesas_usb3.c
index ed84f5158a38..cb461b8f4509 100644
--- a/drivers/usb/gadget/udc/renesas_usb3.c
+++ b/drivers/usb/gadget/udc/renesas_usb3.c
@@ -2058,7 +2058,7 @@ static u32 usb3_calc_rammap_val(struct renesas_usb3_ep *usb3_ep,
const struct usb_endpoint_descriptor *desc)
{
int i;
- const u32 max_packet_array[] = {8, 16, 32, 64, 512};
+ static const u32 max_packet_array[] = {8, 16, 32, 64, 512};
u32 mpkt = PN_RAMMAP_MPKT(1024);
for (i = 0; i < ARRAY_SIZE(max_packet_array); i++) {
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] usb: gadget: udc: renesas_usb3: make const array max_packet_array static
2017-11-02 15:53 [PATCH] usb: gadget: udc: renesas_usb3: make const array max_packet_array static Colin King
@ 2017-11-06 9:34 ` Yoshihiro Shimoda
0 siblings, 0 replies; 2+ messages in thread
From: Yoshihiro Shimoda @ 2017-11-06 9:34 UTC (permalink / raw)
To: Colin King, Felipe Balbi, Greg Kroah-Hartman, Geert Uytterhoeven,
KAZUYA MIZUGUCHI, linux-usb
Cc: kernel-janitors, linux-kernel
Hi Colin,
> From: Colin King, Sent: Friday, November 3, 2017 12:53 AM
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the const array max_packet_array on the stack, instead make
> it static. Makes the object code smaller by over 90 bytes:
>
> Before:
> text data bss dec hex filename
> 34337 5612 128 40077 9c8d renesas_usb3.o
>
> After:
> text data bss dec hex filename
> 34149 5708 128 39985 9c31 renesas_usb3.o
>
> (gcc version 7.2.0 x86_64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thank you for the patch!
Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Best regards,
Yoshihiro Shimoda
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-06 9:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-02 15:53 [PATCH] usb: gadget: udc: renesas_usb3: make const array max_packet_array static Colin King
2017-11-06 9:34 ` Yoshihiro Shimoda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).