* [PATCH] pinctrl: samsung/s3c24xx: add CONFIG_OF dependency
@ 2017-11-07 14:12 Arnd Bergmann
2017-11-10 10:40 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2017-11-07 14:12 UTC (permalink / raw)
To: Tomasz Figa, Krzysztof Kozlowski, Sylwester Nawrocki, Linus Walleij
Cc: Arnd Bergmann, Alim Akhtar, linux-arm-kernel, linux-samsung-soc,
linux-gpio, linux-kernel
The driver fails to build without CONFIG_OF:
drivers/pinctrl/samsung/pinctrl-samsung.c: In function 'samsung_gpiolib_register':
drivers/pinctrl/samsung/pinctrl-samsung.c:936:5: error: 'struct gpio_chip' has no member named 'of_node'
This configuration is now possible since we can now select the
PINCTRL subsystem on S3C24xx machines other than the device tree
based ones.
Fixes: d219b924611a ("pinctrl: change Kconfig PINCTRL variable to a menuconfig")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/pinctrl/samsung/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/samsung/Kconfig b/drivers/pinctrl/samsung/Kconfig
index 0357f9701eb9..ecfb90059eeb 100644
--- a/drivers/pinctrl/samsung/Kconfig
+++ b/drivers/pinctrl/samsung/Kconfig
@@ -29,7 +29,7 @@ config PINCTRL_EXYNOS5440
config PINCTRL_S3C24XX
bool "Samsung S3C24XX SoC pinctrl driver"
- depends on ARCH_S3C24XX
+ depends on ARCH_S3C24XX && OF
select PINCTRL_SAMSUNG
config PINCTRL_S3C64XX
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: samsung/s3c24xx: add CONFIG_OF dependency
2017-11-07 14:12 [PATCH] pinctrl: samsung/s3c24xx: add CONFIG_OF dependency Arnd Bergmann
@ 2017-11-10 10:40 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2017-11-10 10:40 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Tomasz Figa, Krzysztof Kozlowski, Sylwester Nawrocki,
Alim Akhtar, linux-arm-kernel, linux-samsung-soc, linux-gpio,
linux-kernel
On Tue, Nov 7, 2017 at 3:12 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> The driver fails to build without CONFIG_OF:
>
> drivers/pinctrl/samsung/pinctrl-samsung.c: In function 'samsung_gpiolib_register':
> drivers/pinctrl/samsung/pinctrl-samsung.c:936:5: error: 'struct gpio_chip' has no member named 'of_node'
>
> This configuration is now possible since we can now select the
> PINCTRL subsystem on S3C24xx machines other than the device tree
> based ones.
>
> Fixes: d219b924611a ("pinctrl: change Kconfig PINCTRL variable to a menuconfig")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-10 10:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-07 14:12 [PATCH] pinctrl: samsung/s3c24xx: add CONFIG_OF dependency Arnd Bergmann
2017-11-10 10:40 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).