* [PATCH] media: et8ek8: select V4L2_FWNODE
@ 2017-11-13 13:56 Arnd Bergmann
2017-11-13 15:19 ` Sebastian Reichel
2017-11-14 10:50 ` Pavel Machek
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2017-11-13 13:56 UTC (permalink / raw)
To: Pavel Machek, Sakari Ailus, Mauro Carvalho Chehab
Cc: Arnd Bergmann, Ivaylo Dimitrov, linux-media, linux-kernel
v4l2_async_register_subdev_sensor_common() is only provided when
CONFIG_V4L2_FWNODE is enabled, otherwise we get a link failure:
drivers/media/i2c/et8ek8/et8ek8_driver.o: In function `et8ek8_probe':
et8ek8_driver.c:(.text+0x884): undefined reference to `v4l2_async_register_subdev_sensor_common'
This adds a Kconfig 'select' statement like all the other users of
this interface have.
Fixes: d8932f38c10f ("media: et8ek8: Add support for flash and lens devices")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/media/i2c/et8ek8/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/et8ek8/Kconfig b/drivers/media/i2c/et8ek8/Kconfig
index 14399365ad7f..9fe409e95666 100644
--- a/drivers/media/i2c/et8ek8/Kconfig
+++ b/drivers/media/i2c/et8ek8/Kconfig
@@ -1,6 +1,7 @@
config VIDEO_ET8EK8
tristate "ET8EK8 camera sensor support"
depends on I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API
+ select V4L2_FWNODE
---help---
This is a driver for the Toshiba ET8EK8 5 MP camera sensor.
It is used for example in Nokia N900 (RX-51).
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] media: et8ek8: select V4L2_FWNODE
2017-11-13 13:56 [PATCH] media: et8ek8: select V4L2_FWNODE Arnd Bergmann
@ 2017-11-13 15:19 ` Sebastian Reichel
2017-11-14 10:50 ` Pavel Machek
1 sibling, 0 replies; 3+ messages in thread
From: Sebastian Reichel @ 2017-11-13 15:19 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Pavel Machek, Sakari Ailus, Mauro Carvalho Chehab,
Ivaylo Dimitrov, linux-media, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1329 bytes --]
Hi,
On Mon, Nov 13, 2017 at 02:56:45PM +0100, Arnd Bergmann wrote:
> v4l2_async_register_subdev_sensor_common() is only provided when
> CONFIG_V4L2_FWNODE is enabled, otherwise we get a link failure:
>
> drivers/media/i2c/et8ek8/et8ek8_driver.o: In function `et8ek8_probe':
> et8ek8_driver.c:(.text+0x884): undefined reference to `v4l2_async_register_subdev_sensor_common'
>
> This adds a Kconfig 'select' statement like all the other users of
> this interface have.
>
> Fixes: d8932f38c10f ("media: et8ek8: Add support for flash and lens devices")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
-- Sebastian
> drivers/media/i2c/et8ek8/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/i2c/et8ek8/Kconfig b/drivers/media/i2c/et8ek8/Kconfig
> index 14399365ad7f..9fe409e95666 100644
> --- a/drivers/media/i2c/et8ek8/Kconfig
> +++ b/drivers/media/i2c/et8ek8/Kconfig
> @@ -1,6 +1,7 @@
> config VIDEO_ET8EK8
> tristate "ET8EK8 camera sensor support"
> depends on I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API
> + select V4L2_FWNODE
> ---help---
> This is a driver for the Toshiba ET8EK8 5 MP camera sensor.
> It is used for example in Nokia N900 (RX-51).
> --
> 2.9.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: et8ek8: select V4L2_FWNODE
2017-11-13 13:56 [PATCH] media: et8ek8: select V4L2_FWNODE Arnd Bergmann
2017-11-13 15:19 ` Sebastian Reichel
@ 2017-11-14 10:50 ` Pavel Machek
1 sibling, 0 replies; 3+ messages in thread
From: Pavel Machek @ 2017-11-14 10:50 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Sakari Ailus, Mauro Carvalho Chehab, Ivaylo Dimitrov,
linux-media, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 811 bytes --]
On Mon 2017-11-13 14:56:45, Arnd Bergmann wrote:
> v4l2_async_register_subdev_sensor_common() is only provided when
> CONFIG_V4L2_FWNODE is enabled, otherwise we get a link failure:
>
> drivers/media/i2c/et8ek8/et8ek8_driver.o: In function `et8ek8_probe':
> et8ek8_driver.c:(.text+0x884): undefined reference to `v4l2_async_register_subdev_sensor_common'
>
> This adds a Kconfig 'select' statement like all the other users of
> this interface have.
>
> Fixes: d8932f38c10f ("media: et8ek8: Add support for flash and lens devices")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Pavel Machek <pavel@ucw.cz>
Thanks!
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-14 10:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-13 13:56 [PATCH] media: et8ek8: select V4L2_FWNODE Arnd Bergmann
2017-11-13 15:19 ` Sebastian Reichel
2017-11-14 10:50 ` Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).