* [PATCH] misc: vexpress: Use PTR_ERR_OR_ZERO()
@ 2017-11-28 15:20 Vasyl Gomonovych
2017-11-28 15:53 ` Liviu Dudau
0 siblings, 1 reply; 2+ messages in thread
From: Vasyl Gomonovych @ 2017-11-28 15:20 UTC (permalink / raw)
To: arnd, gregkh, liviu.dudau, sudeep.holla, lorenzo.pieralisi,
linux-arm-kernel
Cc: linux-kernel, gomonovych
Fix ptr_ret.cocci warnings:
drivers/misc/vexpress-syscfg.c:273:1-3: WARNING: PTR_ERR_OR_ZERO can be used
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: scripts/coccinelle/api/ptr_ret.cocci
Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
---
drivers/misc/vexpress-syscfg.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/misc/vexpress-syscfg.c b/drivers/misc/vexpress-syscfg.c
index 2cde80c7bb93..9eea30f54fd6 100644
--- a/drivers/misc/vexpress-syscfg.c
+++ b/drivers/misc/vexpress-syscfg.c
@@ -270,10 +270,8 @@ static int vexpress_syscfg_probe(struct platform_device *pdev)
/* Must use dev.parent (MFD), as that's where DT phandle points at... */
bridge = vexpress_config_bridge_register(pdev->dev.parent,
&vexpress_syscfg_bridge_ops, syscfg);
- if (IS_ERR(bridge))
- return PTR_ERR(bridge);
- return 0;
+ return PTR_ERR_OR_ZERO(bridge);
}
static const struct platform_device_id vexpress_syscfg_id_table[] = {
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] misc: vexpress: Use PTR_ERR_OR_ZERO()
2017-11-28 15:20 [PATCH] misc: vexpress: Use PTR_ERR_OR_ZERO() Vasyl Gomonovych
@ 2017-11-28 15:53 ` Liviu Dudau
0 siblings, 0 replies; 2+ messages in thread
From: Liviu Dudau @ 2017-11-28 15:53 UTC (permalink / raw)
To: Vasyl Gomonovych
Cc: arnd, gregkh, sudeep.holla, lorenzo.pieralisi, linux-arm-kernel,
linux-kernel
On Tue, Nov 28, 2017 at 04:20:43PM +0100, Vasyl Gomonovych wrote:
> Fix ptr_ret.cocci warnings:
> drivers/misc/vexpress-syscfg.c:273:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
Acked-by: Liviu Dudau <liviu.dudau@arm.com>
> ---
> drivers/misc/vexpress-syscfg.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/misc/vexpress-syscfg.c b/drivers/misc/vexpress-syscfg.c
> index 2cde80c7bb93..9eea30f54fd6 100644
> --- a/drivers/misc/vexpress-syscfg.c
> +++ b/drivers/misc/vexpress-syscfg.c
> @@ -270,10 +270,8 @@ static int vexpress_syscfg_probe(struct platform_device *pdev)
> /* Must use dev.parent (MFD), as that's where DT phandle points at... */
> bridge = vexpress_config_bridge_register(pdev->dev.parent,
> &vexpress_syscfg_bridge_ops, syscfg);
> - if (IS_ERR(bridge))
> - return PTR_ERR(bridge);
>
> - return 0;
> + return PTR_ERR_OR_ZERO(bridge);
> }
>
> static const struct platform_device_id vexpress_syscfg_id_table[] = {
> --
> 1.9.1
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-28 15:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-28 15:20 [PATCH] misc: vexpress: Use PTR_ERR_OR_ZERO() Vasyl Gomonovych
2017-11-28 15:53 ` Liviu Dudau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).