* [PATCH] net: ethernet: xilinx: Mark XILINX_LL_TEMAC broken on 64-bit
@ 2017-11-29 10:01 Geert Uytterhoeven
2017-11-29 11:51 ` Michal Simek
2017-11-29 14:44 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2017-11-29 10:01 UTC (permalink / raw)
To: Michal Simek, David S . Miller
Cc: Arnd Bergmann, netdev, linuxppc-dev, linux-arm-kernel,
linux-kernel, Geert Uytterhoeven
On 64-bit (e.g. powerpc64/allmodconfig):
drivers/net/ethernet/xilinx/ll_temac_main.c: In function 'temac_start_xmit_done':
drivers/net/ethernet/xilinx/ll_temac_main.c:633:22: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
dev_kfree_skb_irq((struct sk_buff *)cur_p->app4);
^
cdmac_bd.app4 is u32, so it is too small to hold a kernel pointer.
Note that several other fields in struct cdmac_bd are also too small to
hold physical addresses on 64-bit platforms.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/net/ethernet/xilinx/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/xilinx/Kconfig b/drivers/net/ethernet/xilinx/Kconfig
index 6d68c8a8f4f2ac7f..da4ec575ccf9ba4a 100644
--- a/drivers/net/ethernet/xilinx/Kconfig
+++ b/drivers/net/ethernet/xilinx/Kconfig
@@ -34,6 +34,7 @@ config XILINX_AXI_EMAC
config XILINX_LL_TEMAC
tristate "Xilinx LL TEMAC (LocalLink Tri-mode Ethernet MAC) driver"
depends on (PPC || MICROBLAZE)
+ depends on !64BIT || BROKEN
select PHYLIB
---help---
This driver supports the Xilinx 10/100/1000 LocalLink TEMAC
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: ethernet: xilinx: Mark XILINX_LL_TEMAC broken on 64-bit
2017-11-29 10:01 [PATCH] net: ethernet: xilinx: Mark XILINX_LL_TEMAC broken on 64-bit Geert Uytterhoeven
@ 2017-11-29 11:51 ` Michal Simek
2017-11-29 14:44 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Michal Simek @ 2017-11-29 11:51 UTC (permalink / raw)
To: Geert Uytterhoeven, Michal Simek, David S . Miller
Cc: Arnd Bergmann, netdev, linuxppc-dev, linux-arm-kernel, linux-kernel
On 29.11.2017 11:01, Geert Uytterhoeven wrote:
> On 64-bit (e.g. powerpc64/allmodconfig):
>
> drivers/net/ethernet/xilinx/ll_temac_main.c: In function 'temac_start_xmit_done':
> drivers/net/ethernet/xilinx/ll_temac_main.c:633:22: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> dev_kfree_skb_irq((struct sk_buff *)cur_p->app4);
> ^
>
> cdmac_bd.app4 is u32, so it is too small to hold a kernel pointer.
>
> Note that several other fields in struct cdmac_bd are also too small to
> hold physical addresses on 64-bit platforms.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/net/ethernet/xilinx/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/xilinx/Kconfig b/drivers/net/ethernet/xilinx/Kconfig
> index 6d68c8a8f4f2ac7f..da4ec575ccf9ba4a 100644
> --- a/drivers/net/ethernet/xilinx/Kconfig
> +++ b/drivers/net/ethernet/xilinx/Kconfig
> @@ -34,6 +34,7 @@ config XILINX_AXI_EMAC
> config XILINX_LL_TEMAC
> tristate "Xilinx LL TEMAC (LocalLink Tri-mode Ethernet MAC) driver"
> depends on (PPC || MICROBLAZE)
> + depends on !64BIT || BROKEN
> select PHYLIB
> ---help---
> This driver supports the Xilinx 10/100/1000 LocalLink TEMAC
>
Yes. This IP is available only on big endian 32bit systems.
Thanks,
Michal
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: ethernet: xilinx: Mark XILINX_LL_TEMAC broken on 64-bit
2017-11-29 10:01 [PATCH] net: ethernet: xilinx: Mark XILINX_LL_TEMAC broken on 64-bit Geert Uytterhoeven
2017-11-29 11:51 ` Michal Simek
@ 2017-11-29 14:44 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-11-29 14:44 UTC (permalink / raw)
To: geert+renesas
Cc: michal.simek, arnd, netdev, linuxppc-dev, linux-arm-kernel, linux-kernel
From: Geert Uytterhoeven <geert+renesas@glider.be>
Date: Wed, 29 Nov 2017 11:01:09 +0100
> On 64-bit (e.g. powerpc64/allmodconfig):
>
> drivers/net/ethernet/xilinx/ll_temac_main.c: In function 'temac_start_xmit_done':
> drivers/net/ethernet/xilinx/ll_temac_main.c:633:22: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> dev_kfree_skb_irq((struct sk_buff *)cur_p->app4);
> ^
>
> cdmac_bd.app4 is u32, so it is too small to hold a kernel pointer.
>
> Note that several other fields in struct cdmac_bd are also too small to
> hold physical addresses on 64-bit platforms.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Yeah, I can't see much value in implementing a hash table converting between
32-bit cookies and 64-bit points just for this if it'll never be actually
used.
Applied, thanks Geert.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-29 14:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-29 10:01 [PATCH] net: ethernet: xilinx: Mark XILINX_LL_TEMAC broken on 64-bit Geert Uytterhoeven
2017-11-29 11:51 ` Michal Simek
2017-11-29 14:44 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).