* [PATCH] net/mlx5: remove some extraneous spaces in indentations
@ 2018-04-09 12:43 Colin King
2018-04-10 23:22 ` Jason Gunthorpe
2018-04-12 22:39 ` Saeed Mahameed
0 siblings, 2 replies; 6+ messages in thread
From: Colin King @ 2018-04-09 12:43 UTC (permalink / raw)
To: Saeed Mahameed, Matan Barak, Leon Romanovsky, netdev, linux-rdma
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There are several lines where there is an extraneous space causing
indentation misalignment. Remove them.
Cleans up Cocconelle warnings:
./drivers/net/ethernet/mellanox/mlx5/core/qp.c:409:3-18: code aligned
with following code on line 410
./drivers/net/ethernet/mellanox/mlx5/core/qp.c:415:3-18: code aligned
with following code on line 416
./drivers/net/ethernet/mellanox/mlx5/core/qp.c:421:3-18: code aligned
with following code on line 422
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/mellanox/mlx5/core/qp.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/qp.c b/drivers/net/ethernet/mellanox/mlx5/core/qp.c
index 02d6c5b5d502..4ca07bfb6b14 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/qp.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/qp.c
@@ -407,21 +407,21 @@ static int modify_qp_mbox_alloc(struct mlx5_core_dev *dev, u16 opcode, int qpn,
case MLX5_CMD_OP_RST2INIT_QP:
if (MBOX_ALLOC(mbox, rst2init_qp))
return -ENOMEM;
- MOD_QP_IN_SET_QPC(rst2init_qp, mbox->in, opcode, qpn,
- opt_param_mask, qpc);
- break;
+ MOD_QP_IN_SET_QPC(rst2init_qp, mbox->in, opcode, qpn,
+ opt_param_mask, qpc);
+ break;
case MLX5_CMD_OP_INIT2RTR_QP:
if (MBOX_ALLOC(mbox, init2rtr_qp))
return -ENOMEM;
- MOD_QP_IN_SET_QPC(init2rtr_qp, mbox->in, opcode, qpn,
- opt_param_mask, qpc);
- break;
+ MOD_QP_IN_SET_QPC(init2rtr_qp, mbox->in, opcode, qpn,
+ opt_param_mask, qpc);
+ break;
case MLX5_CMD_OP_RTR2RTS_QP:
if (MBOX_ALLOC(mbox, rtr2rts_qp))
return -ENOMEM;
- MOD_QP_IN_SET_QPC(rtr2rts_qp, mbox->in, opcode, qpn,
- opt_param_mask, qpc);
- break;
+ MOD_QP_IN_SET_QPC(rtr2rts_qp, mbox->in, opcode, qpn,
+ opt_param_mask, qpc);
+ break;
case MLX5_CMD_OP_RTS2RTS_QP:
if (MBOX_ALLOC(mbox, rts2rts_qp))
return -ENOMEM;
--
2.15.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] net/mlx5: remove some extraneous spaces in indentations
2018-04-09 12:43 [PATCH] net/mlx5: remove some extraneous spaces in indentations Colin King
@ 2018-04-10 23:22 ` Jason Gunthorpe
2018-04-10 23:27 ` Jason Gunthorpe
2018-04-12 22:39 ` Saeed Mahameed
1 sibling, 1 reply; 6+ messages in thread
From: Jason Gunthorpe @ 2018-04-10 23:22 UTC (permalink / raw)
To: Colin Ian King
Cc: Saeed Mahameed, Matan Barak, Leon Romanovsky, netdev, linux-rdma,
kernel-janitors, linux-kernel
On Mon, Apr 09, 2018 at 01:43:36PM +0100, Colin Ian King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There are several lines where there is an extraneous space causing
> indentation misalignment. Remove them.
>
> Cleans up Cocconelle warnings:
>
> ./drivers/net/ethernet/mellanox/mlx5/core/qp.c:409:3-18: code aligned
> with following code on line 410
> ./drivers/net/ethernet/mellanox/mlx5/core/qp.c:415:3-18: code aligned
> with following code on line 416
> ./drivers/net/ethernet/mellanox/mlx5/core/qp.c:421:3-18: code aligned
> with following code on line 422
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/qp.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
applied to for-next thanks
Jason
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net/mlx5: remove some extraneous spaces in indentations
2018-04-10 23:22 ` Jason Gunthorpe
@ 2018-04-10 23:27 ` Jason Gunthorpe
2018-04-11 18:23 ` Saeed Mahameed
0 siblings, 1 reply; 6+ messages in thread
From: Jason Gunthorpe @ 2018-04-10 23:27 UTC (permalink / raw)
To: Colin Ian King
Cc: Saeed Mahameed, Matan Barak, Leon Romanovsky, netdev, linux-rdma,
kernel-janitors, linux-kernel
On Tue, Apr 10, 2018 at 05:22:54PM -0600, Jason Gunthorpe wrote:
> On Mon, Apr 09, 2018 at 01:43:36PM +0100, Colin Ian King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > There are several lines where there is an extraneous space causing
> > indentation misalignment. Remove them.
> >
> > Cleans up Cocconelle warnings:
> >
> > ./drivers/net/ethernet/mellanox/mlx5/core/qp.c:409:3-18: code aligned
> > with following code on line 410
> > ./drivers/net/ethernet/mellanox/mlx5/core/qp.c:415:3-18: code aligned
> > with following code on line 416
> > ./drivers/net/ethernet/mellanox/mlx5/core/qp.c:421:3-18: code aligned
> > with following code on line 422
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > drivers/net/ethernet/mellanox/mlx5/core/qp.c | 18 +++++++++---------
> > 1 file changed, 9 insertions(+), 9 deletions(-)
>
> applied to for-next thanks
Oh wait, this is for netdev, not rdma sorry. Never mind, DaveM should
pick it up.
Jason
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net/mlx5: remove some extraneous spaces in indentations
2018-04-10 23:27 ` Jason Gunthorpe
@ 2018-04-11 18:23 ` Saeed Mahameed
2018-04-11 18:43 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: Saeed Mahameed @ 2018-04-11 18:23 UTC (permalink / raw)
To: colin.king, jgg
Cc: Matan Barak, netdev, linux-rdma, linux-kernel, leon, kernel-janitors
On Tue, 2018-04-10 at 17:27 -0600, Jason Gunthorpe wrote:
> On Tue, Apr 10, 2018 at 05:22:54PM -0600, Jason Gunthorpe wrote:
> > On Mon, Apr 09, 2018 at 01:43:36PM +0100, Colin Ian King wrote:
> > > From: Colin Ian King <colin.king@canonical.com>
> > >
> > > There are several lines where there is an extraneous space
> > > causing
> > > indentation misalignment. Remove them.
> > >
> > > Cleans up Cocconelle warnings:
> > >
> > > ./drivers/net/ethernet/mellanox/mlx5/core/qp.c:409:3-18: code
> > > aligned
> > > with following code on line 410
> > > ./drivers/net/ethernet/mellanox/mlx5/core/qp.c:415:3-18: code
> > > aligned
> > > with following code on line 416
> > > ./drivers/net/ethernet/mellanox/mlx5/core/qp.c:421:3-18: code
> > > aligned
> > > with following code on line 422
> > >
> > > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > > drivers/net/ethernet/mellanox/mlx5/core/qp.c | 18 +++++++++-----
> > > ----
> > > 1 file changed, 9 insertions(+), 9 deletions(-)
> >
> > applied to for-next thanks
>
> Oh wait, this is for netdev, not rdma sorry. Never mind, DaveM should
> pick it up.
>
net-next is currently closed.
Dave, if it is ok with you I would like to apply this into mlx5-next
branch so it won't cause any issues with our next pull requests to rdma
and netdev.
> Jason
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net/mlx5: remove some extraneous spaces in indentations
2018-04-11 18:23 ` Saeed Mahameed
@ 2018-04-11 18:43 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2018-04-11 18:43 UTC (permalink / raw)
To: saeedm
Cc: colin.king, jgg, matanb, netdev, linux-rdma, linux-kernel, leon,
kernel-janitors
From: Saeed Mahameed <saeedm@mellanox.com>
Date: Wed, 11 Apr 2018 18:23:41 +0000
> Dave, if it is ok with you I would like to apply this into mlx5-next
> branch so it won't cause any issues with our next pull requests to rdma
> and netdev.
Ok.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net/mlx5: remove some extraneous spaces in indentations
2018-04-09 12:43 [PATCH] net/mlx5: remove some extraneous spaces in indentations Colin King
2018-04-10 23:22 ` Jason Gunthorpe
@ 2018-04-12 22:39 ` Saeed Mahameed
1 sibling, 0 replies; 6+ messages in thread
From: Saeed Mahameed @ 2018-04-12 22:39 UTC (permalink / raw)
To: colin.king, Matan Barak, linux-rdma, netdev, leon
Cc: linux-kernel, kernel-janitors
On Mon, 2018-04-09 at 13:43 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There are several lines where there is an extraneous space causing
> indentation misalignment. Remove them.
>
> Cleans up Cocconelle warnings:
>
> ./drivers/net/ethernet/mellanox/mlx5/core/qp.c:409:3-18: code aligned
> with following code on line 410
> ./drivers/net/ethernet/mellanox/mlx5/core/qp.c:415:3-18: code aligned
> with following code on line 416
> ./drivers/net/ethernet/mellanox/mlx5/core/qp.c:421:3-18: code aligned
> with following code on line 422
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
Applied to mlx5-next, Thanks Colin!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-04-12 22:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-09 12:43 [PATCH] net/mlx5: remove some extraneous spaces in indentations Colin King
2018-04-10 23:22 ` Jason Gunthorpe
2018-04-10 23:27 ` Jason Gunthorpe
2018-04-11 18:23 ` Saeed Mahameed
2018-04-11 18:43 ` David Miller
2018-04-12 22:39 ` Saeed Mahameed
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).