linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCHv2] objtool: Support HOSTCFLAGS and HOSTLDFLAGS
@ 2018-04-11 20:04 Laura Abbott
  2018-04-12 13:18 ` Josh Poimboeuf
  0 siblings, 1 reply; 2+ messages in thread
From: Laura Abbott @ 2018-04-11 20:04 UTC (permalink / raw)
  To: Josh Poimboeuf, Masahiro Yamada; +Cc: Laura Abbott, linux-kernel, linux-kbuild

It may be useful to compile host programs with different flags (e.g.
hardening). Ensure that objtool picks up the appropriate flags.

Signed-off-by: Laura Abbott <labbott@redhat.com>
---
v2: Drop several flags that are already defined in HOSTCFLAGS
---
 tools/objtool/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/objtool/Makefile b/tools/objtool/Makefile
index e6acc281dd37..7df979ae4573 100644
--- a/tools/objtool/Makefile
+++ b/tools/objtool/Makefile
@@ -31,8 +31,8 @@ INCLUDES := -I$(srctree)/tools/include \
 	    -I$(srctree)/tools/arch/$(HOSTARCH)/include/uapi \
 	    -I$(srctree)/tools/objtool/arch/$(ARCH)/include
 WARNINGS := $(EXTRA_WARNINGS) -Wno-switch-default -Wno-switch-enum -Wno-packed
-CFLAGS   += -Wall -Werror $(WARNINGS) -fomit-frame-pointer -O2 -g $(INCLUDES)
-LDFLAGS  += -lelf $(LIBSUBCMD)
+CFLAGS   += -Werror $(WARNINGS) $(HOSTCFLAGS) -g $(INCLUDES)
+LDFLAGS  += -lelf $(LIBSUBCMD) $(HOSTLDFLAGS)
 
 # Allow old libelf to be used:
 elfshdr := $(shell echo '\#include <libelf.h>' | $(CC) $(CFLAGS) -x c -E - | grep elf_getshdr)
-- 
2.14.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCHv2] objtool: Support HOSTCFLAGS and HOSTLDFLAGS
  2018-04-11 20:04 [PATCHv2] objtool: Support HOSTCFLAGS and HOSTLDFLAGS Laura Abbott
@ 2018-04-12 13:18 ` Josh Poimboeuf
  0 siblings, 0 replies; 2+ messages in thread
From: Josh Poimboeuf @ 2018-04-12 13:18 UTC (permalink / raw)
  To: Laura Abbott; +Cc: Masahiro Yamada, linux-kernel, linux-kbuild

On Wed, Apr 11, 2018 at 01:04:32PM -0700, Laura Abbott wrote:
> It may be useful to compile host programs with different flags (e.g.
> hardening). Ensure that objtool picks up the appropriate flags.
> 
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> ---
> v2: Drop several flags that are already defined in HOSTCFLAGS

Thanks Laura.  Changes to the objtool makefile usually go through the
-tip tree, so I'll run it through some testing and then send it along.

-- 
Josh

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-04-12 13:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-11 20:04 [PATCHv2] objtool: Support HOSTCFLAGS and HOSTLDFLAGS Laura Abbott
2018-04-12 13:18 ` Josh Poimboeuf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).