* [PATCH 1/1] iommu/vt-d: Remove unnecessary WARN_ON()
@ 2018-06-19 2:49 Lu Baolu
2018-07-06 12:18 ` Joerg Roedel
0 siblings, 1 reply; 2+ messages in thread
From: Lu Baolu @ 2018-06-19 2:49 UTC (permalink / raw)
To: Joerg Roedel, David Woodhouse; +Cc: ashok.raj, iommu, linux-kernel, Lu Baolu
When drivers call intel_svm_available() to check whether the
Shared Virtual Memory(SVM) is supported by the IOMMU driver,
they will get a warning in the kernel message if the SVM is
not supported by the hardware.
[ 3.790876] WARNING: CPU: 0 PID: 267 at drivers/iommu/intel-svm.c:334 intel_svm_bind_mm+0x292/0x570
[ 3.790877] Modules linked in: dsa(+) vfio_mdev mdev vfio_iommu_type1 soundcore vfio serio_raw parport_pc ppdev lp parport autofs4 psmouse virtio_net pata_acpi
[ 3.790884] CPU: 0 PID: 267 Comm: systemd-udevd Not tainted 4.15.0+ #358
[ 3.790885] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.11.0-0-g63451fca13-prebuilt.qemu-project.org 04/01/2014
[ 3.790887] RIP: 0010:intel_svm_bind_mm+0x292/0x570
[ 3.790887] RSP: 0000:ffffac72c08a3a70 EFLAGS: 00010246
[ 3.790889] RAX: 0000000000000000 RBX: ffff90447a5160a0 RCX: 0000000000000000
[ 3.790889] RDX: 0000000000000000 RSI: 0000000000000082 RDI: ffff90447fc16550
[ 3.790890] RBP: ffff90447a516000 R08: 0000000000000000 R09: 0000000000000178
[ 3.790891] R10: 0000000000000220 R11: 0000000000aaaaaa R12: 0000000000000000
[ 3.790891] R13: 0000000000000002 R14: ffffac72c08a3b18 R15: ffffac72c08a3eb8
[ 3.790893] FS: 00007fb21e85b8c0(0000) GS:ffff90447fc00000(0000) knlGS:0000000000000000
[ 3.790894] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 3.790894] CR2: 000055c08167d148 CR3: 000000013a6f4000 CR4: 00000000000006f0
[ 3.790903] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 3.790904] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
This is caused by a unnecessary WARN_ON() in intel_svm_bind_mm().
Hence, remove it.
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
---
drivers/iommu/intel-svm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/intel-svm.c b/drivers/iommu/intel-svm.c
index 45f6e58..2cc0aac 100644
--- a/drivers/iommu/intel-svm.c
+++ b/drivers/iommu/intel-svm.c
@@ -309,7 +309,7 @@ int intel_svm_bind_mm(struct device *dev, int *pasid, int flags, struct svm_dev_
int pasid_max;
int ret;
- if (WARN_ON(!iommu || !iommu->pasid_table))
+ if (!iommu || !iommu->pasid_table)
return -EINVAL;
if (dev_is_pci(dev)) {
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] iommu/vt-d: Remove unnecessary WARN_ON()
2018-06-19 2:49 [PATCH 1/1] iommu/vt-d: Remove unnecessary WARN_ON() Lu Baolu
@ 2018-07-06 12:18 ` Joerg Roedel
0 siblings, 0 replies; 2+ messages in thread
From: Joerg Roedel @ 2018-07-06 12:18 UTC (permalink / raw)
To: Lu Baolu; +Cc: David Woodhouse, ashok.raj, iommu, linux-kernel
On Tue, Jun 19, 2018 at 10:49:19AM +0800, Lu Baolu wrote:
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> ---
> drivers/iommu/intel-svm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-06 12:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-19 2:49 [PATCH 1/1] iommu/vt-d: Remove unnecessary WARN_ON() Lu Baolu
2018-07-06 12:18 ` Joerg Roedel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).