linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] [RESEND] powerpc: xmon: use ktime_get_coarse_boottime64
@ 2018-07-11 12:53 Arnd Bergmann
  2018-07-12  6:28 ` Michael Ellerman
  0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2018-07-11 12:53 UTC (permalink / raw)
  To: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman
  Cc: y2038, Arnd Bergmann, Balbir Singh, Nicholas Piggin,
	Vaibhav Jain, Breno Leitao, Mathieu Malaterre, Yisheng Xie,
	linuxppc-dev, linux-kernel

get_monotonic_boottime() is deprecated, and may not be safe to call in
every context, as it has to read a hardware clocksource.

This changes xmon to print the time using ktime_get_coarse_boottime64()
instead, which avoids the old timespec type and the HW access.

Acked-by: Balbir Singh <bsingharora@gmail.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
Originally sent Jun 18, but this hasn't appeared in linux-next yet.

Resending to make sure this is still on the radar. Please apply
to the powerpc git for 4.19
---
 arch/powerpc/xmon/xmon.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
index 47166ad2a669..45e3d0ec1246 100644
--- a/arch/powerpc/xmon/xmon.c
+++ b/arch/powerpc/xmon/xmon.c
@@ -918,13 +918,13 @@ static void remove_cpu_bpts(void)
 static void
 show_uptime(void)
 {
-	struct timespec uptime;
+	struct timespec64 uptime;
 
 	if (setjmp(bus_error_jmp) == 0) {
 		catch_memory_errors = 1;
 		sync();
 
-		get_monotonic_boottime(&uptime);
+		ktime_get_coarse_boottime_ts64(&uptime);
 		printf("Uptime: %lu.%.2lu seconds\n", (unsigned long)uptime.tv_sec,
 			((unsigned long)uptime.tv_nsec / (NSEC_PER_SEC/100)));
 
-- 
2.9.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] [RESEND] powerpc: xmon: use ktime_get_coarse_boottime64
  2018-07-11 12:53 [PATCH] [RESEND] powerpc: xmon: use ktime_get_coarse_boottime64 Arnd Bergmann
@ 2018-07-12  6:28 ` Michael Ellerman
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2018-07-12  6:28 UTC (permalink / raw)
  To: Arnd Bergmann, Benjamin Herrenschmidt, Paul Mackerras
  Cc: y2038, Arnd Bergmann, Balbir Singh, Nicholas Piggin,
	Vaibhav Jain, Breno Leitao, Mathieu Malaterre, Yisheng Xie,
	linuxppc-dev, linux-kernel

Arnd Bergmann <arnd@arndb.de> writes:

> get_monotonic_boottime() is deprecated, and may not be safe to call in
> every context, as it has to read a hardware clocksource.
>
> This changes xmon to print the time using ktime_get_coarse_boottime64()
> instead, which avoids the old timespec type and the HW access.
>
> Acked-by: Balbir Singh <bsingharora@gmail.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> Originally sent Jun 18, but this hasn't appeared in linux-next yet.
>
> Resending to make sure this is still on the radar. Please apply
> to the powerpc git for 4.19

I had applied it but forgot to push.

Should be there today.

cheers

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-07-12  6:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-11 12:53 [PATCH] [RESEND] powerpc: xmon: use ktime_get_coarse_boottime64 Arnd Bergmann
2018-07-12  6:28 ` Michael Ellerman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).