* [PATCH] media: platform: cros-ec-cec: fix dependency on MFD_CROS_EC
@ 2018-07-24 9:35 Arnd Bergmann
2018-08-02 22:58 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2018-07-24 9:35 UTC (permalink / raw)
To: Lee Jones, Mauro Carvalho Chehab, Hans Verkuil
Cc: Arnd Bergmann, Jacob Chen, linux-media, linux-kernel
Without the MFD driver, we run into a link error:
drivers/media/platform/cros-ec-cec/cros-ec-cec.o: In function `cros_ec_cec_transmit':
cros-ec-cec.c:(.text+0x474): undefined reference to `cros_ec_cmd_xfer_status'
drivers/media/platform/cros-ec-cec/cros-ec-cec.o: In function `cros_ec_cec_set_log_addr':
cros-ec-cec.c:(.text+0x60b): undefined reference to `cros_ec_cmd_xfer_status'
drivers/media/platform/cros-ec-cec/cros-ec-cec.o: In function `cros_ec_cec_adap_enable':
cros-ec-cec.c:(.text+0x77d): undefined reference to `cros_ec_cmd_xfer_status'
As we can compile-test all the dependency, the extra '| COMPILE_TEST' is
not needed to get the build coverage, and we can simply turn MFD_CROS_EC
into a hard dependency to make it build in all configurations.
Fixes: cd70de2d356e ("media: platform: Add ChromeOS EC CEC driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/media/platform/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
index 92b182da8e4d..018fcbed82e4 100644
--- a/drivers/media/platform/Kconfig
+++ b/drivers/media/platform/Kconfig
@@ -535,7 +535,7 @@ if CEC_PLATFORM_DRIVERS
config VIDEO_CROS_EC_CEC
tristate "ChromeOS EC CEC driver"
- depends on MFD_CROS_EC || COMPILE_TEST
+ depends on MFD_CROS_EC
select CEC_CORE
select CEC_NOTIFIER
---help---
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] media: platform: cros-ec-cec: fix dependency on MFD_CROS_EC
2018-07-24 9:35 [PATCH] media: platform: cros-ec-cec: fix dependency on MFD_CROS_EC Arnd Bergmann
@ 2018-08-02 22:58 ` Mauro Carvalho Chehab
2018-08-03 6:29 ` Hans Verkuil
0 siblings, 1 reply; 3+ messages in thread
From: Mauro Carvalho Chehab @ 2018-08-02 22:58 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Lee Jones, Mauro Carvalho Chehab, Hans Verkuil, Jacob Chen,
linux-media, linux-kernel
Em Tue, 24 Jul 2018 11:35:59 +0200
Arnd Bergmann <arnd@arndb.de> escreveu:
> Without the MFD driver, we run into a link error:
Weird... I'm not seeing this driver at the media tree... was it merged via
some other tree?
>
> drivers/media/platform/cros-ec-cec/cros-ec-cec.o: In function `cros_ec_cec_transmit':
> cros-ec-cec.c:(.text+0x474): undefined reference to `cros_ec_cmd_xfer_status'
> drivers/media/platform/cros-ec-cec/cros-ec-cec.o: In function `cros_ec_cec_set_log_addr':
> cros-ec-cec.c:(.text+0x60b): undefined reference to `cros_ec_cmd_xfer_status'
> drivers/media/platform/cros-ec-cec/cros-ec-cec.o: In function `cros_ec_cec_adap_enable':
> cros-ec-cec.c:(.text+0x77d): undefined reference to `cros_ec_cmd_xfer_status'
>
> As we can compile-test all the dependency, the extra '| COMPILE_TEST' is
> not needed to get the build coverage, and we can simply turn MFD_CROS_EC
> into a hard dependency to make it build in all configurations.
>
> Fixes: cd70de2d356e ("media: platform: Add ChromeOS EC CEC driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/media/platform/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
> index 92b182da8e4d..018fcbed82e4 100644
> --- a/drivers/media/platform/Kconfig
> +++ b/drivers/media/platform/Kconfig
> @@ -535,7 +535,7 @@ if CEC_PLATFORM_DRIVERS
>
> config VIDEO_CROS_EC_CEC
> tristate "ChromeOS EC CEC driver"
> - depends on MFD_CROS_EC || COMPILE_TEST
> + depends on MFD_CROS_EC
> select CEC_CORE
> select CEC_NOTIFIER
> ---help---
Thanks,
Mauro
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: platform: cros-ec-cec: fix dependency on MFD_CROS_EC
2018-08-02 22:58 ` Mauro Carvalho Chehab
@ 2018-08-03 6:29 ` Hans Verkuil
0 siblings, 0 replies; 3+ messages in thread
From: Hans Verkuil @ 2018-08-03 6:29 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Arnd Bergmann
Cc: Lee Jones, Mauro Carvalho Chehab, Hans Verkuil, Jacob Chen,
linux-media, linux-kernel
On 08/03/2018 12:58 AM, Mauro Carvalho Chehab wrote:
> Em Tue, 24 Jul 2018 11:35:59 +0200
> Arnd Bergmann <arnd@arndb.de> escreveu:
>
>> Without the MFD driver, we run into a link error:
>
> Weird... I'm not seeing this driver at the media tree... was it merged via
> some other tree?
Yes, it's going via the mfd subsystem. This driver touched on the mfd, drm and
media subsystems, in the end it was decided to let the mfd subsystem take this
since it had the most impact on that subsystem.
Regards,
Hans
>
>>
>> drivers/media/platform/cros-ec-cec/cros-ec-cec.o: In function `cros_ec_cec_transmit':
>> cros-ec-cec.c:(.text+0x474): undefined reference to `cros_ec_cmd_xfer_status'
>> drivers/media/platform/cros-ec-cec/cros-ec-cec.o: In function `cros_ec_cec_set_log_addr':
>> cros-ec-cec.c:(.text+0x60b): undefined reference to `cros_ec_cmd_xfer_status'
>> drivers/media/platform/cros-ec-cec/cros-ec-cec.o: In function `cros_ec_cec_adap_enable':
>> cros-ec-cec.c:(.text+0x77d): undefined reference to `cros_ec_cmd_xfer_status'
>>
>> As we can compile-test all the dependency, the extra '| COMPILE_TEST' is
>> not needed to get the build coverage, and we can simply turn MFD_CROS_EC
>> into a hard dependency to make it build in all configurations.
>>
>> Fixes: cd70de2d356e ("media: platform: Add ChromeOS EC CEC driver")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>> drivers/media/platform/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
>> index 92b182da8e4d..018fcbed82e4 100644
>> --- a/drivers/media/platform/Kconfig
>> +++ b/drivers/media/platform/Kconfig
>> @@ -535,7 +535,7 @@ if CEC_PLATFORM_DRIVERS
>>
>> config VIDEO_CROS_EC_CEC
>> tristate "ChromeOS EC CEC driver"
>> - depends on MFD_CROS_EC || COMPILE_TEST
>> + depends on MFD_CROS_EC
>> select CEC_CORE
>> select CEC_NOTIFIER
>> ---help---
>
>
>
> Thanks,
> Mauro
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-03 6:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-24 9:35 [PATCH] media: platform: cros-ec-cec: fix dependency on MFD_CROS_EC Arnd Bergmann
2018-08-02 22:58 ` Mauro Carvalho Chehab
2018-08-03 6:29 ` Hans Verkuil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).