From: Brian Norris <briannorris@chromium.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Wei-Ning Huang <wnhuang@chromium.org>,
Julius Werner <jwerner@chromium.org>,
Samuel Holland <samuel@sholland.org>,
Thierry Escande <thierry.escande@collabora.com>
Subject: Re: [PATCH] firmware: coreboot: Let OF core populate platform device
Date: Mon, 6 Aug 2018 10:38:08 -0700 [thread overview]
Message-ID: <20180806173806.GA26374@ban.mtv.corp.google.com> (raw)
In-Reply-To: <20180806171047.227835-1-swboyd@chromium.org>
On Mon, Aug 06, 2018 at 10:10:47AM -0700, Stephen Boyd wrote:
> Now that the /firmware/coreboot node in DT is populated by the core DT
> platform code with commit 3aa0582fdb82 ("of: platform: populate
> /firmware/ node from of_platform_default_populate_init()") we should and
Does this deserve a 'Fixes' tag?
Fixes: 3aa0582fdb82 ("of: platform: populate /firmware/ node from of_platform_default_populate_init()")
The coreboot-of driver was in 4.12, and it seems to have broken in 4.16,
along with the above patch.
> can remove the platform device creation here. Otherwise, the
> of_platform_device_create() call will fail, the coreboot of driver won't
> be registered, and this driver will never bind. At the same time, we can
> move this driver to use platform device APIs instead of DT specific ones
> and drop the of_node handling that was presumably placed there to hold a
> reference to the DT node created during module init.
>
> Cc: Wei-Ning Huang <wnhuang@chromium.org>
> Cc: Julius Werner <jwerner@chromium.org>
> Cc: Brian Norris <briannorris@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>
> Cc: Samuel Holland <samuel@sholland.org>
> Cc: Thierry Escande <thierry.escande@collabora.com>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
> drivers/firmware/google/coreboot_table-of.c | 39 +++++----------------
> 1 file changed, 9 insertions(+), 30 deletions(-)
next prev parent reply other threads:[~2018-08-06 17:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-06 17:10 [PATCH] firmware: coreboot: Let OF core populate platform device Stephen Boyd
2018-08-06 17:22 ` Sudeep Holla
2018-08-06 17:38 ` Brian Norris [this message]
2018-08-06 18:05 ` Stephen Boyd
2018-08-06 18:29 ` Julius Werner
2018-08-07 21:41 ` Brian Norris
2018-08-08 6:00 ` Stephen Boyd
2018-08-09 17:13 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180806173806.GA26374@ban.mtv.corp.google.com \
--to=briannorris@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=jwerner@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel@sholland.org \
--cc=swboyd@chromium.org \
--cc=thierry.escande@collabora.com \
--cc=wnhuang@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).