From: Brian Norris <briannorris@chromium.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Wei-Ning Huang <wnhuang@chromium.org>,
Julius Werner <jwerner@chromium.org>,
Samuel Holland <samuel@sholland.org>,
Thierry Escande <thierry.escande@collabora.com>
Subject: Re: [PATCH] firmware: coreboot: Let OF core populate platform device
Date: Thu, 9 Aug 2018 10:13:09 -0700 [thread overview]
Message-ID: <20180809171307.GA129285@ban.mtv.corp.google.com> (raw)
In-Reply-To: <153370805099.220756.5343483987100252246@swboyd.mtv.corp.google.com>
On Tue, Aug 07, 2018 at 11:00:50PM -0700, Stephen Boyd wrote:
> Quoting Brian Norris (2018-08-07 14:41:04)
> > On Mon, Aug 06, 2018 at 10:10:47AM -0700, Stephen Boyd wrote:
> > > @@ -44,8 +43,9 @@ static int coreboot_table_of_remove(struct platform_device *pdev)
> > >
> > > static const struct of_device_id coreboot_of_match[] = {
> > > { .compatible = "coreboot" },
> > > - {},
> > > + {}
> >
> > ...and since I had a *real* comment, I'll mention this bit I noticed
> > previously...this diff seems a bit superfluous. I understand we don't
> > really want to extend this list beyond the NULL terminator, but
> > normally, I'd expect we leave it alone.
> >
>
> I was adding MODULE_DEVICE_TABLE nearby. I'll leave the removal here
> unless you really hate the style cleanup.
My ugly and imprecise grepping tells me you're going to have a fun time
enforcing your sense of style, but good luck ;)
$ git grep -n -A 10 'of_device_id.*\[\] = ' | grep '{\s*}$' | wc -l
1020
$ git grep -n -A 10 'of_device_id.*\[\] = ' | grep '{\s*},$' | wc -l
1348
prev parent reply other threads:[~2018-08-09 17:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-06 17:10 [PATCH] firmware: coreboot: Let OF core populate platform device Stephen Boyd
2018-08-06 17:22 ` Sudeep Holla
2018-08-06 17:38 ` Brian Norris
2018-08-06 18:05 ` Stephen Boyd
2018-08-06 18:29 ` Julius Werner
2018-08-07 21:41 ` Brian Norris
2018-08-08 6:00 ` Stephen Boyd
2018-08-09 17:13 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180809171307.GA129285@ban.mtv.corp.google.com \
--to=briannorris@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=jwerner@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel@sholland.org \
--cc=swboyd@chromium.org \
--cc=thierry.escande@collabora.com \
--cc=wnhuang@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).