* [PATCH] staging: rtl8188eu: Removed code valid for 5GHz
@ 2018-08-17 7:47 Bhaskar Singh
2018-08-20 9:50 ` Dan Carpenter
0 siblings, 1 reply; 4+ messages in thread
From: Bhaskar Singh @ 2018-08-17 7:47 UTC (permalink / raw)
To: devel; +Cc: linux-kernel, gregkh, bhaskar.kernel
This patch removed code which are valid for IEEE 802.11a i.e. 5GHz.
This is also mention in the TODO file.
Signed-off-by: Bhaskar Singh <bhaskar.kernel@gmail.com>
---
drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ieee80211.c b/drivers/staging/rtl8188eu/core/rtw_ieee80211.c
index 7d5cbaf50f1c..3ce20f381827 100644
--- a/drivers/staging/rtl8188eu/core/rtw_ieee80211.c
+++ b/drivers/staging/rtl8188eu/core/rtw_ieee80211.c
@@ -100,19 +100,13 @@ bool rtw_is_cckratesonly_included(u8 *rate)
int rtw_check_network_type(unsigned char *rate, int ratelen, int channel)
{
- if (channel > 14) {
- if (rtw_is_cckrates_included(rate))
- return WIRELESS_INVALID;
- else
- return WIRELESS_11A;
- } else { /* could be pure B, pure G, or B/G */
+ /* could be pure B, pure G, or B/G */
if (rtw_is_cckratesonly_included(rate))
return WIRELESS_11B;
else if (rtw_is_cckrates_included(rate))
return WIRELESS_11BG;
else
return WIRELESS_11G;
- }
}
u8 *rtw_set_fixed_ie(void *pbuf, unsigned int len, void *source,
--
2.16.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8188eu: Removed code valid for 5GHz
2018-08-17 7:47 [PATCH] staging: rtl8188eu: Removed code valid for 5GHz Bhaskar Singh
@ 2018-08-20 9:50 ` Dan Carpenter
2018-08-20 12:55 ` Bhaskar Singh
0 siblings, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2018-08-20 9:50 UTC (permalink / raw)
To: Bhaskar Singh; +Cc: devel, gregkh, linux-kernel
On Fri, Aug 17, 2018 at 01:17:29PM +0530, Bhaskar Singh wrote:
> This patch removed code which are valid for IEEE 802.11a i.e. 5GHz.
I would be uncomfortable accepting this kind of change without an Ack
from the maintainers.
The messes up the indenting so we can accept it anyway.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8188eu: Removed code valid for 5GHz
2018-08-20 9:50 ` Dan Carpenter
@ 2018-08-20 12:55 ` Bhaskar Singh
2018-08-20 13:17 ` Dan Carpenter
0 siblings, 1 reply; 4+ messages in thread
From: Bhaskar Singh @ 2018-08-20 12:55 UTC (permalink / raw)
To: Dan Carpenter; +Cc: devel, gregkh, linux-kernel
On Mon, Aug 20, 2018 at 12:50:43PM +0300, Dan Carpenter wrote:
> On Fri, Aug 17, 2018 at 01:17:29PM +0530, Bhaskar Singh wrote:
> > This patch removed code which are valid for IEEE 802.11a i.e. 5GHz.
>
> I would be uncomfortable accepting this kind of change without an Ack
> from the maintainers.
>
> The messes up the indenting so we can accept it anyway.
>
> regards,
> dan carpenter
>
"find and remove remaining code valid only for 5 HGz. Most of the
obvious ones have been removed, but things like channel > 14 still
exist."
With due respect, I want to say that, the above thing is mention on the
TODO list, please correct if I intrepreted that statement wrongly.
And Thanks a lot for finding indentation problem
Thanks,
Bhaskar Singh
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8188eu: Removed code valid for 5GHz
2018-08-20 12:55 ` Bhaskar Singh
@ 2018-08-20 13:17 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2018-08-20 13:17 UTC (permalink / raw)
To: Bhaskar Singh; +Cc: devel, gregkh, linux-kernel
On Mon, Aug 20, 2018 at 06:25:39PM +0530, Bhaskar Singh wrote:
> On Mon, Aug 20, 2018 at 12:50:43PM +0300, Dan Carpenter wrote:
> > On Fri, Aug 17, 2018 at 01:17:29PM +0530, Bhaskar Singh wrote:
> > > This patch removed code which are valid for IEEE 802.11a i.e. 5GHz.
> >
> > I would be uncomfortable accepting this kind of change without an Ack
> > from the maintainers.
> >
> > The messes up the indenting so we can accept it anyway.
> >
> > regards,
> > dan carpenter
> >
>
> "find and remove remaining code valid only for 5 HGz. Most of the
> obvious ones have been removed, but things like channel > 14 still
> exist."
> With due respect, I want to say that, the above thing is mention on the
> TODO list, please correct if I intrepreted that statement wrongly.
>
Yeah. I think you interpreted it correctly. That seems fine then.
When I realized that we weren't going to merge the patch then I stopped
reviewing without looking at the TODO.
When you resend the patch, please quote all the relevant information
from the TODO so that we don't have to look for it:
This patch removes support for channels > 14. That is from the
TODO which says:
- find and remove remaining code valid only for 5 HGz. Most of
the obvious ones have been removed, but things like channel >
14 still exist.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-20 13:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-17 7:47 [PATCH] staging: rtl8188eu: Removed code valid for 5GHz Bhaskar Singh
2018-08-20 9:50 ` Dan Carpenter
2018-08-20 12:55 ` Bhaskar Singh
2018-08-20 13:17 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).