* [PATCH] regulator: bd71837: Remove duplicate assignment for n_voltages of LDO2
@ 2018-08-24 11:16 Axel Lin
2018-08-27 5:34 ` Matti Vaittinen
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2018-08-24 11:16 UTC (permalink / raw)
To: Mark Brown; +Cc: Matti Vaittinen, Liam Girdwood, linux-kernel, Axel Lin
Set it once is enough.
Also move n_voltages close to volt_table for better readability.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/bd71837-regulator.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/regulator/bd71837-regulator.c b/drivers/regulator/bd71837-regulator.c
index 0f8ac8dec3e1..9b5e1297902f 100644
--- a/drivers/regulator/bd71837-regulator.c
+++ b/drivers/regulator/bd71837-regulator.c
@@ -388,10 +388,9 @@ static const struct regulator_desc bd71837_regulators[] = {
.ops = &bd71837_ldo_regulator_nolinear_ops,
.type = REGULATOR_VOLTAGE,
.volt_table = &ldo_2_volts[0],
+ .n_voltages = ARRAY_SIZE(ldo_2_volts),
.vsel_reg = BD71837_REG_LDO2_VOLT,
.vsel_mask = LDO2_MASK,
- .n_voltages = ARRAY_SIZE(ldo_2_volts),
- .n_voltages = BD71837_LDO2_VOLTAGE_NUM,
.enable_reg = BD71837_REG_LDO2_VOLT,
.enable_mask = BD71837_LDO_EN,
.owner = THIS_MODULE,
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] regulator: bd71837: Remove duplicate assignment for n_voltages of LDO2
2018-08-24 11:16 [PATCH] regulator: bd71837: Remove duplicate assignment for n_voltages of LDO2 Axel Lin
@ 2018-08-27 5:34 ` Matti Vaittinen
0 siblings, 0 replies; 2+ messages in thread
From: Matti Vaittinen @ 2018-08-27 5:34 UTC (permalink / raw)
To: Axel Lin; +Cc: Mark Brown, Liam Girdwood, linux-kernel
Thanks Axel,
On Fri, Aug 24, 2018 at 07:16:12PM +0800, Axel Lin wrote:
> Set it once is enough.
> Also move n_voltages close to volt_table for better readability.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/regulator/bd71837-regulator.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/regulator/bd71837-regulator.c b/drivers/regulator/bd71837-regulator.c
> index 0f8ac8dec3e1..9b5e1297902f 100644
> --- a/drivers/regulator/bd71837-regulator.c
> +++ b/drivers/regulator/bd71837-regulator.c
> @@ -388,10 +388,9 @@ static const struct regulator_desc bd71837_regulators[] = {
> .ops = &bd71837_ldo_regulator_nolinear_ops,
> .type = REGULATOR_VOLTAGE,
> .volt_table = &ldo_2_volts[0],
> + .n_voltages = ARRAY_SIZE(ldo_2_volts),
> .vsel_reg = BD71837_REG_LDO2_VOLT,
> .vsel_mask = LDO2_MASK,
> - .n_voltages = ARRAY_SIZE(ldo_2_volts),
> - .n_voltages = BD71837_LDO2_VOLTAGE_NUM,
> .enable_reg = BD71837_REG_LDO2_VOLT,
> .enable_mask = BD71837_LDO_EN,
> .owner = THIS_MODULE,
> --
> 2.17.1
>
This is how it should have been in the first place!
Br,
Matti Vaittinen
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-27 5:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-24 11:16 [PATCH] regulator: bd71837: Remove duplicate assignment for n_voltages of LDO2 Axel Lin
2018-08-27 5:34 ` Matti Vaittinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).